All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer
Date: Wed, 29 Nov 2017 07:34:06 +0800	[thread overview]
Message-ID: <5A1DF26E.6040306@linux.intel.com> (raw)
In-Reply-To: <87o9nmzv48.fsf@linux.intel.com>

Hi Felipe,

On 11/28/2017 04:05 PM, Felipe Balbi wrote:
> Hi,
>
> Lu Baolu <baolu.lu@linux.intel.com> writes:
>> The kernel FIFO implementation, kfifo, provides interfaces to manipulate
>> a first-in-first-out circular buffer.  Use kfifo instead of the homemade
>> one to make the code more concise and readable.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Thanks :-) Can you give a little description of how you tested this?
>

I tested it on an Intel Skylake box. On the gadget side, I loaded a serial
device (#modprobe g_serial). And then, connected it with a host.

On the gadget side, I run below scripts:

#!/bin/bash

for j in `seq 1 200`;
do
        for i in `seq 1 50000`;
        do
                echo $i.$j > /dev/ttyGS0
        done
done

And, on the host side,

#cat /dev/ttyACM0

Best regards,
Lu Baolu

      reply	other threads:[~2017-11-28 23:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  4:46 [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer Lu Baolu
2017-11-28  8:05 ` Felipe Balbi
2017-11-28 23:34   ` Lu Baolu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A1DF26E.6040306@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.