Re: [PATCH] brcmfmac: Add sg parameters dts parsing

[Arend van Spriel <arend.vanspriel@broadcom.com>]

On 12/1/2017 8:55 AM, Chi-Hsien Lin wrote:
> broken_sg_support, sd_head_align, and sd_sgentry_align are used in
> brcmfmac code but not configurable in dts file. Add the parsing logic.
> Now they can be configured like below in dts:
> 	brcm,broken_sg_support;
> 	brcm,sd_head_align =/bits/  16 <4>;
> 	brcm,sd_sgentry_align =/bits/  16 <4>;

Hi Chi-Hsien,

For device tree support you should submit a separate commit on the dt 
binding specification. For broadcom fullmac chipsets binding spec can be 
found in 
Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt.

The alignment properties are to be specified in bytes, not bits.

Regards,
Arend