All of lore.kernel.org
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: Fabio Estevam <festevam@gmail.com>, gustavo@padovan.org
Cc: Fabio Estevam <fabio.estevam@nxp.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm/exynos: decon5433: Remove unnecessary platform_get_resource() error check
Date: Tue, 19 Dec 2017 08:44:18 +0900	[thread overview]
Message-ID: <5A3852D2.3080203@samsung.com> (raw)
In-Reply-To: <1513602150-7542-2-git-send-email-festevam@gmail.com>



2017년 12월 18일 22:02에 Fabio Estevam 이(가) 쓴 글:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
> 
> Cc: Inki Dae <inki.dae@samsung.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> index 6be5b53..1d509a8 100644
> --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
> @@ -744,11 +744,6 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
>  	}
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(dev, "cannot find IO resource\n");
> -		return -ENXIO;
> -	}
> -

Picked it up.

Thanks,
Inki Dae

>  	ctx->addr = devm_ioremap_resource(dev, res);
>  	if (IS_ERR(ctx->addr)) {
>  		dev_err(dev, "ioremap failed\n");
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-12-18 23:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18 13:02 [PATCH 1/7] drm/bridge/synopsys: dsi: Remove unnecessary platform_get_resource() error check Fabio Estevam
2017-12-18 13:02 ` [PATCH 2/7] drm/exynos: decon5433: " Fabio Estevam
2017-12-18 13:28   ` Andrzej Hajda
2017-12-18 23:44   ` Inki Dae [this message]
2017-12-18 13:02 ` [PATCH 3/7] drm/rockchip: dsi: " Fabio Estevam
2017-12-18 13:02 ` [PATCH 4/7] drm/rockchip: inno_hdmi: " Fabio Estevam
2017-12-18 13:02 ` [PATCH 5/7] drm/stm: dsi: " Fabio Estevam
2017-12-19 14:14   ` Philippe CORNU
2017-12-19 14:28     ` Benjamin Gaignard
2017-12-18 13:02 ` [PATCH 6/7] drm/stm: ltdc: " Fabio Estevam
2017-12-19 14:15   ` Philippe CORNU
2017-12-19 14:28     ` Benjamin Gaignard
2017-12-18 13:02 ` [PATCH 7/7] drm/tegra: vic: " Fabio Estevam
2017-12-19 14:32 ` [PATCH 1/7] drm/bridge/synopsys: dsi: " Philippe CORNU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A3852D2.3080203@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=gustavo@padovan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.