From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tan Xiaojun Subject: Re: [PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup Date: Mon, 25 Dec 2017 16:30:46 +0800 Message-ID: <5A40B736.9070502@huawei.com> References: <1514173414-28325-1-git-send-email-tanxiaojun@huawei.com> <97ceaf9e-3d04-89a6-062b-6c9170a501a9@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from huawei.com (unknown [45.249.212.32]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE84A6E013 for ; Mon, 25 Dec 2017 08:31:10 +0000 (UTC) In-Reply-To: <97ceaf9e-3d04-89a6-062b-6c9170a501a9@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , seanpaul@chromium.org, airlied@linux.ie, michel.daenzer@amd.com, alexander.deucher@amd.com, nicolai.haehnle@amd.com, thomas.lendacky@amd.com, yamada.masahiro@socionext.com, msrb@suse.com, Felix.Kuehling@amd.com, dave.jiang@intel.com, gregkh@linuxfoundation.org, michael.thayer@oracle.com, hdegoede@redhat.com Cc: daniel.vetter@intel.com, wangzhou1@hisilicon.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMjAxNy8xMi8yNSAxNjoxOCwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBTZXJpZXMgaXMg UmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4u Cj4gCj4gSSdtIGdvaW5nIHRvIHBpY2sgdGhhdCB1cCBmb3IgNC4xNi4KPiAKPiBUaGFua3MgZm9y IHRoZSBjbGVhbnVwLAo+IENocmlzdGlhbi4KPiAKClRoYW5rIHlvdSB2ZXJ5IG11Y2guClhpYW9q dW4uCgo+IEFtIDI1LjEyLjIwMTcgdW0gMDQ6NDMgc2NocmllYiBUYW4gWGlhb2p1bjoKPj4gSSBm b3VuZCBhbiBPT1BTIHdoZW4gSSB1c2VkIHRoZSBtYWlubGluZSBrZXJuZWwgZm9yIGdyYXBoaWNh bCB0ZXN0cyBpbiBIaXNpbGljb24KPj4gRDA1LCBJIGRvIG5vdCBrbm93IGhvdyB0byBzb2x2ZSB0 aGlzIHByb2JsZW0gdW50aWwgSSBzYXcgeW91ciBkaXNjdXNzaW9uIG9uIHRoaXMKPj4gaXNzdWUg YSBtb250aCBhZ286Cj4+Cj4+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVz L2RyaS1kZXZlbC8yMDE3LU5vdmVtYmVyLzE1OTA0Ni5odG1sCj4+Cj4+IEFuZCBteSBwcm9ibGVt IGNhbiBiZSBzb2x2ZWQgcGVyZmVjdGx5IGJ5IHlvdXIgc29sdXRpb24uCj4+Cj4+IFRoaXMgaXMg aW1wb3J0YW50IGZvciBtZSwgSSB3YW50IHRvIHNvbHZlIHRoaXMgcHJvYmxlbSBhcyBzb29uIGFz IHBvc3NpYmxlLiBTbwo+PiBJIGZvbGxvdyB0aGUgcmVzdWx0IG9mIHlvdXIgZGlzY3Vzc2lvbiwg bWFrZSBhbmQgc2VuZCB0aGVzZSBwYXRjaGVzIGJlbG93Lgo+Pgo+PiBJZiBhbnl0aGluZyBpcyBu b3QgZ29vZCwgcGxlYXNlIHBvaW50IGl0IG91dCwgdGhhbmtzLgo+Pgo+PiBDaGFuZ2UgbG9ncyBv ZiB2MjoKPj4gICAqIGFkZCBuZXcgZnVuY3Rpb24gdG8gaW5zdGVhZCBvZiB0dG1fYm9fZGVmYXVs dF9pb19tZW1fcGZuKCkgYW5kCj4+ICAgICBkbyBzb21lIGNsZWFudXAuCj4+Cj4+IFRhbiBYaWFv anVuICgxMik6Cj4+ICAgIGRybS90dG06IGFkZCB0dG1fYm9faW9fbWVtX3BmbiB0byBjaGVjayBp b19tZW1fcGZuCj4+ICAgIGRybS9hc3Q6IHJlbW92ZSB0aGUgZGVmYXVsdCBpb19tZW1fcGZuIHNl dAo+PiAgICBkcm0vYm9jaHM6IHJlbW92ZSB0aGUgZGVmYXVsdCBpb19tZW1fcGZuIHNldAo+PiAg ICBkcm0vY2lycnVzOiByZW1vdmUgdGhlIGRlZmF1bHQgaW9fbWVtX3BmbiBzZXQKPj4gICAgZHJt L21nYWcyMDA6IHJlbW92ZSB0aGUgZGVmYXVsdCBpb19tZW1fcGZuIHNldAo+PiAgICBkcm0vbm91 dmVhdTogcmVtb3ZlIHRoZSBkZWZhdWx0IGlvX21lbV9wZm4gc2V0Cj4+ICAgIGRybS9xeGw6IHJl bW92ZSB0aGUgZGVmYXVsdCBpb19tZW1fcGZuIHNldAo+PiAgICBkcm0vcmFkZW9uOiByZW1vdmUg dGhlIGRlZmF1bHQgaW9fbWVtX3BmbiBzZXQKPj4gICAgZHJtL3ZpcnRpbzogcmVtb3ZlIHRoZSBk ZWZhdWx0IGlvX21lbV9wZm4gc2V0Cj4+ICAgIGRybS92bXdnZng6IHJlbW92ZSB0aGUgZGVmYXVs dCBpb19tZW1fcGZuIHNldAo+PiAgICBzdGFnaW5nOiByZW1vdmUgdGhlIGRlZmF1bHQgaW9fbWVt X3BmbiBzZXQKPj4gICAgZHJtL3R0bTogcmVtb3ZlIHR0bV9ib19kZWZhdWx0X2lvX21lbV9wZm4K Pj4KPj4gICBkcml2ZXJzL2dwdS9kcm0vYXN0L2FzdF90dG0uYyAgICAgICAgICB8ICAxIC0KPj4g ICBkcml2ZXJzL2dwdS9kcm0vYm9jaHMvYm9jaHNfbW0uYyAgICAgICB8ICAxIC0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vY2lycnVzL2NpcnJ1c190dG0uYyAgICB8ICAxIC0KPj4gICBkcml2ZXJzL2dw dS9kcm0vbWdhZzIwMC9tZ2FnMjAwX3R0bS5jICB8ICAxIC0KPj4gICBkcml2ZXJzL2dwdS9kcm0v bm91dmVhdS9ub3V2ZWF1X2JvLmMgICB8ICAxIC0KPj4gICBkcml2ZXJzL2dwdS9kcm0vcXhsL3F4 bF90dG0uYyAgICAgICAgICB8ICAxIC0KPj4gICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVv bl90dG0uYyAgICB8ICAxIC0KPj4gICBkcml2ZXJzL2dwdS9kcm0vdHRtL3R0bV9ib192bS5jICAg ICAgICB8IDIyICsrKysrKysrKysrKystLS0tLS0tLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vdmly dGlvL3ZpcnRncHVfdHRtLmMgICB8ICAxIC0KPj4gICBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Zt d2dmeF9idWZmZXIuYyB8ICAxIC0KPj4gICBkcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hf dHRtLmMgICB8ICAxIC0KPj4gICBpbmNsdWRlL2RybS90dG0vdHRtX2JvX2FwaS5oICAgICAgICAg ICB8IDExIC0tLS0tLS0tLS0tCj4+ICAgMTIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygr KSwgMzAgZGVsZXRpb25zKC0pCj4+Cj4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbdLYIbL (ORCPT ); Mon, 25 Dec 2017 03:31:11 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:46791 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750814AbdLYIbJ (ORCPT ); Mon, 25 Dec 2017 03:31:09 -0500 Subject: Re: [PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup To: =?UTF-8?Q?Christian_K=c3=b6nig?= , , , , , , , , , , , , , References: <1514173414-28325-1-git-send-email-tanxiaojun@huawei.com> <97ceaf9e-3d04-89a6-062b-6c9170a501a9@amd.com> CC: , , , , From: Tan Xiaojun Message-ID: <5A40B736.9070502@huawei.com> Date: Mon, 25 Dec 2017 16:30:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <97ceaf9e-3d04-89a6-062b-6c9170a501a9@amd.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.21.79] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/12/25 16:18, Christian König wrote: > Series is Reviewed-by: Christian König . > > I'm going to pick that up for 4.16. > > Thanks for the cleanup, > Christian. > Thank you very much. Xiaojun. > Am 25.12.2017 um 04:43 schrieb Tan Xiaojun: >> I found an OOPS when I used the mainline kernel for graphical tests in Hisilicon >> D05, I do not know how to solve this problem until I saw your discussion on this >> issue a month ago: >> >> https://lists.freedesktop.org/archives/dri-devel/2017-November/159046.html >> >> And my problem can be solved perfectly by your solution. >> >> This is important for me, I want to solve this problem as soon as possible. So >> I follow the result of your discussion, make and send these patches below. >> >> If anything is not good, please point it out, thanks. >> >> Change logs of v2: >> * add new function to instead of ttm_bo_default_io_mem_pfn() and >> do some cleanup. >> >> Tan Xiaojun (12): >> drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn >> drm/ast: remove the default io_mem_pfn set >> drm/bochs: remove the default io_mem_pfn set >> drm/cirrus: remove the default io_mem_pfn set >> drm/mgag200: remove the default io_mem_pfn set >> drm/nouveau: remove the default io_mem_pfn set >> drm/qxl: remove the default io_mem_pfn set >> drm/radeon: remove the default io_mem_pfn set >> drm/virtio: remove the default io_mem_pfn set >> drm/vmwgfx: remove the default io_mem_pfn set >> staging: remove the default io_mem_pfn set >> drm/ttm: remove ttm_bo_default_io_mem_pfn >> >> drivers/gpu/drm/ast/ast_ttm.c | 1 - >> drivers/gpu/drm/bochs/bochs_mm.c | 1 - >> drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - >> drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - >> drivers/gpu/drm/qxl/qxl_ttm.c | 1 - >> drivers/gpu/drm/radeon/radeon_ttm.c | 1 - >> drivers/gpu/drm/ttm/ttm_bo_vm.c | 22 +++++++++++++--------- >> drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - >> drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - >> drivers/staging/vboxvideo/vbox_ttm.c | 1 - >> include/drm/ttm/ttm_bo_api.h | 11 ----------- >> 12 files changed, 13 insertions(+), 30 deletions(-) >> > > >