Re: [RFC PATCH v12 2/5] of/irq: Adjust of_pci_irq parsing for multiple interrupts

[JeffyChen <jeffy.chen@rock-chips.com>]

Hi Rob,

Thanks for your reply :)

On 12/26/2017 11:48 PM, Rob Herring wrote:
>> >+               /*
>> >+                * Only parse from DT if we have no "interrupt-names",
>> >+                * or if we found an interrupt named "pci".
>> >+                */
>> >+               if (index == 0 || name) {
>> >+                       rc = of_irq_parse_one(dn, index, out_irq);
>> >+                       if (!rc)
>> >+                               return rc;
>> >+               }
> As mentioned before, use of_property_match_string. The following should work:
>
> index = of_property_match_string(dn, "interrupt-names", "pci");
> if (index == -EINVAL)  /* Property doesn't exist */
>    index = 0;
>
> if (index >= 0) {
>    rc = of_irq_parse_one(dn, index, out_irq);
>    if (!rc)
>      return rc;
> }

hmmm, right, that should work. didn't notice of_property_match_string() 
would return different error numbers for string not found and property 
doesn't exist...

will do this in the next version, thanks :)

>
>