From: Chanwoo Choi <cw00.choi@samsung.com>
To: Hans de Goede <hdegoede@redhat.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] extcon: axp288: Remove unused extcon_nb struct member
Date: Tue, 02 Jan 2018 09:36:01 +0900 [thread overview]
Message-ID: <5A4AD3F1.8070100@samsung.com> (raw)
In-Reply-To: <20171222123616.9562-1-hdegoede@redhat.com>
On 2017년 12월 22일 21:36, Hans de Goede wrote:
> Remove the unused extcon_nb struct member.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/extcon/extcon-axp288.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 981fba56bc18..ba185e9ebb82 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -107,7 +107,6 @@ struct axp288_extcon_info {
> struct gpio_desc *gpio_mux_cntl;
> int irq[EXTCON_IRQ_END];
> struct extcon_dev *edev;
> - struct notifier_block extcon_nb;
> unsigned int previous_cable;
> };
>
>
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2018-01-02 0:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171222123627epcas1p25953168cb2b1432d2065c0068a71397f@epcas1p2.samsung.com>
2017-12-22 12:36 ` [PATCH 1/4] extcon: axp288: Remove unused extcon_nb struct member Hans de Goede
2017-12-22 12:36 ` [PATCH 2/4] extcon: axp288: Remove unused platform data Hans de Goede
2018-01-02 0:35 ` Chanwoo Choi
2018-01-02 9:16 ` Lee Jones
2018-01-03 1:34 ` Chanwoo Choi
2018-01-03 9:37 ` Lee Jones
2018-01-03 9:53 ` Chanwoo Choi
2018-01-05 10:44 ` Lee Jones
2017-12-22 12:36 ` [PATCH 3/4] extcon: axp288: Redo charger type dection a couple of seconds after probe() Hans de Goede
2018-01-02 0:54 ` Chanwoo Choi
2018-01-02 22:44 ` Hans de Goede
2018-01-03 0:58 ` Chanwoo Choi
2018-01-03 1:04 ` Chanwoo Choi
2017-12-22 12:36 ` [PATCH 4/4] extcon: axp288: Handle reserved charger-type values better Hans de Goede
2018-01-02 0:55 ` Chanwoo Choi
2018-01-02 0:36 ` Chanwoo Choi [this message]
2018-01-03 1:17 ` [PATCH 1/4] extcon: axp288: Remove unused extcon_nb struct member Chanwoo Choi
2018-01-03 8:08 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A4AD3F1.8070100@samsung.com \
--to=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.