From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-2896-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id EC9C858191A8 for ; Wed, 3 Jan 2018 00:58:15 -0800 (PST) Message-ID: <5A4C9BAC.3040808@intel.com> Date: Wed, 03 Jan 2018 17:00:28 +0800 From: Wei Wang MIME-Version: 1.0 References: <1513685879-21823-5-git-send-email-wei.w.wang@intel.com> <20171224032121.GA5273@bombadil.infradead.org> <201712241345.DIG21823.SLFOOJtQFOMVFH@I-love.SAKURA.ne.jp> <5A3F5A4A.1070009@intel.com> <20180102132419.GB8222@bombadil.infradead.org> <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> In-Reply-To: <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG To: Tetsuo Handa , willy@infradead.org Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org, mawilcox@microsoft.com, david@redhat.com, cornelia.huck@de.ibm.com, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com List-ID: On 01/03/2018 10:29 AM, Tetsuo Handa wrote: > Matthew Wilcox wrote: >> The radix tree convention is objectively awful, which is why I'm working >> to change it. Specifying the GFP flags at radix tree initialisation time >> rather than allocation time leads to all kinds of confusion. The preload >> API is a pretty awful workaround, and it will go away once the XArray >> is working correctly. That said, there's no alternative to it without >> making XBitmap depend on XArray, and I don't want to hold you up there. >> So there's an xb_preload for the moment. > I'm ready to propose cvbmp shown below as an alternative to xbitmap (but > specialized for virtio-balloon case). Wei, can you do some benchmarking > between xbitmap and cvbmp? > ---------------------------------------- > cvbmp: clustered values bitmap I don't think we need to replace xbitmap, at least at this stage. The new implementation doesn't look simpler at all, and virtio-balloon has worked well with xbitmap. I would suggest you to send out the new implementation for discussion after this series ends, and justify with better performance results if you could get. Best, Wei --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Wang Subject: Re: [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG Date: Wed, 03 Jan 2018 17:00:28 +0800 Message-ID: <5A4C9BAC.3040808@intel.com> References: <1513685879-21823-5-git-send-email-wei.w.wang@intel.com> <20171224032121.GA5273@bombadil.infradead.org> <201712241345.DIG21823.SLFOOJtQFOMVFH@I-love.SAKURA.ne.jp> <5A3F5A4A.1070009@intel.com> <20180102132419.GB8222@bombadil.infradead.org> <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org, mawilcox@microsoft.com, david@redhat.com, cornelia.huck@de.ibm.com, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com To: Tetsuo Handa , willy@infradead.org Return-path: In-Reply-To: <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> Sender: owner-linux-mm@kvack.org List-Id: kvm.vger.kernel.org On 01/03/2018 10:29 AM, Tetsuo Handa wrote: > Matthew Wilcox wrote: >> The radix tree convention is objectively awful, which is why I'm working >> to change it. Specifying the GFP flags at radix tree initialisation time >> rather than allocation time leads to all kinds of confusion. The preload >> API is a pretty awful workaround, and it will go away once the XArray >> is working correctly. That said, there's no alternative to it without >> making XBitmap depend on XArray, and I don't want to hold you up there. >> So there's an xb_preload for the moment. > I'm ready to propose cvbmp shown below as an alternative to xbitmap (but > specialized for virtio-balloon case). Wei, can you do some benchmarking > between xbitmap and cvbmp? > ---------------------------------------- > cvbmp: clustered values bitmap I don't think we need to replace xbitmap, at least at this stage. The new implementation doesn't look simpler at all, and virtio-balloon has worked well with xbitmap. I would suggest you to send out the new implementation for discussion after this series ends, and justify with better performance results if you could get. Best, Wei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbeACI6g (ORCPT + 1 other); Wed, 3 Jan 2018 03:58:36 -0500 Received: from mga03.intel.com ([134.134.136.65]:27303 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbeACI6O (ORCPT ); Wed, 3 Jan 2018 03:58:14 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,500,1508828400"; d="scan'208";a="6981629" Message-ID: <5A4C9BAC.3040808@intel.com> Date: Wed, 03 Jan 2018 17:00:28 +0800 From: Wei Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Tetsuo Handa , willy@infradead.org CC: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org, mawilcox@microsoft.com, david@redhat.com, cornelia.huck@de.ibm.com, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com Subject: Re: [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG References: <1513685879-21823-5-git-send-email-wei.w.wang@intel.com> <20171224032121.GA5273@bombadil.infradead.org> <201712241345.DIG21823.SLFOOJtQFOMVFH@I-love.SAKURA.ne.jp> <5A3F5A4A.1070009@intel.com> <20180102132419.GB8222@bombadil.infradead.org> <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> In-Reply-To: <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/03/2018 10:29 AM, Tetsuo Handa wrote: > Matthew Wilcox wrote: >> The radix tree convention is objectively awful, which is why I'm working >> to change it. Specifying the GFP flags at radix tree initialisation time >> rather than allocation time leads to all kinds of confusion. The preload >> API is a pretty awful workaround, and it will go away once the XArray >> is working correctly. That said, there's no alternative to it without >> making XBitmap depend on XArray, and I don't want to hold you up there. >> So there's an xb_preload for the moment. > I'm ready to propose cvbmp shown below as an alternative to xbitmap (but > specialized for virtio-balloon case). Wei, can you do some benchmarking > between xbitmap and cvbmp? > ---------------------------------------- > cvbmp: clustered values bitmap I don't think we need to replace xbitmap, at least at this stage. The new implementation doesn't look simpler at all, and virtio-balloon has worked well with xbitmap. I would suggest you to send out the new implementation for discussion after this series ends, and justify with better performance results if you could get. Best, Wei From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWesM-0003pu-TH for qemu-devel@nongnu.org; Wed, 03 Jan 2018 03:58:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWesJ-0001Zb-2F for qemu-devel@nongnu.org; Wed, 03 Jan 2018 03:58:19 -0500 Received: from mga11.intel.com ([192.55.52.93]:43012) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eWesI-0001Yu-OY for qemu-devel@nongnu.org; Wed, 03 Jan 2018 03:58:14 -0500 Message-ID: <5A4C9BAC.3040808@intel.com> Date: Wed, 03 Jan 2018 17:00:28 +0800 From: Wei Wang MIME-Version: 1.0 References: <1513685879-21823-5-git-send-email-wei.w.wang@intel.com> <20171224032121.GA5273@bombadil.infradead.org> <201712241345.DIG21823.SLFOOJtQFOMVFH@I-love.SAKURA.ne.jp> <5A3F5A4A.1070009@intel.com> <20180102132419.GB8222@bombadil.infradead.org> <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> In-Reply-To: <201801031129.JFC18298.FJMHtOFLVSQOFO@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tetsuo Handa , willy@infradead.org Cc: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, linux-mm@kvack.org, mst@redhat.com, mhocko@kernel.org, akpm@linux-foundation.org, mawilcox@microsoft.com, david@redhat.com, cornelia.huck@de.ibm.com, mgorman@techsingularity.net, aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, liliang.opensource@gmail.com, yang.zhang.wz@gmail.com, quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com On 01/03/2018 10:29 AM, Tetsuo Handa wrote: > Matthew Wilcox wrote: >> The radix tree convention is objectively awful, which is why I'm working >> to change it. Specifying the GFP flags at radix tree initialisation time >> rather than allocation time leads to all kinds of confusion. The preload >> API is a pretty awful workaround, and it will go away once the XArray >> is working correctly. That said, there's no alternative to it without >> making XBitmap depend on XArray, and I don't want to hold you up there. >> So there's an xb_preload for the moment. > I'm ready to propose cvbmp shown below as an alternative to xbitmap (but > specialized for virtio-balloon case). Wei, can you do some benchmarking > between xbitmap and cvbmp? > ---------------------------------------- > cvbmp: clustered values bitmap I don't think we need to replace xbitmap, at least at this stage. The new implementation doesn't look simpler at all, and virtio-balloon has worked well with xbitmap. I would suggest you to send out the new implementation for discussion after this series ends, and justify with better performance results if you could get. Best, Wei