All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Hans de Goede <hdegoede@redhat.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chen-Yu Tsai <wens@csie.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] extcon: axp288: Constify the axp288_pwr_up_down_info array
Date: Mon, 15 Jan 2018 14:35:45 +0900	[thread overview]
Message-ID: <5A5C3DB1.5080604@samsung.com> (raw)
In-Reply-To: <20180114151021.11432-1-hdegoede@redhat.com>

On 2018년 01월 15일 00:10, Hans de Goede wrote:
> Make the axp288_pwr_up_down_info array const char * const, this leads
> to the following section size changes:
> 
> .text     0x674 -> 0x664
> .data     0x148 -> 0x0f0
> .rodata   0x0b4 -> 0x114
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/extcon/extcon-axp288.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 081d8a1b4fd7..63b99d5becd7 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -118,7 +118,7 @@ static const struct x86_cpu_id cherry_trail_cpu_ids[] = {
>  };
>  
>  /* Power up/down reason string array */
> -static char *axp288_pwr_up_down_info[] = {
> +static const char * const axp288_pwr_up_down_info[] = {
>  	"Last wake caused by user pressing the power button",
>  	"Last wake caused by a charger insertion",
>  	"Last wake caused by a battery insertion",
> @@ -136,7 +136,7 @@ static char *axp288_pwr_up_down_info[] = {
>   */
>  static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
>  {
> -	char **rsi;
> +	const char * const *rsi;
>  	unsigned int val, i, clear_mask = 0;
>  	int ret;
>  
> 

Applied it to v4.17
because I had finished the extcon pull request for v4.16.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

      parent reply	other threads:[~2018-01-15  5:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180114151033epcas4p4f32a575853ca8d34d2eb362ba7d8b197@epcas4p4.samsung.com>
2018-01-14 15:10 ` [PATCH 1/2] extcon: axp288: Constify the axp288_pwr_up_down_info array Hans de Goede
2018-01-14 15:10   ` [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected Hans de Goede
2018-01-15  5:22     ` Chanwoo Choi
2018-01-15  8:36       ` Hans de Goede
2018-01-15  9:08         ` Chanwoo Choi
2018-01-15 11:32           ` Hans de Goede
2018-01-15 23:43             ` Chanwoo Choi
2018-01-16  9:33               ` Hans de Goede
2018-01-17  1:04                 ` Chanwoo Choi
2018-01-25 17:06                   ` Hans de Goede
2018-01-15  5:35   ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A5C3DB1.5080604@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.