From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cathy Avery <cavery@redhat.com>
Date: Tue, 16 Jan 2018 14:36:24 +0000
Subject: Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()
Message-Id: <5A5E0DE8.7080603@redhat.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20180116104022.GA3517@mwanda>
In-Reply-To: <20180116104022.GA3517@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>, "K. Y. Srinivasan" <kys@microsoft.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org, Haiyang Zhang <haiyangz@microsoft.com>, kernel-janitors@vger.kernel.org, devel@linuxdriverproject.org, Stephen Hemminger <sthemmin@microsoft.com>

On 01/16/2018 05:40 AM, Dan Carpenter wrote:
> We should set the error code if fc_remote_port_add() fails.
>
> Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3b3d1d050cac..40fc7a590e81 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1834,8 +1834,10 @@ static int storvsc_probe(struct hv_device *device,
>   		fc_host_node_name(host) = stor_device->node_name;
>   		fc_host_port_name(host) = stor_device->port_name;
>   		stor_device->rport = fc_remote_port_add(host, 0, &ids);
> -		if (!stor_device->rport)
> +		if (!stor_device->rport) {
> +			ret = -ENOMEM;
>   			goto err_out4;
> +		}
>   	}
>   #endif
>   	return 0;

Reviewed-by: Cathy Avery <cavery@redhat.com>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cathy Avery <cavery@redhat.com>
Subject: Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()
Date: Tue, 16 Jan 2018 09:36:24 -0500
Message-ID: <5A5E0DE8.7080603@redhat.com>
References: <20180116104022.GA3517@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <driverdev-devel-bounces@linuxdriverproject.org>
In-Reply-To: <20180116104022.GA3517@mwanda>
List-Unsubscribe: <http://driverdev.linuxdriverproject.org/mailman/options/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
List-Archive: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/>
List-Post: <mailto:driverdev-devel@linuxdriverproject.org>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
 <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
Errors-To: driverdev-devel-bounces@linuxdriverproject.org
Sender: "devel" <driverdev-devel-bounces@linuxdriverproject.org>
To: Dan Carpenter <dan.carpenter@oracle.com>, "K. Y. Srinivasan" <kys@microsoft.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org, Haiyang Zhang <haiyangz@microsoft.com>, kernel-janitors@vger.kernel.org, devel@linuxdriverproject.org, Stephen Hemminger <sthemmin@microsoft.com>
List-Id: linux-scsi@vger.kernel.org

On 01/16/2018 05:40 AM, Dan Carpenter wrote:
> We should set the error code if fc_remote_port_add() fails.
>
> Fixes: daf0cd445a21 ("scsi: storvsc: Add support for FC rport.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3b3d1d050cac..40fc7a590e81 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1834,8 +1834,10 @@ static int storvsc_probe(struct hv_device *device,
>   		fc_host_node_name(host) = stor_device->node_name;
>   		fc_host_port_name(host) = stor_device->port_name;
>   		stor_device->rport = fc_remote_port_add(host, 0, &ids);
> -		if (!stor_device->rport)
> +		if (!stor_device->rport) {
> +			ret = -ENOMEM;
>   			goto err_out4;
> +		}
>   	}
>   #endif
>   	return 0;

Reviewed-by: Cathy Avery <cavery@redhat.com>