From mboxrd@z Thu Jan 1 00:00:00 1970 From: JeffyChen Subject: Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU Date: Thu, 18 Jan 2018 22:25:05 +0800 Message-ID: <5A60AE41.2050101@rock-chips.com> References: <20180118115251.5542-1-jeffy.chen@rock-chips.com> <20180118115251.5542-9-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Robin Murphy , linux-kernel@vger.kernel.org, tfiga@chromium.org Cc: jcliang@chromium.org, xxm@rock-chips.com, devicetree@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, Rob Herring , Mark Rutland , Joerg Roedel , linux-arm-kernel@lists.infradead.org List-Id: iommu@lists.linux-foundation.org Hi Robin, On 01/18/2018 08:27 PM, Robin Murphy wrote: >> > > Is it worth using the clk_bulk_*() APIs for this? At a glance, most of > the code being added here appears to duplicate what those functions > already do (but I'm no clk API expert, for sure). right, i think it's doable, the clk_bulk APIs are very helpful. i think we didn't use that is because this patch were wrote for the chromeos 4.4 kernel, which doesn't have clk_bulk yet:) will do it in the next version, thanks. > > Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (JeffyChen) Date: Thu, 18 Jan 2018 22:25:05 +0800 Subject: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU In-Reply-To: References: <20180118115251.5542-1-jeffy.chen@rock-chips.com> <20180118115251.5542-9-jeffy.chen@rock-chips.com> Message-ID: <5A60AE41.2050101@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Robin, On 01/18/2018 08:27 PM, Robin Murphy wrote: >> > > Is it worth using the clk_bulk_*() APIs for this? At a glance, most of > the code being added here appears to duplicate what those functions > already do (but I'm no clk API expert, for sure). right, i think it's doable, the clk_bulk APIs are very helpful. i think we didn't use that is because this patch were wrote for the chromeos 4.4 kernel, which doesn't have clk_bulk yet:) will do it in the next version, thanks. > > Robin.