All of lore.kernel.org
 help / color / mirror / Atom feed
From: nagarathnam muthusamy <nagarathnam.muthusamy@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH spark] sparc: vDSO: remove an extra tab
Date: Fri, 19 Jan 2018 18:09:44 +0000	[thread overview]
Message-ID: <5A623468.6030906@oracle.com> (raw)
In-Reply-To: <20180119132321.GA32694@mwanda>


On 1/19/2018 5:23 AM, Dan Carpenter wrote:
> This statement is indented one tab too far which is confusing and
> leads to a Smatch warning:
>
>      arch/sparc/vdso/vma.c:254 arch_setup_additional_pages()
>      warn: curly braces intended?
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/sparc/vdso/vma.c b/arch/sparc/vdso/vma.c
> index 0a6f50098e23..f51595f861b8 100644
> --- a/arch/sparc/vdso/vma.c
> +++ b/arch/sparc/vdso/vma.c
> @@ -251,7 +251,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
>   	else
>   		return map_vdso(&vdso_image_32_builtin, &vdso_mapping32);
>   #else
> -		return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
> +	return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
>   #endif
>   
>   }
Should the subject be sparc instead of spark? Other than that,

Reviewed-by: Nagarathnam Muthusamy <nagarathnam.muthusamy@oracle.com>

Thanks!



  reply	other threads:[~2018-01-19 18:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 13:23 [PATCH spark] sparc: vDSO: remove an extra tab Dan Carpenter
2018-01-19 18:09 ` nagarathnam muthusamy [this message]
2018-01-19 18:19 ` Dan Carpenter
2018-01-22 20:01 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A623468.6030906@oracle.com \
    --to=nagarathnam.muthusamy@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.