All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wols Lists <antlists@youngman.org.uk>
To: David Brown <david.brown@hesbynett.no>,
	NeilBrown <neilb@suse.com>,
	linux-raid@vger.kernel.org
Subject: Re: Multi-layer raid status
Date: Fri, 2 Feb 2018 15:03:01 +0000	[thread overview]
Message-ID: <5A747DA5.2030801@youngman.org.uk> (raw)
In-Reply-To: <5A747AC1.8030206@hesbynett.no>

On 02/02/18 14:50, David Brown wrote:
> What are these cases?  We have already eliminated the rebuild situation
> I described.  And in particular, which use-cases are you thinking of
> where you not be better off with alternative integrity improvements
> (like higher redundancy levels) without killing performance?
> 
In particular, when you KNOW you've got a damaged raid, and you want to
know which files are affected. The whole point of my technique is that
either it uses the raid to recover (if it can) or it propagates a read
error back to the application. It does NOT "fix" the data and leave a
corrupted file behind.

>> > 
> That does not make sense.  The bad block list described by Neil will do
> the job correctly.  hdparm bad block marking could also work, but it
> does so at a lower level and the sector is /not/ corrected
> automatically, AFAIK.  It also would not help if the raid1 were not
> directly on a hard disk (think disk partition, another raid, an LVM
> partition, an iSCSI disk, a remote block device, an encrypted block
> device, etc.).
> 
Nor does the bad block list correct the error automatically, if that's
true then. The bad blocks list fakes a read error, the hdparm causes a
real read error. When the raid-5 scrub hits, either version triggers a
rewrite.

Thing about the bad-block list, is that that disk block is NOT
rewritten. It's moved, and that disk space is LOST. With hdparm, that
block gets rewritten, and if the rewrite succeeds the space is recovered.

Cheers,
Wol


  reply	other threads:[~2018-02-02 15:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 15:30 Multi-layer raid status David Brown
2018-02-02  6:03 ` NeilBrown
2018-02-02 10:41   ` David Brown
2018-02-02 11:17     ` Wols Lists
2018-02-02 11:32       ` David Brown
2018-02-02 12:12         ` Reindl Harald
2018-02-02 14:24         ` Wols Lists
2018-02-02 14:50           ` David Brown
2018-02-02 15:03             ` Wols Lists [this message]
2018-02-02 15:40               ` David Brown
2018-02-02 16:49                 ` Wols Lists

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A747DA5.2030801@youngman.org.uk \
    --to=antlists@youngman.org.uk \
    --cc=david.brown@hesbynett.no \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.