From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-version: 1.0 Content-type: text/plain; charset="UTF-8" Message-id: <5A792A2B.60603@samsung.com> Date: Tue, 06 Feb 2018 13:08:11 +0900 From: Chanwoo Choi To: Sylwester Nawrocki , linux-clk@vger.kernel.org Cc: sboyd@codeaurora.org, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, b.zolnierkie@samsung.com, m.szyprowski@samsung.com Subject: Re: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1_bclk In-reply-to: <20180205142230.9755-3-s.nawrocki@samsung.com> References: <20180205142230.9755-1-s.nawrocki@samsung.com> <20180205142230.9755-3-s.nawrocki@samsung.com> List-ID: On 2018년 02월 05일 23:22, Sylwester Nawrocki wrote: > The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver > and disabling this clock by the clk core prevents proper operation > of the I2S1 block. CLK_IGNORE_UNUSED flag is added as a temporary fix. > > Signed-off-by: Sylwester Nawrocki > --- > drivers/clk/samsung/clk-exynos5433.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index d74361736e64..15177f74e125 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -1680,7 +1680,7 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { > ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk", > "ioclk_i2s1_bclk_in", ENABLE_SCLK_PERIC, 10, > - CLK_SET_RATE_PARENT, 0), > + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), > GATE(CLK_SCLK_SPDIF, "sclk_spdif", "sclk_spdif_peric", > ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", > If any device driver handles the sclk_ioclk_i2s1_bclk on later, CLK_IGNORE_UNUSED will be ignored. Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Tue, 06 Feb 2018 13:08:11 +0900 Subject: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1_bclk In-Reply-To: <20180205142230.9755-3-s.nawrocki@samsung.com> References: <20180205142230.9755-1-s.nawrocki@samsung.com> <20180205142230.9755-3-s.nawrocki@samsung.com> Message-ID: <5A792A2B.60603@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018? 02? 05? 23:22, Sylwester Nawrocki wrote: > The sclk_ioclk_i2s1_bclk clock is not currently handled by any driver > and disabling this clock by the clk core prevents proper operation > of the I2S1 block. CLK_IGNORE_UNUSED flag is added as a temporary fix. > > Signed-off-by: Sylwester Nawrocki > --- > drivers/clk/samsung/clk-exynos5433.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index d74361736e64..15177f74e125 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -1680,7 +1680,7 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { > ENABLE_SCLK_PERIC, 11, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_IOCLK_I2S1_BCLK, "sclk_ioclk_i2s1_bclk", > "ioclk_i2s1_bclk_in", ENABLE_SCLK_PERIC, 10, > - CLK_SET_RATE_PARENT, 0), > + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), > GATE(CLK_SCLK_SPDIF, "sclk_spdif", "sclk_spdif_peric", > ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", > If any device driver handles the sclk_ioclk_i2s1_bclk on later, CLK_IGNORE_UNUSED will be ignored. Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics