All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Srinivas Dasari <dasaris@codeaurora.org>, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, jouni@codeaurora.org
Subject: Re: [PATCH v2] ieee80211: Increase the PMK maximum length to 64 bytes
Date: Wed, 7 Feb 2018 20:35:05 +0100	[thread overview]
Message-ID: <5A7B54E9.8070805@broadcom.com> (raw)
In-Reply-To: <1518020451-8743-1-git-send-email-dasaris@codeaurora.org>

On 2/7/2018 5:20 PM, Srinivas Dasari wrote:
> This is needed to cover the case of DPP with the NIST P-521 and
> brainpoolP512r1 curves which derive a PMK that is longer than the
> previously used limit.

So how are driver supposed to deal with this longer PMK. Maybe if you 
could elaborate on what DPP stands for in this context it would become 
more clear. Can we stick with PMK_MAX_LEN or does it need to be more 
fine-grained per use-case? If existing drivers only support 48 bytes PMK 
and trust nl80211 code to check that limit it may screw them up. Not? If 
this is preparation for subsequent patches I would put it all in one 
patch series.

Regards,
Arend

> Signed-off-by: Srinivas Dasari <dasaris@codeaurora.org>
> ---
>   include/linux/ieee80211.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

  reply	other threads:[~2018-02-07 19:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 16:20 [PATCH v2] ieee80211: Increase the PMK maximum length to 64 bytes Srinivas Dasari
2018-02-07 19:35 ` Arend van Spriel [this message]
2018-02-07 20:21   ` Johannes Berg
2018-02-10 10:32     ` Jouni Malinen
2018-02-10 20:26       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A7B54E9.8070805@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=dasaris@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=jouni@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.