From: Mike Christie <mchristi@redhat.com>
To: Lee Duncan <lduncan@suse.com>, linux-scsi@vger.kernel.org
Cc: Chris Leech <cleech@redhat.com>, hare@suse.de
Subject: Re: [PATCH] libiscsi: ensure session spin lock usage consistent
Date: Wed, 7 Feb 2018 16:57:34 -0600 [thread overview]
Message-ID: <5A7B845E.2050003@redhat.com> (raw)
In-Reply-To: <20180205191323.5274-1-lduncan@suse.com>
On 02/05/2018 01:13 PM, Lee Duncan wrote:
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 82c3fd4bc938..055357b2fe9e 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1248,9 +1248,9 @@ int iscsi_complete_pdu(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
> {
> int rc;
>
> - spin_lock(&conn->session->lock);
> + spin_lock_bh(&conn->session->lock);
> rc = __iscsi_complete_pdu(conn, hdr, data, datalen);
> - spin_unlock(&conn->session->lock);
> + spin_unlock_bh(&conn->session->lock);
> return rc;
This one is actually needed because qla4xxx_task_work calls it from
process context.
next prev parent reply other threads:[~2018-02-07 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 19:13 [PATCH] libiscsi: ensure session spin lock usage consistent Lee Duncan
2018-02-07 22:41 ` Mike Christie
2018-02-07 23:42 ` Mike Christie
2018-02-07 22:57 ` Mike Christie [this message]
2018-02-08 4:36 ` Chris Leech
2018-02-08 5:17 ` Chris Leech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A7B845E.2050003@redhat.com \
--to=mchristi@redhat.com \
--cc=cleech@redhat.com \
--cc=hare@suse.de \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.