All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Andrzej Hajda <a.hajda@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	"moderated list:SAMSUNG SOC CLOCK DRIVERS"
	<linux-samsung-soc@vger.kernel.org>,
	"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 2/7] clk: samsung: exynos5250: fix PLL rates
Date: Wed, 14 Feb 2018 14:07:25 +0900	[thread overview]
Message-ID: <5A83C40D.1030904@samsung.com> (raw)
In-Reply-To: <20180213134032.30235-3-a.hajda@samsung.com>

Hi Andrzej,

On 2018년 02월 13일 22:40, Andrzej Hajda wrote:
> Declared rates did not match rates generated by PLL.
> As a result driver behaved inconsitently.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/clk/samsung/clk-exynos5250.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c
> index 9b073c98a891..923c608b1b95 100644
> --- a/drivers/clk/samsung/clk-exynos5250.c
> +++ b/drivers/clk/samsung/clk-exynos5250.c
> @@ -711,13 +711,13 @@ static const struct samsung_pll_rate_table epll_24mhz_tbl[] __initconst = {
>  	/* sorted in descending order */
>  	/* PLL_36XX_RATE(rate, m, p, s, k) */
>  	PLL_36XX_RATE(192000000, 64, 2, 2, 0),
> -	PLL_36XX_RATE(180633600, 90, 3, 2, 20762),
> +	PLL_36XX_RATE(180633605, 90, 3, 2, 20762),
>  	PLL_36XX_RATE(180000000, 90, 3, 2, 0),
>  	PLL_36XX_RATE(73728000, 98, 2, 4, 19923),
> -	PLL_36XX_RATE(67737600, 90, 2, 4, 20762),
> +	PLL_36XX_RATE(67737602, 90, 2, 4, 20762),
>  	PLL_36XX_RATE(49152000, 98, 3, 4, 19923),
> -	PLL_36XX_RATE(45158400, 90, 3, 4, 20762),
> -	PLL_36XX_RATE(32768000, 131, 3, 5, 4719),
> +	PLL_36XX_RATE(45158401, 90, 3, 4, 20762),
> +	PLL_36XX_RATE(32768001, 131, 3, 5, 4719),
>  	{ },
>  };
>  
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

  reply	other threads:[~2018-02-14  5:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180213134056eucas1p270dae5e31eeb96f5c317fe512d761ddd@eucas1p2.samsung.com>
2018-02-13 13:40 ` [PATCH 0/7] clk: samsung: fix PLL rates Andrzej Hajda
2018-02-13 13:40   ` Andrzej Hajda
2018-02-13 13:40   ` [PATCH 1/7] clk: samsung: exynos3250: " Andrzej Hajda
2018-02-13 13:40     ` Andrzej Hajda
2018-02-13 14:41     ` Krzysztof Kozlowski
2018-02-16 10:00       ` Sylwester Nawrocki
2018-02-16 10:06         ` Krzysztof Kozlowski
2018-02-14  5:03     ` Chanwoo Choi
2018-02-16 11:58     ` Sylwester Nawrocki
2018-02-16 12:03       ` Sylwester Nawrocki
2018-02-13 13:40   ` [PATCH 2/7] clk: samsung: exynos5250: " Andrzej Hajda
2018-02-13 13:40     ` Andrzej Hajda
2018-02-14  5:07     ` Chanwoo Choi [this message]
2018-02-13 13:40   ` [PATCH 3/7] clk: samsung: exynos5260: " Andrzej Hajda
2018-02-13 13:40     ` Andrzej Hajda
2018-02-13 13:40   ` [PATCH 4/7] clk: samsung: exynos5433: " Andrzej Hajda
2018-02-13 13:40     ` Andrzej Hajda
2018-02-14  5:45     ` Chanwoo Choi
2018-02-14  8:36       ` Andrzej Hajda
2018-02-15 14:23       ` Sylwester Nawrocki
2018-02-13 13:40   ` [PATCH 5/7] clk: samsung: exynos7: " Andrzej Hajda
2018-02-13 13:40     ` Andrzej Hajda
2018-02-13 13:40   ` [PATCH 6/7] clk: samsung: s3c2410: " Andrzej Hajda
2018-02-13 13:40     ` Andrzej Hajda
2018-02-13 13:40   ` [PATCH 7/7] clk: samsung: add compile time PLL rate validators Andrzej Hajda
2018-02-13 13:40     ` Andrzej Hajda
2018-02-13 14:25     ` Krzysztof Kozlowski
2018-02-14  7:53       ` [PATCH v2 " Andrzej Hajda
2018-02-14  7:53         ` Andrzej Hajda
2018-02-15  7:55   ` [PATCH 0/7] clk: samsung: fix PLL rates Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A83C40D.1030904@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.