Re: [PATCH] cfg80211/nl80211: add DFS offload flag

[Arend van Spriel <arend.vanspriel@broadcom.com>]

On 2/21/2018 11:56 AM, Sergey Matyukevich wrote:
> From: Dmitry Lebed <dlebed@quantenna.com>
>
> Add wiphy flag to indicate that HW does all DFS actions by itself.
> User-space functionality already implemented in hostapd using
> vendor-specific (QCA) OUI to advertise HW support.
> Need to introduce generic flag to inform about DFS offload support.
> For deivces with DFS_OFFLOAD flag set user-space will no longer
> need to issue CAC or do any actions in response to
> "radar detected" events. HW will do everything by itself and send
> events to user-space to idicate that CAC was started/finished, etc.
>
> Signed-off-by: Dmitrii Lebed <dlebed@quantenna.com>
> ---
>   include/net/cfg80211.h       | 7 ++++++-
>   include/uapi/linux/nl80211.h | 9 +++++++++
>   net/wireless/nl80211.c       | 7 +++++++
>   3 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index ed3a28105d6c..b2d17993ae4d 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -3241,6 +3241,11 @@ struct cfg80211_ops {
>    * @WIPHY_FLAG_IBSS_RSN: The device supports IBSS RSN.
>    * @WIPHY_FLAG_MESH_AUTH: The device supports mesh authentication by routing
>    *	auth frames to userspace. See @NL80211_MESH_SETUP_USERSPACE_AUTH.
> + * @WIPHY_FLAG_DFS_OFFLOAD: Device will do all DFS-related actions by itself,
> + *	informing user-space about CAC progress, radar detection event,
> + *	channel change triggered by radar detection event.
> + *	No need to start CAC from user-space, no need to react to
> + *	"radar detected" event.

wiphy flags are kinda deprecated. At least no new flags should be added. 
Instead use EXT_FEATURE flag.

Regards,
Arend

>    * @WIPHY_FLAG_SUPPORTS_FW_ROAM: The device supports roaming feature in the
>    *	firmware.
>    * @WIPHY_FLAG_AP_UAPSD: The device supports uapsd on AP.