From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 1/3] extcon: gpio: Localize platform data Date: Fri, 02 Mar 2018 08:32:39 +0900 Message-ID: <5A988D97.9080805@samsung.com> References: <20180212085314.23014-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij , MyungJoo Ham Cc: "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Guenter Roeck List-Id: linux-gpio@vger.kernel.org Hi, On 2018년 03월 01일 18:14, Linus Walleij wrote: > On Mon, Feb 12, 2018 at 9:53 AM, Linus Walleij wrote: > >> Nothing in the entire kernel #includes >> so move the platform data declaration inside of the driver. >> >> Signed-off-by: Linus Walleij > > No reply on these patches so far, > if you prefer I can just apply them to the GPIO > tree. I'm sorry for late reply. The extcon-gpio.c should be solved how to to get the unique id such as EXTCON_USB, EXTCON_DISP_HDMI and so on. As you knew, you already tried to develop it with device-tree. But, it is not accepted. Even if extcon-gpio.c has a problem still to get the extcon id, I'll apply this series. Because I don't want to remove extcon-gpio.c and you need to clean-up the gpio library. On later, I'll try to fix this issue. I added the 'FIXME' comment which explains the extcon_id issue and then applied this series. -- Best Regards, Chanwoo Choi Samsung Electronics