From mboxrd@z Thu Jan 1 00:00:00 1970 From: JeffyChen Subject: Re: [PATCH v9 5/5] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach Date: Mon, 05 Mar 2018 15:01:24 +0800 Message-ID: <5A9CEB44.40207@rock-chips.com> References: <20180302175757.28192-1-enric.balletbo@collabora.com> <20180302175757.28192-6-enric.balletbo@collabora.com> <2714218.VptbnhJPkd@avalon> <5A99EA37.6070006@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5A99EA37.6070006@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , Enric Balletbo i Serra Cc: Jose Abreu , Jernej Skrabec , linux-rockchip@lists.infradead.org, David Airlie , Daniel Vetter , Neil Armstrong , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hans Verkuil , Russell King , kernel@collabora.com, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgTGF1cmVudCwKCnNvcnJ5LCB5b3UncmUgcmlnaHQsIHRoaXMgcGF0Y2ggc2hvdWxkIG5vdCBi ZSBuZWVkZWQuCgp0aGUgY29ubmVjdG9yIHNob3VsZCBiZSBjbGVhbnVwIGJ5IApkcm1fbW9kZV9j b25maWdfY2xlYW51cC0+ZHJtX2Nvbm5lY3Rvcl9wdXQuCgppIGRpZCB0aGF0IGluIGFuYWxvZ2l4 X2RwIGlzIHRvIGF2b2lkIGEgdXNlLWFmdGVyLWZyZWUgaXNzdWUgbm90IAprbWVtbGVhaywgYmVj YXVzZSB0aGUgY29ubmVjdG9yIHdhcyBhbGxvY2F0ZWQvZnJlZWQgaW4gYW5hbG9naXhfZHAncyAK YmluZC91bmJpbmQuCgpidXQgaSBmb3VuZCBhIGttZW1sZWFrIGlzc3VlKGRtYV9tYXNrIG5vdCBm cmVlZCkgaW4gZHctaGRtaSB3aGVuIHRlc3RpbmcgCnRoYXQsIHdpbGwgc2VuZCBwYXRjaCBzb29u LgoKT24gMDMvMDMvMjAxOCAwODoyMCBBTSwgSmVmZnlDaGVuIHdyb3RlOgo+IEhpIExhdXJlbnQs Cj4KPiBPbiAwMy8wMy8yMDE4IDA1OjQ5IEFNLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+PiBI aSBFbnJpYywKPj4KPj4gVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCj4+Cj4+IE9uIEZyaWRheSwg MiBNYXJjaCAyMDE4IDE5OjU3OjU3IEVFVCBFbnJpYyBCYWxsZXRibyBpIFNlcnJhIHdyb3RlOgo+ Pj4gRnJvbTogSmVmZnkgQ2hlbiA8amVmZnkuY2hlbkByb2NrLWNoaXBzLmNvbT4KPj4+Cj4+PiBX ZSBpbml0ZWQgY29ubmVjdG9yIGluIGF0dGFjaCgpLCBzbyBuZWVkIGEgZGV0YWNoKCkgdG8gY2xl YW51cC4KPj4KPj4gRG8gd2UgPyBUaGUgZHctaGRtaSBkcml2ZXIgYWxyZWFkeSBzZXRzIGRybV9j b25uZWN0b3JfY2xlYW51cCgpIGFzIHRoZQo+PiBjb25uZWN0b3IgLmRlc3Ryb3koKSBoYW5kbGVy LCBhbmQgdGhlIC5kZXN0cm95KCkgb3BlcmF0aW9uIGlzIGNhbGxlZAo+PiBieSB0aGUKPj4gRFJN IGNvcmUuIE5vbmUgb2YgdGhlIG90aGVyIGJyaWRnZSBkcml2ZXJzIGNhbGwgZHJtX2Nvbm5lY3Rv cl9jbGVhbnVwKCkKPj4gZGlyZWN0bHkuCj4KPiBobW1tLCBjaGVja2luZyB0aGUgY29kZSwgdGhl cmUgYXJlIGFsc28gbG90cyBvZiBkcml2ZXJzIGRvIHRoZQo+IGNsZWFudXAoZHJtX2Nvbm5lY3Rv cl9jbGVhbnVwIG9yIGZ1bmNzLT5kZXN0cm95KToKPiBkcm0jIGdyZXAgLXIgImNvbm5lY3Rvci4q ZnVuY3MtPmRlc3Ryb3kiIC4KPiAuL3JvY2tjaGlwL2lubm9faGRtaS5jOiBoZG1pLT5jb25uZWN0 b3IuZnVuY3MtPmRlc3Ryb3koJmhkbWktPmNvbm5lY3Rvcik7Cj4gLi9yb2NrY2hpcC9jZG4tZHAt Y29yZS5jOiAgICAgICBjb25uZWN0b3ItPmZ1bmNzLT5kZXN0cm95KGNvbm5lY3Rvcik7Cj4gLi9i cmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5jOgo+IGRwLT5jb25uZWN0b3IuZnVuY3Mt PmRlc3Ryb3koJmRwLT5jb25uZWN0b3IpOwo+IC4vbXNtL2hkbWkvaGRtaS5jOiBoZG1pLT5jb25u ZWN0b3ItPmZ1bmNzLT5kZXN0cm95KGhkbWktPmNvbm5lY3Rvcik7Cj4gLi9tc20vZHNpL2RzaS5j OiBtc21fZHNpLT5jb25uZWN0b3ItPmZ1bmNzLT5kZXN0cm95KG1zbV9kc2ktPmNvbm5lY3Rvcik7 Cj4gLi9tc20vZWRwL2VkcC5jOiBlZHAtPmNvbm5lY3Rvci0+ZnVuY3MtPmRlc3Ryb3koZWRwLT5j b25uZWN0b3IpOwo+IC4venRlL3p4X2hkbWkuYzogICAgICAgIGhkbWktPmNvbm5lY3Rvci5mdW5j cy0+ZGVzdHJveSgmaGRtaS0+Y29ubmVjdG9yKTsKPiAuL2RybV9jb25uZWN0b3IuYzogICAgICBj b25uZWN0b3ItPmZ1bmNzLT5kZXN0cm95KGNvbm5lY3Rvcik7Cj4gLi9kcm1fY29ubmVjdG9yLmM6 ICAgICAgICAgICAgICBjb25uZWN0b3ItPmZ1bmNzLT5kZXN0cm95KGNvbm5lY3Rvcik7Cj4gLi9u b3V2ZWF1L2Rpc3BudjA0L2Rpc3AuYzogY29ubmVjdG9yLT5mdW5jcy0+ZGVzdHJveShjb25uZWN0 b3IpOwo+IC4vbm91dmVhdS9udjUwX2Rpc3BsYXkuYzogbXN0Yy0+Y29ubmVjdG9yLmZ1bmNzLT5k ZXN0cm95KCZtc3RjLT5jb25uZWN0b3IpOwo+IC4vbm91dmVhdS9udjUwX2Rpc3BsYXkuYzogY29u bmVjdG9yLT5mdW5jcy0+ZGVzdHJveShjb25uZWN0b3IpOwo+Cj4KPgo+IHdoZW4gaSBkZWJ1ZyBh bmFsb2dpeF9kcCBiaW5kL3VuYmluZCwgaSBmb3VuZCB0aGF0IHdlIG5lZWQgdG8gY2xlYW51cAo+ IHRoZSBjb25uZWN0b3IocmVwb3J0ZWQgYnkga21lbWxlYWspLiBzbyBpIGFkZGVkIGl0IHRvCj4g Li9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfY29yZS5jLi4uYWZ0ZXIgdGhhdCBpIHNhdyBk dy1oZG1pIG1pc3NpbmcKPiB0aGF0IHRvbyhieSBjaGVja2luZyB0aGUgY29kZSksIHNvIG1ha2Ug dGhpcyBwYXRjaC4KPgo+IGJ1dCBpIGRpZG4ndCByZWFsbHkgdGVzdGVkIGl0IG9uIGRldmljZXMg dXNpbmcgZHctaGRtaSwgc28gaSdtIG5vdCB2ZXJ5Cj4gc3VyZSB0aGUgZHctaGRtaShtYXliZSBh bHNvIG90aGVyIGJyaWRnZXMpIGlzIHRoZSBzYW1lIHdpdGggYW5hbG9naXhfZHAuCj4KPiBpIGNh biB0cnkgdG8gZmluZCBhIGNocm9tZWJvb2sgdmV5cm9uIHRvIGNoZWNrIGl0IG5leHQgd2VlayA6 KQo+Cj4gYnV0IGV2ZW4gdGhlcmUncyBhIGxlYWssIGknbSBzdGlsbCBub3QgdmVyeSBzdXJlIGFi b3V0Ogo+IHNob3VsZCB0aGUgY2FsbGVyIG9mIGRybV9jb25uZWN0b3JfaW5pdCBjbGVhbnVwIGl0 Cj4gb3IgdGhlIGNhbGxlciBvZiBkcm1fYnJpZGdlX2F0dGFjaCBzaG91bGQgZG8gaXQoZm9yIGV4 YW1wbGUKPiBhbmFsb2dpeF9kcF9iaW5kL2FuYWxvZ2l4X2RwX3VuYmluZCkKPiBvciBzaG91bGQg dGhlIERSTSBjb3JlIHRha2UgY2FyZSBvZiB0aGF0Pwo+Cj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBK ZWZmeSBDaGVuIDxqZWZmeS5jaGVuQHJvY2stY2hpcHMuY29tPgo+Pj4gU2lnbmVkLW9mZi1ieTog VGhpZXJyeSBFc2NhbmRlIDx0aGllcnJ5LmVzY2FuZGVAY29sbGFib3JhLmNvbT4KPj4+IFNpZ25l ZC1vZmYtYnk6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPGVucmljLmJhbGxldGJvQGNvbGxhYm9y YS5jb20+Cj4+PiAtLS0KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (JeffyChen) Date: Mon, 05 Mar 2018 15:01:24 +0800 Subject: [PATCH v9 5/5] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach In-Reply-To: <5A99EA37.6070006@rock-chips.com> References: <20180302175757.28192-1-enric.balletbo@collabora.com> <20180302175757.28192-6-enric.balletbo@collabora.com> <2714218.VptbnhJPkd@avalon> <5A99EA37.6070006@rock-chips.com> Message-ID: <5A9CEB44.40207@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Laurent, sorry, you're right, this patch should not be needed. the connector should be cleanup by drm_mode_config_cleanup->drm_connector_put. i did that in analogix_dp is to avoid a use-after-free issue not kmemleak, because the connector was allocated/freed in analogix_dp's bind/unbind. but i found a kmemleak issue(dma_mask not freed) in dw-hdmi when testing that, will send patch soon. On 03/03/2018 08:20 AM, JeffyChen wrote: > Hi Laurent, > > On 03/03/2018 05:49 AM, Laurent Pinchart wrote: >> Hi Enric, >> >> Thank you for the patch. >> >> On Friday, 2 March 2018 19:57:57 EET Enric Balletbo i Serra wrote: >>> From: Jeffy Chen >>> >>> We inited connector in attach(), so need a detach() to cleanup. >> >> Do we ? The dw-hdmi driver already sets drm_connector_cleanup() as the >> connector .destroy() handler, and the .destroy() operation is called >> by the >> DRM core. None of the other bridge drivers call drm_connector_cleanup() >> directly. > > hmmm, checking the code, there are also lots of drivers do the > cleanup(drm_connector_cleanup or funcs->destroy): > drm# grep -r "connector.*funcs->destroy" . > ./rockchip/inno_hdmi.c: hdmi->connector.funcs->destroy(&hdmi->connector); > ./rockchip/cdn-dp-core.c: connector->funcs->destroy(connector); > ./bridge/analogix/analogix_dp_core.c: > dp->connector.funcs->destroy(&dp->connector); > ./msm/hdmi/hdmi.c: hdmi->connector->funcs->destroy(hdmi->connector); > ./msm/dsi/dsi.c: msm_dsi->connector->funcs->destroy(msm_dsi->connector); > ./msm/edp/edp.c: edp->connector->funcs->destroy(edp->connector); > ./zte/zx_hdmi.c: hdmi->connector.funcs->destroy(&hdmi->connector); > ./drm_connector.c: connector->funcs->destroy(connector); > ./drm_connector.c: connector->funcs->destroy(connector); > ./nouveau/dispnv04/disp.c: connector->funcs->destroy(connector); > ./nouveau/nv50_display.c: mstc->connector.funcs->destroy(&mstc->connector); > ./nouveau/nv50_display.c: connector->funcs->destroy(connector); > > > > when i debug analogix_dp bind/unbind, i found that we need to cleanup > the connector(reported by kmemleak). so i added it to > ./bridge/analogix/analogix_dp_core.c...after that i saw dw-hdmi missing > that too(by checking the code), so make this patch. > > but i didn't really tested it on devices using dw-hdmi, so i'm not very > sure the dw-hdmi(maybe also other bridges) is the same with analogix_dp. > > i can try to find a chromebook veyron to check it next week :) > > but even there's a leak, i'm still not very sure about: > should the caller of drm_connector_init cleanup it > or the caller of drm_bridge_attach should do it(for example > analogix_dp_bind/analogix_dp_unbind) > or should the DRM core take care of that? > >> >>> Signed-off-by: Jeffy Chen >>> Signed-off-by: Thierry Escande >>> Signed-off-by: Enric Balletbo i Serra >>> --- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752300AbeCEHB6 (ORCPT ); Mon, 5 Mar 2018 02:01:58 -0500 Received: from regular1.263xmail.com ([211.150.99.136]:37056 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215AbeCEHB4 (ORCPT ); Mon, 5 Mar 2018 02:01:56 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: laurent.pinchart@ideasonboard.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <6b57628ecb5fdce9a9495a477f8849f2> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5A9CEB44.40207@rock-chips.com> Date: Mon, 05 Mar 2018 15:01:24 +0800 From: JeffyChen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130126 Thunderbird/19.0 MIME-Version: 1.0 To: Laurent Pinchart , Enric Balletbo i Serra CC: Sandy Huang , =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= , Andrzej Hajda , linux-rockchip@lists.infradead.org, Archit Taneja , linux-kernel@vger.kernel.org, Russell King , Neil Armstrong , dri-devel@lists.freedesktop.org, Jose Abreu , Hans Verkuil , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, David Airlie , kernel@collabora.com, Daniel Vetter , Sean Paul Subject: Re: [PATCH v9 5/5] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach References: <20180302175757.28192-1-enric.balletbo@collabora.com> <20180302175757.28192-6-enric.balletbo@collabora.com> <2714218.VptbnhJPkd@avalon> <5A99EA37.6070006@rock-chips.com> In-Reply-To: <5A99EA37.6070006@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, sorry, you're right, this patch should not be needed. the connector should be cleanup by drm_mode_config_cleanup->drm_connector_put. i did that in analogix_dp is to avoid a use-after-free issue not kmemleak, because the connector was allocated/freed in analogix_dp's bind/unbind. but i found a kmemleak issue(dma_mask not freed) in dw-hdmi when testing that, will send patch soon. On 03/03/2018 08:20 AM, JeffyChen wrote: > Hi Laurent, > > On 03/03/2018 05:49 AM, Laurent Pinchart wrote: >> Hi Enric, >> >> Thank you for the patch. >> >> On Friday, 2 March 2018 19:57:57 EET Enric Balletbo i Serra wrote: >>> From: Jeffy Chen >>> >>> We inited connector in attach(), so need a detach() to cleanup. >> >> Do we ? The dw-hdmi driver already sets drm_connector_cleanup() as the >> connector .destroy() handler, and the .destroy() operation is called >> by the >> DRM core. None of the other bridge drivers call drm_connector_cleanup() >> directly. > > hmmm, checking the code, there are also lots of drivers do the > cleanup(drm_connector_cleanup or funcs->destroy): > drm# grep -r "connector.*funcs->destroy" . > ./rockchip/inno_hdmi.c: hdmi->connector.funcs->destroy(&hdmi->connector); > ./rockchip/cdn-dp-core.c: connector->funcs->destroy(connector); > ./bridge/analogix/analogix_dp_core.c: > dp->connector.funcs->destroy(&dp->connector); > ./msm/hdmi/hdmi.c: hdmi->connector->funcs->destroy(hdmi->connector); > ./msm/dsi/dsi.c: msm_dsi->connector->funcs->destroy(msm_dsi->connector); > ./msm/edp/edp.c: edp->connector->funcs->destroy(edp->connector); > ./zte/zx_hdmi.c: hdmi->connector.funcs->destroy(&hdmi->connector); > ./drm_connector.c: connector->funcs->destroy(connector); > ./drm_connector.c: connector->funcs->destroy(connector); > ./nouveau/dispnv04/disp.c: connector->funcs->destroy(connector); > ./nouveau/nv50_display.c: mstc->connector.funcs->destroy(&mstc->connector); > ./nouveau/nv50_display.c: connector->funcs->destroy(connector); > > > > when i debug analogix_dp bind/unbind, i found that we need to cleanup > the connector(reported by kmemleak). so i added it to > ./bridge/analogix/analogix_dp_core.c...after that i saw dw-hdmi missing > that too(by checking the code), so make this patch. > > but i didn't really tested it on devices using dw-hdmi, so i'm not very > sure the dw-hdmi(maybe also other bridges) is the same with analogix_dp. > > i can try to find a chromebook veyron to check it next week :) > > but even there's a leak, i'm still not very sure about: > should the caller of drm_connector_init cleanup it > or the caller of drm_bridge_attach should do it(for example > analogix_dp_bind/analogix_dp_unbind) > or should the DRM core take care of that? > >> >>> Signed-off-by: Jeffy Chen >>> Signed-off-by: Thierry Escande >>> Signed-off-by: Enric Balletbo i Serra >>> ---