All of lore.kernel.org
 help / color / mirror / Atom feed
From: JeffyChen <jeffy.chen@rock-chips.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee.jones@linaro.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config
Date: Tue, 06 Mar 2018 22:58:26 +0800	[thread overview]
Message-ID: <5A9EAC92.4050702@rock-chips.com> (raw)
In-Reply-To: <20180306110403.14438-1-jeffy.chen@rock-chips.com>

+CC Mark.

even this is already fixed by a430ab205d29 ("regmap: debugfs: 
Disambiguate dummy debugfs file name")

but maybe we can still have this for a better debugfs name?

On 03/06/2018 07:04 PM, Jeffy Chen wrote:
> We are now allowing to register debugfs for syscon regmap, and not
> having a valid name will end up using "dummy" to create debugfs dir.
>
> Fixes: 9b947a13e7f6 ("regmap: use debugfs even when no device")
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
>   drivers/mfd/syscon.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 7eaa40bc703f..250d22f40c84 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -109,6 +109,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
>   	syscon_config.reg_stride = reg_io_width;
>   	syscon_config.val_bits = reg_io_width * 8;
>   	syscon_config.max_register = resource_size(&res) - reg_io_width;
> +	syscon_config.name = of_node_full_name(np);
>
>   	regmap = regmap_init_mmio(NULL, base, &syscon_config);
>   	if (IS_ERR(regmap)) {
>

  parent reply	other threads:[~2018-03-06 14:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 11:04 [PATCH v2 1/3] mfd: syscon: Set name of regmap_config Jeffy Chen
2018-03-06 11:04 ` [PATCH v2 2/3] regmap: debugfs: Fix kmemleak in regmap_debugfs_init Jeffy Chen
2018-03-06 12:59   ` Mark Brown
2018-03-07 10:56     ` JeffyChen
2018-03-06 11:04 ` [PATCH v2 3/3] regmap: debugfs: Free map->debugfs_name when debugfs_create_dir() failed Jeffy Chen
2018-03-07 14:15   ` Applied "regmap: debugfs: Free map->debugfs_name when debugfs_create_dir() failed" to the regmap tree Mark Brown
2018-03-06 14:58 ` JeffyChen [this message]
2018-03-07 10:20   ` [PATCH v2 1/3] mfd: syscon: Set name of regmap_config Mark Brown
2018-03-07 10:50     ` JeffyChen
2018-03-07 10:57       ` Mark Brown
2018-03-07 16:54         ` Lee Jones
2018-03-07 16:57           ` Mark Brown
2018-03-12 14:07             ` Lee Jones
2018-03-12 16:11               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A9EAC92.4050702@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.