From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node Date: Thu, 08 Mar 2018 15:50:33 +0900 Message-ID: <5AA0DD39.3040108@samsung.com> References: <20180307171111.14551-1-s.nawrocki@samsung.com> <5AA0B59F.3070402@samsung.com> <3c68c3da-a0c3-4e4e-da6b-3e4b1af6d19d@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <3c68c3da-a0c3-4e4e-da6b-3e4b1af6d19d@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Marek Szyprowski , Sylwester Nawrocki Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org SGkgTWFyZWssCgoyMDE464WEIDAz7JuUIDA47J28IDE1OjI57JeQIE1hcmVrIFN6eXByb3dza2kg 7J20KOqwgCkg7JO0IOq4gDoKPiBIaSBJbmtpLAo+IAo+IE9uIDIwMTgtMDMtMDggMDU6MDEsIElu a2kgRGFlIHdyb3RlOgo+PiBIaSBTeWx3ZXN0ZXIsCj4+Cj4+IDIwMTjrhYQgMDPsm5QgMDjsnbwg MDI6MTHsl5AgU3lsd2VzdGVyIE5hd3JvY2tpIOydtCjqsIApIOyTtCDquIA6Cj4+PiBUaGUgI3Nv dW5kLWRhaS1jZWxscyBEVCBwcm9wZXJ0eSBpcyByZXF1aXJlZCB0byBkZXNjcmliZSBsaW5rIGJl dHdlZW4KPj4+IHRoZSBIRE1JIElQIGJsb2NrIGFuZCB0aGUgU29DJ3MgYXVkaW8gc3Vic3lzdGVt Lgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFN5bHdlc3RlciBOYXdyb2NraSA8cy5uYXdyb2NraUBz YW1zdW5nLmNvbT4KPj4+IC0tLQo+Pj4gICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9leHlub3MvZXh5bm9zX2hkbWkudHh0IHwgMyArKysKPj4+ICAgMSBmaWxlIGNo YW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9leHlub3MvZXh5bm9zX2hkbWkudHh0IGIvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvZXh5bm9zL2V4eW5vc19oZG1p LnR4dAo+Pj4gaW5kZXggODcxNWZmMDZjNDU3Li42YjJhNTI2ZWM1ODYgMTAwNjQ0Cj4+PiAtLS0g YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9leHlub3MvZXh5bm9z X2hkbWkudHh0Cj4+PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlz cGxheS9leHlub3MvZXh5bm9zX2hkbWkudHh0Cj4+PiBAQCAtNTAsNiArNTAsOSBAQCBSZXF1aXJl ZCBwcm9wZXJ0aWVzIGZvciBFeHlub3MgNTQzMzoKPj4+ICAgLSBjbG9jay1uYW1lczogYWxpYXNl cyBmb3IgYWJvdmUgY2xvY2sgc3BlY2ZpZXJzLgo+Pj4gICAtIHNhbXN1bmcsc3lzcmVnOiBoYW5k bGUgdG8gc3lzY29uIHVzZWQgdG8gY29udHJvbCB0aGUgc3lzdGVtIHJlZ2lzdGVycy4KPj4+ICAg K09wdGlvbmFsIHByb3BlcnRpZXMgZm9yIEV4eW5vcyA0MjEwLCA0MjEyLCA1NDIwIGFuZCA1NDMz Ogo+Pj4gKyAtICNzb3VuZC1kYWktY2VsbHM6IHNob3VsZCBiZSAwLgo+Pj4gKwo+PiBKdXN0IHRy aXZpYWwgcXVlc3Rpb24uICdzb3VuZC1kYWktY2VsbHMnIHByb3BlcnR5IGNvdWxkIGFmZmVjdCBo ZG1pIGRyaXZlcj8gSSBsb29rZWQgaW50byBIRE1JIGNvZGVjIGRyaXZlciBidXQgSSBkaWRuJ3Qg ZmluZCByZWxldmF0IGNvZGUuCj4+IEkgbWVhbiB0aGF0IGlmIHRoaXMgcHJvcGVydHkgbmV2ZXIg YWZmZWN0IEhETUkgZHJpdmVyIHRoZW4gdGhpcyBwcm9wZXJ0eSB3b3VsZCBiZSBhIGRlYWQgdGhp bmcgZXZlbiB0aHJvdWdoIHRoaXMgY2FuIGJlIGRlY2xhcmVkIG9wdGlvbmFsbHkuCj4gCj4gVGhp cyBwcm9wZXJ0eSBpcyB1c2VkIGJ5IEFTb0MgZnJhbWV3b3JrIHdoZW4gaXQgaXMgYnVpbGRpbmcg Y29ubmVjdGlvbnMKPiBiZXR3ZWVuIGFsbCBlbGVtZW50cyBvZiB0aGUgdmlydHVhbCAnc291bmQg Y2FyZCcuIEl0IGFsbG93cyBnZW5lcmljCj4gY29kZSB0byBmaW5kIHByb3BlciBkcml2ZXIgZm9y IHRoZSBkaWdpdGFsIGF1ZGlvIGludGVyZmFjZSAoREFJKSBvYmplY3QuCgpJIGFsc28gYXNzdW1l ZCB0aGF0IHNvbWUgcGxhY2Ugb2YgQVNvQyBmcmFtZXdvcmsgY2hlY2tzIHRoaXMgcHJvcGVydHku IEZvciB0aGlzIEkgbG9va2VkIGludG8gSERNSSBjb2RlYyBkcml2ZXIoc291bmQvc29jL2NvZGVj cy9oZG1pLWNvZGVjLmMpIGFuZCByZWxldmFudCBpbnRlcmZhY2VzIG9mIEFTb0MgZnJhbWV3b3Jr LgpCdXQgSSBjb3VsZG4ndCBmaW5kIGl0LiA6KCBDb3VsZCB5b3UgbGV0IG1lIGtub3cgd2hpY2gg Y29kZSBvZiBBU29DIGZyYW1ld29yayBjaGVja3MgdGhpcz8gSSBzYXcgdGhpcyBwcm9wZXJ0eSBv bmx5IGluICdzbmRfc29jX29mX2dldF9kYWlfbmFtZScgYW5kICdzbmRfc29jX29mX2dldF9kYWlf bGlua19jb2RlY3MnIGZ1bmN0aW9ucyBidXQgc2VlbXMgdGhlc2UgZnVuY3Rpb25zIGFyZW4ndCBj YWxsZWQgYnkgdGhlIEhETUkgY29kZWMgZHJpdmVyLgoKVGhhbmtzLApJbmtpIERhZQoKPiAKPiBC ZXN0IHJlZ2FyZHMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Thu, 08 Mar 2018 15:50:33 +0900 Subject: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node In-Reply-To: <3c68c3da-a0c3-4e4e-da6b-3e4b1af6d19d@samsung.com> References: <20180307171111.14551-1-s.nawrocki@samsung.com> <5AA0B59F.3070402@samsung.com> <3c68c3da-a0c3-4e4e-da6b-3e4b1af6d19d@samsung.com> Message-ID: <5AA0DD39.3040108@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Marek, 2018? 03? 08? 15:29? Marek Szyprowski ?(?) ? ?: > Hi Inki, > > On 2018-03-08 05:01, Inki Dae wrote: >> Hi Sylwester, >> >> 2018? 03? 08? 02:11? Sylwester Nawrocki ?(?) ? ?: >>> The #sound-dai-cells DT property is required to describe link between >>> the HDMI IP block and the SoC's audio subsystem. >>> >>> Signed-off-by: Sylwester Nawrocki >>> --- >>> Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt b/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt >>> index 8715ff06c457..6b2a526ec586 100644 >>> --- a/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt >>> +++ b/Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt >>> @@ -50,6 +50,9 @@ Required properties for Exynos 5433: >>> - clock-names: aliases for above clock specfiers. >>> - samsung,sysreg: handle to syscon used to control the system registers. >>> +Optional properties for Exynos 4210, 4212, 5420 and 5433: >>> + - #sound-dai-cells: should be 0. >>> + >> Just trivial question. 'sound-dai-cells' property could affect hdmi driver? I looked into HDMI codec driver but I didn't find relevat code. >> I mean that if this property never affect HDMI driver then this property would be a dead thing even through this can be declared optionally. > > This property is used by ASoC framework when it is building connections > between all elements of the virtual 'sound card'. It allows generic > code to find proper driver for the digital audio interface (DAI) object. I also assumed that some place of ASoC framework checks this property. For this I looked into HDMI codec driver(sound/soc/codecs/hdmi-codec.c) and relevant interfaces of ASoC framework. But I couldn't find it. :( Could you let me know which code of ASoC framework checks this? I saw this property only in 'snd_soc_of_get_dai_name' and 'snd_soc_of_get_dai_link_codecs' functions but seems these functions aren't called by the HDMI codec driver. Thanks, Inki Dae > > Best regards