From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from regular1.263xmail.com ([211.150.99.132]:60130 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbeCIBvk (ORCPT ); Thu, 8 Mar 2018 20:51:40 -0500 Message-ID: <5AA1E89F.2020500@rock-chips.com> Date: Fri, 09 Mar 2018 09:51:27 +0800 From: JeffyChen MIME-Version: 1.0 To: Alexandre Belloni CC: linux-kernel@vger.kernel.org, broonie@kernel.org, linux-rtc@vger.kernel.org, Alessandro Zummo , Nicolas Ferre , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio() References: <20180308102154.25686-1-jeffy.chen@rock-chips.com> <20180308102154.25686-3-jeffy.chen@rock-chips.com> <20180308204941.GK20370@piout.net> In-Reply-To: <20180308204941.GK20370@piout.net> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-rtc-owner@vger.kernel.org List-ID: Hi Alexandre, On 03/09/2018 04:49 AM, Alexandre Belloni wrote: > On 08/03/2018 at 18:21:52 +0800, Jeffy Chen wrote: >> Otherwise it would use "dummy*" to create regmap debugfs dir. >> >> Signed-off-by: Jeffy Chen >> --- >> >> Changes in v3: None >> >> drivers/rtc/rtc-at91sam9.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c >> index 7418a763ce52..0d6a17a77841 100644 >> --- a/drivers/rtc/rtc-at91sam9.c >> +++ b/drivers/rtc/rtc-at91sam9.c >> @@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev) >> if (IS_ERR(gpbr)) >> return PTR_ERR(gpbr); >> >> - rtc->gpbr = regmap_init_mmio(NULL, gpbr, >> + rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr, >> &gpbr_regmap_config); > > This would be misleading as the gpbr is not directly related to the rtc. ok, will fix that, thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy.chen@rock-chips.com (JeffyChen) Date: Fri, 09 Mar 2018 09:51:27 +0800 Subject: [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio() In-Reply-To: <20180308204941.GK20370@piout.net> References: <20180308102154.25686-1-jeffy.chen@rock-chips.com> <20180308102154.25686-3-jeffy.chen@rock-chips.com> <20180308204941.GK20370@piout.net> Message-ID: <5AA1E89F.2020500@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Alexandre, On 03/09/2018 04:49 AM, Alexandre Belloni wrote: > On 08/03/2018 at 18:21:52 +0800, Jeffy Chen wrote: >> Otherwise it would use "dummy*" to create regmap debugfs dir. >> >> Signed-off-by: Jeffy Chen >> --- >> >> Changes in v3: None >> >> drivers/rtc/rtc-at91sam9.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c >> index 7418a763ce52..0d6a17a77841 100644 >> --- a/drivers/rtc/rtc-at91sam9.c >> +++ b/drivers/rtc/rtc-at91sam9.c >> @@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev) >> if (IS_ERR(gpbr)) >> return PTR_ERR(gpbr); >> >> - rtc->gpbr = regmap_init_mmio(NULL, gpbr, >> + rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr, >> &gpbr_regmap_config); > > This would be misleading as the gpbr is not directly related to the rtc. ok, will fix that, thanks. >