From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node Date: Fri, 09 Mar 2018 11:35:55 +0900 Message-ID: <5AA1F30B.8010607@samsung.com> References: <20180307171111.14551-1-s.nawrocki@samsung.com> <5AA0B59F.3070402@samsung.com> <3c68c3da-a0c3-4e4e-da6b-3e4b1af6d19d@samsung.com> <5AA0DD39.3040108@samsung.com> <9f1e8619-974d-cd07-79c3-c6d9a4dc0f97@samsung.com> <5AA0F10D.9010602@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sylwester Nawrocki Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski List-Id: alsa-devel@alsa-project.org SGkgU3lsd2VzdGVyLAoKMjAxOOuFhCAwM+yblCAwOOydvCAyMDoyMuyXkCBTeWx3ZXN0ZXIgTmF3 cm9ja2kg7J20KOqwgCkg7JO0IOq4gDoKPiBIaSBJbmtpLAo+IAo+IENjOiBhbHNhLWRldmVsQGFs c2EtcHJvamVjdC5vcmcKPiAKPiBPbiAwMy8wOC8yMDE4IDA5OjE1IEFNLCBJbmtpIERhZSB3cm90 ZToKPj4gQnkgdGhlIHdheSwgaXQgc2VlbXMgJ3NvdW5kLWRhaS1jZWxscycgcHJvcGVydHkgbmV2 ZXIgYWZmZWN0IEV4eW5vczQyMTAvNDIxMj4gNTQyMC81NDMzLiBJdCBzZWVtcyB0aGF0IGV2ZW4g dGhyb3VnaCBBTFNBIFRNMiBhdWRpbyBkcml2ZXIodG0yX3dtNTExMC5jKSAKPj4gZXhpc3RzIHRo ZSBkcml2ZXIgbmV2ZXIgY2hlY2sgdGhlIHByb3BlcnR5Lgo+Pgo+PiBIb3dldmVyLCB0aGlzIHBh dGNoIGFkZHMgYmVsb3cgZGVzY3JpcHRpb24uCj4+Cj4+ICJPcHRpb25hbCBwcm9wZXJ0aWVzIGZv ciBFeHlub3MgNDIxMCwgNDIxMiwgNTQyMCBhbmQgNTQzMyIKPj4KPj4gSXMgdGhlcmUgYSBwb3Nz aWJpbGl0eSBmb3Igb3RoZXIgYm9hcmRzIGJhc2VkIG9uIEV4eW5vczQyMTAvNDIxMi81NDIwLzU0 MzMgCj4+IFNvQyB0byB1c2UgdGhpcyBwcm9wZXJ0eSBsYXRlcj8KPiAKPiBBbGwgdGhlc2UgU29D cyBoYXZlIHRoZSBIRE1JIElQIGJsb2NrIHdoaWNoIGhhcyBvbmUgaW5wdXQgREFJLCBjb25uZWN0 ZWQgCj4gaW50ZXJuYWxseSBvdmVyIEkyUyBidXMgd2l0aCB0aGUgSVMyIGNvbnRyb2xsZXIuCj4g Cj4gSSB0aGluayB0aGVyZSBpcyBubyBhZHZhbnRhZ2UgaW4gbGltaXRpbmcgb3Vyc2VsdmVzIG5v dyBvbmx5IHRvIFNvQydzIAo+IGZvciB3aGljaCB3ZSBjdXJyZW50bHkgcmVseSBvbiB0aGF0IERU IHByb3BlcnR5IGluIGN1cnJlbnQga2VybmVsIGNvZGUsIAo+IGp1c3QgdG8gdXBkYXRlIHRoaXMg ZG9jdW1lbnRhdGlvbiBsYXRlciB3aGVuIHdlIGFjdHVhbGx5IHB1dCB0aGUgcHJvcGVydHkgCj4g aW4gZHRzIGZpbGVzLgo+IAo+IEluIGNhc2Ugb2YgZXh5bm9zNTQyMCB3ZSBhbHJlYWR5IHJlcXVp cmUgI3NvdW5kLWRhaS1jZWxscyBmb3IgT2Ryb2lkIGFuZAoKTWF5YmUgZXh5bm9zNTQyMj8gT2Ry b2lkIFhVMy80IHVzZSBFeHlub3M1NDIyLgogCj4gSSBoYXZlIGFsc28gYSBwYXRjaCBmb3IgZXh5 bm9zNTQyMC1wZWFjaC1waXQgYm9hcmQgd2hpY2ggd2lsbCBuZWVkIGl0IGFzIAo+IHdlbGwuCj4g Cj4gQXMgZmFyIGFzIGV4eW5vczQyMTAgYW5kIGV4eW5vczQyMTIgYXJlIGNvbmNlcm5lZCBpdCdz IGEgbWF0dGVyIG9mIGFkZGluZwo+IHN1cHBvcnQgZm9yIE9kcm9pZC1VMywgdGhlbiB3ZSB3aWxs IGFsc28gbmVlZCB0aGlzIHByb3BlcnR5IGJlY2F1c2UKPiB3ZSBhcmUgZ29pbmcgdG8gdXNlICJt dWx0aS1jb2RlYyIgKEhETUkgYW5kIGV4dGVybmFsIEkyUzAgcGlucyBmb3IgQ09ERUMKPiBhcmUg d2lyZWQgaW4gcGFyYWxsZWwpLgo+IAo+IEluIGNhc2Ugb2YgZXh5bm9zNTQzMyBpdCBqdXN0IGhh cHBlbnMgdGhhdCB0aGUgY29kZSBpbiBjdXJyZW50IGRyaXZlciAKPiBkb2Vzbid0IHJlcXVpcmUg I3NvdW5kLWRhaS1jZWxscyBwcm9wZXJ0eSAtIG9uZSBvZiB0aGUgcmVhc29ucyBJIG1hZGUgaXQK PiB0aGlzIHdheSB3YXMgdG8gYXZvaWQgZGVwZW5kZW5jeSBvbiBkdHMsIGJ1dCBpdCBkb2Vzbid0 IGltcGx5IHdlIHNob3VsZCAKPiBkZXNjcmliZSB0aGUgSFcgaW4gRFQgaW5jb21wbGV0ZWx5LiBP bmNlIHRoZSBwcm9wZXJ0eSBpcyBpbiBkdGJzIHdlIGNhbiAKPiB1cGRhdGUgdGhlIGRyaXZlciB0 byB1c2UgbW9yZSBnZW5lcmljIGNvZGUsIGluc3RlYWQgb2Ygb3BlbiBjb2RpbmcgdGhpbmdzLgo+ IAoKR29vZCBpZGVhLgoKPiBBY3R1YWxseSBJIGhhdmUgZm9yZ290dGVuIHRvIGFkZCBhbHNvIGV4 eW5vczUyNTAgdG8gdGhlIGxpc3QuCgpTZWVtcyB0aGF0ICcjc291bmQtZGFpLWNlbGxzJyBpcyBy ZXF1aXJlZCBtYW5kYXRvcmlseSBpbiBjYXNlIG9mIEV4eW5vczU0MjIgYmVjYXVzZSBPZHJvaWQg WFUzLzQgQXVkaW8gZHJpdmVyIGNoZWNrcyB0aGlzIHByb3BlcnR5LCBhbmQgdGhlIGRyaXZlciBy ZXR1cm5zIGVycm9yIGlmIHRoZSBwcm9wZXJ0eSBkb2Vzbid0IGV4aXN0IGluIGl0cyBkZXZpY2Ug dHJlZS4KQW5kIGlmIG90aGVyIFNvQ3MgLSBFeHlub3M0MjEwLzQyMTIvNTI1MC81NDIwLzU0MzMg LSByZXF1aXJlIHRoaXMgcHJvcGVydHkgd2l0aCBhZGRpdGlvbmFsIGRyaXZlciB3b3JrcyBsYXRl ciB0aGVuIHRoaXMgcHJvcGVydHkgd291bGQgYWxzbyBiZSByZXF1aXJlZCBtYW5kYXRvcmlseSBm b3IgdGhlbSBub3Qgb3B0aW9uYWxseS4gSW4gdGhpcyBjYXNlIHdlIG1heSBuZWVkIHRvIG1vZGlm eSB0aGUgZGVzY3JpcHRpb24gYWdhaW4uCgpTbyBteSBvcGluaW9uIGlzIHRvIGFkZCBvbmx5IHRo ZSBkZXNjcmlwdGlvbiByZXF1aXJlZCBtYW5kYXRvcmlseSBpZiBJIHVuZGVyc3Rvb2QgY29ycmVj dGx5LgoKVGhhbmtzLApJbmtpIERhZQoKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Fri, 09 Mar 2018 11:35:55 +0900 Subject: [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node In-Reply-To: References: <20180307171111.14551-1-s.nawrocki@samsung.com> <5AA0B59F.3070402@samsung.com> <3c68c3da-a0c3-4e4e-da6b-3e4b1af6d19d@samsung.com> <5AA0DD39.3040108@samsung.com> <9f1e8619-974d-cd07-79c3-c6d9a4dc0f97@samsung.com> <5AA0F10D.9010602@samsung.com> Message-ID: <5AA1F30B.8010607@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sylwester, 2018? 03? 08? 20:22? Sylwester Nawrocki ?(?) ? ?: > Hi Inki, > > Cc: alsa-devel at alsa-project.org > > On 03/08/2018 09:15 AM, Inki Dae wrote: >> By the way, it seems 'sound-dai-cells' property never affect Exynos4210/4212> 5420/5433. It seems that even through ALSA TM2 audio driver(tm2_wm5110.c) >> exists the driver never check the property. >> >> However, this patch adds below description. >> >> "Optional properties for Exynos 4210, 4212, 5420 and 5433" >> >> Is there a possibility for other boards based on Exynos4210/4212/5420/5433 >> SoC to use this property later? > > All these SoCs have the HDMI IP block which has one input DAI, connected > internally over I2S bus with the IS2 controller. > > I think there is no advantage in limiting ourselves now only to SoC's > for which we currently rely on that DT property in current kernel code, > just to update this documentation later when we actually put the property > in dts files. > > In case of exynos5420 we already require #sound-dai-cells for Odroid and Maybe exynos5422? Odroid XU3/4 use Exynos5422. > I have also a patch for exynos5420-peach-pit board which will need it as > well. > > As far as exynos4210 and exynos4212 are concerned it's a matter of adding > support for Odroid-U3, then we will also need this property because > we are going to use "multi-codec" (HDMI and external I2S0 pins for CODEC > are wired in parallel). > > In case of exynos5433 it just happens that the code in current driver > doesn't require #sound-dai-cells property - one of the reasons I made it > this way was to avoid dependency on dts, but it doesn't imply we should > describe the HW in DT incompletely. Once the property is in dtbs we can > update the driver to use more generic code, instead of open coding things. > Good idea. > Actually I have forgotten to add also exynos5250 to the list. Seems that '#sound-dai-cells' is required mandatorily in case of Exynos5422 because Odroid XU3/4 Audio driver checks this property, and the driver returns error if the property doesn't exist in its device tree. And if other SoCs - Exynos4210/4212/5250/5420/5433 - require this property with additional driver works later then this property would also be required mandatorily for them not optionally. In this case we may need to modify the description again. So my opinion is to add only the description required mandatorily if I understood correctly. Thanks, Inki Dae >