From: arvindY <arvind.yadav.cs@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
linyunsheng@huawei.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: hns: use put_device() if device_register fail
Date: Mon, 12 Mar 2018 21:57:48 +0530 [thread overview]
Message-ID: <5AA6AA84.6040001@gmail.com> (raw)
In-Reply-To: <20180312.104323.14368638452528082.davem@davemloft.net>
On Monday 12 March 2018 08:13 PM, David Miller wrote:
> From: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Date: Fri, 9 Mar 2018 16:11:17 +0530
>
>> if device_register() returned an error! Always use put_device()
>> to give up the reference initialized.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> I do not see anything giving cls_dev an initial non-zero reference
> count before this device_register() call.
Yes, you are correct there is nothing to release (hnae_release).
>
> And I have no idea why you use a "!" when saying 'error' you this
> commit log message.
>
Sorry for that. next time I will take care.
~arvind
next prev parent reply other threads:[~2018-03-12 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 10:41 [PATCH] net: hns: use put_device() if device_register fail Arvind Yadav
2018-03-12 14:43 ` David Miller
2018-03-12 16:27 ` arvindY [this message]
2018-03-12 17:29 ` Richard Weinberger
2018-03-13 2:57 ` arvindY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AA6AA84.6040001@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.