From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: fix firmware request processing if nvram load fails
Date: Tue, 3 Apr 2018 13:16:31 +0200 [thread overview]
Message-ID: <5AC3628F.7080900@broadcom.com> (raw)
In-Reply-To: <87o9j0ip11.fsf@kamboji.qca.qualcomm.com>
On 4/3/2018 12:04 PM, Kalle Valo wrote:
> Arend van Spriel <arend.vanspriel@broadcom.com> writes:
>
>> When nvram loading fails a double free occurred. Fix this and reorg the
>> code a little.
>>
>> Fixes: commit d09ae51a4b67 ("brcmfmac: pass struct in brcmf_fw_get_firmwares()")
>
> This should be:
>
> Fixes: d09ae51a4b67 ("brcmfmac: pass struct in brcmf_fw_get_firmwares()")
>
> I can fix that during commit.
>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> ---
>> Hi Kalle,
>>
>> This fix is for code currently(?) in linux-next in error path caused
>> a double free.
>
> Ok, I'll queue this to wireless-drivers (after I have fast forwarded it)
> for 4.17.
Thanks
Arend
next prev parent reply other threads:[~2018-04-03 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 8:18 [PATCH] brcmfmac: fix firmware request processing if nvram load fails Arend van Spriel
2018-04-03 10:04 ` Kalle Valo
2018-04-03 11:16 ` Arend van Spriel [this message]
2018-04-09 15:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AC3628F.7080900@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.