From: xuyang.jy <xuyang.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] utils/compat_16.mk: Further cleanup of unused sections and variables
Date: Tue, 10 Apr 2018 14:46:50 +0800 [thread overview]
Message-ID: <5ACC5DDA.3010300@cn.fujitsu.com> (raw)
In-Reply-To: <20180410061929.mnazpimind22bjrn@dell5510>
on 2018/4/10 14:19, Petr Vorel write:
> Hi Yang,
>
>> Hi Petr
>> -%_16.o: %.c $(COMPAT_16_H)
>> This make dependency for recompiling _16.o when header changes.
>> $(MAKE_TARGETS_OBJS_WO_COMPAT_16): $(COMPAT_16_H)
>> .INTERMEDIATE: $(MAKE_TARGETS_OBJS_WO_COMPAT_16)
>> This make dependency for recompiling .o when header changes.
>> I think you may miss something.
>> This patch will reappear the problem that has been fixed since commit
>> 631d16671d(syscalls/utils/compat_16.mk: fix build dependencies).
>> If we touch/modify the compat_tst_16.h/compat_16.h file and excute "make"
>> in any of syscalls directories which includes compat_16.mk, nothing will
>> happen.
> Thank you for explaining and sorry for wrong patch.
> Before I touch wrong file, that's why it didn't work the obvious way you described.
>
> I still thing that HAS_COMPAT_16 variable is unused and not needed.
Hi petr
Agreed. The HAS_COMPAT_16 variable is unused .
>
> Kind regards,
> Petr
>
>> Best Regards
>> Yang Xu
>
> .
>
next prev parent reply other threads:[~2018-04-10 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 12:00 [LTP] [PATCH 1/1] utils/compat_16.mk: Further cleanup of unused sections and variables Petr Vorel
2018-04-10 5:35 ` xuyang.jy
2018-04-10 6:19 ` Petr Vorel
2018-04-10 6:46 ` xuyang.jy [this message]
2018-04-10 7:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ACC5DDA.3010300@cn.fujitsu.com \
--to=xuyang.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.