From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Date: Thu, 12 Apr 2018 16:50:14 +0000 Subject: Re: [PATCH] tcmu: fix error resetting qfull_time_out to default Message-Id: <5ACF8E46.5010403@redhat.com> List-Id: References: <20180409114436.21895-1-prasanna.kalever@redhat.com> In-Reply-To: <20180409114436.21895-1-prasanna.kalever@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: target-devel@vger.kernel.org On 04/09/2018 06:44 AM, Prasanna Kumar Kalever wrote: > Problem: > ------- > $ cat /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out > -1 > > $ echo "-1" > /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out > -bash: echo: write error: Invalid argument > > Fix: > --- > This patch will help reset qfull_time_out to its default i.e. qfull_time_out=-1 > > Signed-off-by: Prasanna Kumar Kalever > --- > drivers/target/target_core_user.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c > index 4ad89ea71a70..4f26bdc3d1dc 100644 > --- a/drivers/target/target_core_user.c > +++ b/drivers/target/target_core_user.c > @@ -2121,6 +2121,8 @@ static ssize_t tcmu_qfull_time_out_store(struct config_item *item, > > if (val >= 0) { > udev->qfull_time_out = val * MSEC_PER_SEC; > + } else if (val = -1) { > + udev->qfull_time_out = val; > } else { > printk(KERN_ERR "Invalid qfull timeout value %d\n", val); > return -EINVAL; > Acked-by: Mike Christie