From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>, Jakub Kicinski <kubakici@wp.pl>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mt7601u: run calibration works after finishing scanning
Date: Mon, 16 Apr 2018 20:45:15 +0200 [thread overview]
Message-ID: <5AD4EF3B.30508@broadcom.com> (raw)
In-Reply-To: <20180414105606.GA9245@redhat.com>
On 4/14/2018 12:56 PM, Stanislaw Gruszka wrote:
> On Fri, Apr 13, 2018 at 11:06:13AM -0700, Jakub Kicinski wrote:
>> >On Fri, 13 Apr 2018 16:44:38 +0200, Stanislaw Gruszka wrote:
>>> > >When finishing scanning we switch to operational channel sill with
>>> > >SCANNING flag. This mean that we never perform calibration works after
>>> > >scanning. To fix the problem cancel and queue calibration works on
>>> > >.sw_scan_start() and .sw_scan_complete() routines.
>>> > >
>>> > >Signed-off-by: Stanislaw Gruszka<sgruszka@redhat.com>
>> >
>> >IOW the stack will potentially ask us to return to the original channel
>> >before calling .sw_scan_complete()? Hm. That's unpleasant.
> I think the stack need to assure we start and end scanning on
> operational channel, otherwise we would have possibility to be on
> undefined channel during normal work.
Returning to the operating channels during scanning is mostly important
when connected so you can receive the beacon of your AP and mc/bc
traffic and also to handle regular unicast traffic so you are not
screwing up your TCP window too much for instance.
Regards,
Arend
next prev parent reply other threads:[~2018-04-16 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 14:44 [PATCH 1/2] mt7601u: use EWMA to calculate avg_rssi Stanislaw Gruszka
2018-04-13 14:44 ` [PATCH 2/2] mt7601u: run calibration works after finishing scanning Stanislaw Gruszka
2018-04-13 18:06 ` Jakub Kicinski
2018-04-14 10:56 ` Stanislaw Gruszka
2018-04-16 18:45 ` Arend van Spriel [this message]
2018-04-13 18:06 ` [PATCH 1/2] mt7601u: use EWMA to calculate avg_rssi Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AD4EF3B.30508@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=kubakici@wp.pl \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.