From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-version: 1.0 Content-type: text/plain; charset="UTF-8" Message-id: <5AE12E4A.90907@samsung.com> Date: Thu, 26 Apr 2018 10:41:30 +0900 From: Chanwoo Choi To: Krzysztof Kozlowski , Kukjin Kim , Rob Herring , Mark Rutland , Tejun Heo , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Zhang Rui , Eduardo Valentin , Russell King , Hans de Goede , Linus Walleij , Andi Shyti , Mark Brown , Bartlomiej Zolnierkiewicz , Alan Stern , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Cc: Marek Szyprowski , Arnd Bergmann , Olof Johansson , Jaehoon Chung Subject: Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440 In-reply-to: <20180424203239.21885-7-krzk@kernel.org> References: <20180424203239.21885-1-krzk@kernel.org> <20180424203239.21885-7-krzk@kernel.org> List-ID: Hi Krzysztof, On 2018년 04월 25일 05:32, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- > drivers/thermal/samsung/exynos_tmu.c | 155 +-------------------- > drivers/thermal/samsung/exynos_tmu.h | 1 - > 3 files changed, 4 insertions(+), 166 deletions(-) After applied this patch, I tested the build and found out 'exynos5440' keyword. There is one comment including 'exynos5440' as following: diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index f92f470bce21..cb525228cfe1 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data) * Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly * states that INTCLEAR register has a different placing of bits * responsible for FALL IRQs than INTSTAT register. Exynos5420 - * and Exynos5440 documentation is correct (Exynos4210 doesn't + * documentation is correct (Exynos4210 doesn't * support FALL IRQs at all). */ writel(val_irq, data->base + tmu_intclear); After removing it, looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,06/10] thermal: samsung: Remove support for Exynos5440 From: Chanwoo Choi Message-Id: <5AE12E4A.90907@samsung.com> Date: Thu, 26 Apr 2018 10:41:30 +0900 To: Krzysztof Kozlowski , Kukjin Kim , Rob Herring , Mark Rutland , Tejun Heo , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Zhang Rui , Eduardo Valentin , Russell King , Hans de Goede , Linus Walleij , Andi Shyti , Mark Brown , Bartlomiej Zolnierkiewicz , Alan Stern , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Cc: Marek Szyprowski , Arnd Bergmann , Olof Johansson , Jaehoon Chung List-ID: SGkgS3J6eXN6dG9mLAoKT24gMjAxOOuFhCAwNOyblCAyNeydvCAwNTozMiwgS3J6eXN6dG9mIEtv emxvd3NraSB3cm90ZToKPiBUaGUgRXh5bm9zNTQ0MCBpcyBub3QgYWN0aXZlbHkgZGV2ZWxvcGVk LCB0aGVyZSBhcmUgbm8gZGV2ZWxvcG1lbnQKPiBib2FyZHMgYXZhaWxhYmxlIGFuZCBwcm9iYWJs eSB0aGVyZSBhcmUgbm8gcmVhbCBwcm9kdWN0cyB3aXRoIGl0Lgo+IFJlbW92ZSB3aWRlLXRyZWUg c3VwcG9ydCBmb3IgRXh5bm9zNTQ0MC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgS296 bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+Cj4gLS0tCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdz L3RoZXJtYWwvZXh5bm9zLXRoZXJtYWwudHh0IHwgIDE0ICstCj4gIGRyaXZlcnMvdGhlcm1hbC9z YW1zdW5nL2V4eW5vc190bXUuYyAgICAgICAgICAgICAgIHwgMTU1ICstLS0tLS0tLS0tLS0tLS0t LS0tLQo+ICBkcml2ZXJzL3RoZXJtYWwvc2Ftc3VuZy9leHlub3NfdG11LmggICAgICAgICAgICAg ICB8ICAgMSAtCj4gIDMgZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxNjYgZGVsZXRp b25zKC0pCgoKQWZ0ZXIgYXBwbGllZCB0aGlzIHBhdGNoLCBJIHRlc3RlZCB0aGUgYnVpbGQgYW5k IGZvdW5kIG91dAonZXh5bm9zNTQ0MCcga2V5d29yZC4gVGhlcmUgaXMgb25lIGNvbW1lbnQgaW5j bHVkaW5nICdleHlub3M1NDQwJyBhcyBmb2xsb3dpbmc6CgoKQWZ0ZXIgcmVtb3ZpbmcgaXQsIGxv b2tzIGdvb2QgdG8gbWUuClJldmlld2VkLWJ5OiBDaGFud29vIENob2kgPGN3MDAuY2hvaUBzYW1z dW5nLmNvbT4KCmRpZmYgLS1naXQgYS9kcml2ZXJzL3RoZXJtYWwvc2Ftc3VuZy9leHlub3NfdG11 LmMgYi9kcml2ZXJzL3RoZXJtYWwvc2Ftc3VuZy9leHlub3NfdG11LmMKaW5kZXggZjkyZjQ3MGJj ZTIxLi5jYjUyNTIyOGNmZTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdGhlcm1hbC9zYW1zdW5nL2V4 eW5vc190bXUuYworKysgYi9kcml2ZXJzL3RoZXJtYWwvc2Ftc3VuZy9leHlub3NfdG11LmMKQEAg LTk0Myw3ICs5NDMsNyBAQCBzdGF0aWMgdm9pZCBleHlub3M0MjEwX3RtdV9jbGVhcl9pcnFzKHN0 cnVjdCBleHlub3NfdG11X2RhdGEgKmRhdGEpCiAgICAgICAgICogRXh5bm9zMzI1MCwgRXh5bm9z NDQxMiwgRXh5bm9zNTI1MCBhbmQgRXh5bm9zNTI2MCBpbmNvcnJlY3RseQogICAgICAgICAqIHN0 YXRlcyB0aGF0IElOVENMRUFSIHJlZ2lzdGVyIGhhcyBhIGRpZmZlcmVudCBwbGFjaW5nIG9mIGJp dHMKICAgICAgICAgKiByZXNwb25zaWJsZSBmb3IgRkFMTCBJUlFzIHRoYW4gSU5UU1RBVCByZWdp c3Rlci4gIEV4eW5vczU0MjAKLSAgICAgICAgKiBhbmQgRXh5bm9zNTQ0MCBkb2N1bWVudGF0aW9u IGlzIGNvcnJlY3QgKEV4eW5vczQyMTAgZG9lc24ndAorICAgICAgICAqIGRvY3VtZW50YXRpb24g aXMgY29ycmVjdCAoRXh5bm9zNDIxMCBkb2Vzbid0CiAgICAgICAgICogc3VwcG9ydCBGQUxMIElS UXMgYXQgYWxsKS4KICAgICAgICAgKi8KICAgICAgICB3cml0ZWwodmFsX2lycSwgZGF0YS0+YmFz ZSArIHRtdV9pbnRjbGVhcik7Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Thu, 26 Apr 2018 10:41:30 +0900 Subject: [RFC 06/10] thermal: samsung: Remove support for Exynos5440 In-Reply-To: <20180424203239.21885-7-krzk@kernel.org> References: <20180424203239.21885-1-krzk@kernel.org> <20180424203239.21885-7-krzk@kernel.org> Message-ID: <5AE12E4A.90907@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, On 2018? 04? 25? 05:32, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- > drivers/thermal/samsung/exynos_tmu.c | 155 +-------------------- > drivers/thermal/samsung/exynos_tmu.h | 1 - > 3 files changed, 4 insertions(+), 166 deletions(-) After applied this patch, I tested the build and found out 'exynos5440' keyword. There is one comment including 'exynos5440' as following: diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index f92f470bce21..cb525228cfe1 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data) * Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly * states that INTCLEAR register has a different placing of bits * responsible for FALL IRQs than INTSTAT register. Exynos5420 - * and Exynos5440 documentation is correct (Exynos4210 doesn't + * documentation is correct (Exynos4210 doesn't * support FALL IRQs at all). */ writel(val_irq, data->base + tmu_intclear); After removing it, looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics