From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/2] drm/amdgpu: abstract bo_base init function
Date: Thu, 26 Apr 2018 11:01:25 +0800
Message-ID: <5AE14105.3000706@amd.com>
References: <20180424073503.30175-1-david1.zhou@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20180424073503.30175-1-david1.zhou-5C7GfCeVMHo@public.gmane.org>
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: Chunming Zhou <david1.zhou-5C7GfCeVMHo@public.gmane.org>, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Shaoyun.Liu-5C7GfCeVMHo@public.gmane.org

T24gMDQvMjQvMjAxOCAwMzozNSBQTSwgQ2h1bm1pbmcgWmhvdSB3cm90ZToKPiBDaGFuZ2UtSWQ6
IElhM2U1N2RiYWNmZjA1ZjMyYjZjMDJlMjlhZWFkYWJkMzZmMDgwMjhlCj4gU2lnbmVkLW9mZi1i
eTogQ2h1bm1pbmcgWmhvdSA8ZGF2aWQxLnpob3VAYW1kLmNvbT4KUmV2aWV3ZWQtYnk6IEp1bndl
aSBaaGFuZyA8SmVycnkuWmhhbmdAYW1kLmNvbT4KCnNvbWUgdHJpdmlhbCBjb21tZW50cy4KCj4g
LS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyB8IDc1ICsrKysr
KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0MCBpbnNl
cnRpb25zKCspLCAzNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k
cm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft
ZGdwdV92bS5jCj4gaW5kZXggOGMzNDA2MGUxMzBmLi5jNzViOTY0MzNlZTcgMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+IEBAIC05NCw2ICs5NCw5IEBAIHN0cnVj
dCBhbWRncHVfcHJ0X2NiIHsKPiAgIAlzdHJ1Y3QgZG1hX2ZlbmNlX2NiIGNiOwo+ICAgfTsKPgo+
ICtzdGF0aWMgdm9pZCBhbWRncHVfdm1fYm9fYmFzZV9pbml0KHN0cnVjdCBhbWRncHVfdm1fYm9f
YmFzZSAqYmFzZSwKPiArCQkJCSAgIHN0cnVjdCBhbWRncHVfdm0gKnZtLAo+ICsJCQkJICAgc3Ry
dWN0IGFtZGdwdV9ibyAqYm8pOwoKTW92ZSB0aGUgZnVuY3Rpb24gdXBwZXIsIHdlIGNvdWxkIGF2
b2lkIHN1Y2ggZGVjbGFyYXRpb24uCgo+ICAgLyoqCj4gICAgKiBhbWRncHVfdm1fbGV2ZWxfc2hp
ZnQgLSByZXR1cm4gdGhlIGFkZHIgc2hpZnQgZm9yIGVhY2ggbGV2ZWwKPiAgICAqCj4gQEAgLTQ0
NiwxMSArNDQ5LDkgQEAgc3RhdGljIGludCBhbWRncHVfdm1fYWxsb2NfbGV2ZWxzKHN0cnVjdCBh
bWRncHVfZGV2aWNlICphZGV2LAo+ICAgCQkJKi8KPiAgIAkJCXB0LT5wYXJlbnQgPSBhbWRncHVf
Ym9fcmVmKHBhcmVudC0+YmFzZS5ibyk7Cj4KPiAtCQkJZW50cnktPmJhc2Uudm0gPSB2bTsKPiAt
CQkJZW50cnktPmJhc2UuYm8gPSBwdDsKPiAtCQkJbGlzdF9hZGRfdGFpbCgmZW50cnktPmJhc2Uu
Ym9fbGlzdCwgJnB0LT52YSk7Cj4gKwkJCWFtZGdwdV92bV9ib19iYXNlX2luaXQoJmVudHJ5LT5i
YXNlLCB2bSwgcHQpOwo+ICAgCQkJc3Bpbl9sb2NrKCZ2bS0+c3RhdHVzX2xvY2spOwo+IC0JCQls
aXN0X2FkZCgmZW50cnktPmJhc2Uudm1fc3RhdHVzLCAmdm0tPnJlbG9jYXRlZCk7Cj4gKwkJCWxp
c3RfbW92ZSgmZW50cnktPmJhc2Uudm1fc3RhdHVzLCAmdm0tPnJlbG9jYXRlZCk7Cj4gICAJCQlz
cGluX3VubG9jaygmdm0tPnN0YXR1c19sb2NrKTsKPiAgIAkJfQo+Cj4gQEAgLTE4MjEsNiArMTgy
MiwzNSBAQCBpbnQgYW1kZ3B1X3ZtX2hhbmRsZV9tb3ZlZChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAq
YWRldiwKPiAgIAlyZXR1cm4gcjsKPiAgIH0KPgo+ICtzdGF0aWMgdm9pZCBhbWRncHVfdm1fYm9f
YmFzZV9pbml0KHN0cnVjdCBhbWRncHVfdm1fYm9fYmFzZSAqYmFzZSwKPiArCQkJCSAgIHN0cnVj
dCBhbWRncHVfdm0gKnZtLAo+ICsJCQkJICAgc3RydWN0IGFtZGdwdV9ibyAqYm8pCj4gK3sKPiAr
CWJhc2UtPnZtID0gdm07Cj4gKwliYXNlLT5ibyA9IGJvOwo+ICsJSU5JVF9MSVNUX0hFQUQoJmJh
c2UtPmJvX2xpc3QpOwo+ICsJSU5JVF9MSVNUX0hFQUQoJmJhc2UtPnZtX3N0YXR1cyk7Cj4gKwo+
ICsJaWYgKCFibykKPiArCQlyZXR1cm47Cj4gKwlsaXN0X2FkZF90YWlsKCZiYXNlLT5ib19saXN0
LCAmYm8tPnZhKTsKPiArCj4gKwlpZiAoYm8tPnRiby5yZXN2ICE9IHZtLT5yb290LmJhc2UuYm8t
PnRiby5yZXN2KQo+ICsJCXJldHVybjsKPiArCj4gKwlpZiAoYm8tPnByZWZlcnJlZF9kb21haW5z
ICYKPiArCSAgICBhbWRncHVfbWVtX3R5cGVfdG9fZG9tYWluKGJvLT50Ym8ubWVtLm1lbV90eXBl
KSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJLyoKPiArCSAqIHdlIGNoZWNrZWQgYWxsIHRoZSBwcmVy
ZXF1aXNpdGVzLCBidXQgaXQgbG9va3MgbGlrZSB0aGlzIHBlciB2bSBibwo+ICsJICogaXMgY3Vy
cmVudGx5IGV2aWN0ZWQuIGFkZCB0aGUgYm8gdG8gdGhlIGV2aWN0ZWQgbGlzdCB0byBtYWtlIHN1
cmUgaXQKPiArCSAqIGlzIHZhbGlkYXRlZCBvbiBuZXh0IHZtIHVzZSB0byBhdm9pZCBmYXVsdC4K
PiArCSAqICovCgovKgogICoKICAqLyAgaXMgZXhwZWN0ZWQKCj4gKwlzcGluX2xvY2soJnZtLT5z
dGF0dXNfbG9jayk7Cj4gKwlsaXN0X21vdmVfdGFpbCgmYmFzZS0+dm1fc3RhdHVzLCAmdm0tPmV2
aWN0ZWQpOwo+ICsJc3Bpbl91bmxvY2soJnZtLT5zdGF0dXNfbG9jayk7Cj4gK30KPiAgIC8qKgo+
ICAgICogYW1kZ3B1X3ZtX2JvX2FkZCAtIGFkZCBhIGJvIHRvIGEgc3BlY2lmaWMgdm0KPiAgICAq
Cj4gQEAgLTE4NDQsMzYgKzE4NzQsMTIgQEAgc3RydWN0IGFtZGdwdV9ib192YSAqYW1kZ3B1X3Zt
X2JvX2FkZChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgIAlpZiAoYm9fdmEgPT0gTlVM
TCkgewo+ICAgCQlyZXR1cm4gTlVMTDsKPiAgIAl9Cj4gLQlib192YS0+YmFzZS52bSA9IHZtOwo+
IC0JYm9fdmEtPmJhc2UuYm8gPSBibzsKPiAtCUlOSVRfTElTVF9IRUFEKCZib192YS0+YmFzZS5i
b19saXN0KTsKPiAtCUlOSVRfTElTVF9IRUFEKCZib192YS0+YmFzZS52bV9zdGF0dXMpOwo+ICsJ
YW1kZ3B1X3ZtX2JvX2Jhc2VfaW5pdCgmYm9fdmEtPmJhc2UsIHZtLCBibyk7Cj4KPiAgIAlib192
YS0+cmVmX2NvdW50ID0gMTsKPiAgIAlJTklUX0xJU1RfSEVBRCgmYm9fdmEtPnZhbGlkcyk7Cj4g
ICAJSU5JVF9MSVNUX0hFQUQoJmJvX3ZhLT5pbnZhbGlkcyk7Cj4KPiAtCWlmICghYm8pCj4gLQkJ
cmV0dXJuIGJvX3ZhOwo+IC0KPiAtCWxpc3RfYWRkX3RhaWwoJmJvX3ZhLT5iYXNlLmJvX2xpc3Qs
ICZiby0+dmEpOwo+IC0KPiAtCWlmIChiby0+dGJvLnJlc3YgIT0gdm0tPnJvb3QuYmFzZS5iby0+
dGJvLnJlc3YpCj4gLQkJcmV0dXJuIGJvX3ZhOwo+IC0KPiAtCWlmIChiby0+cHJlZmVycmVkX2Rv
bWFpbnMgJgo+IC0JICAgIGFtZGdwdV9tZW1fdHlwZV90b19kb21haW4oYm8tPnRiby5tZW0ubWVt
X3R5cGUpKQo+IC0JCXJldHVybiBib192YTsKPiAtCj4gLQkvKgo+IC0JICogV2UgY2hlY2tlZCBh
bGwgdGhlIHByZXJlcXVpc2l0ZXMsIGJ1dCBpdCBsb29rcyBsaWtlIHRoaXMgcGVyIFZNIEJPCj4g
LQkgKiBpcyBjdXJyZW50bHkgZXZpY3RlZC4gYWRkIHRoZSBCTyB0byB0aGUgZXZpY3RlZCBsaXN0
IHRvIG1ha2Ugc3VyZSBpdAo+IC0JICogaXMgdmFsaWRhdGVkIG9uIG5leHQgVk0gdXNlIHRvIGF2
b2lkIGZhdWx0Lgo+IC0JICogKi8KPiAtCXNwaW5fbG9jaygmdm0tPnN0YXR1c19sb2NrKTsKPiAt
CWxpc3RfbW92ZV90YWlsKCZib192YS0+YmFzZS52bV9zdGF0dXMsICZ2bS0+ZXZpY3RlZCk7Cj4g
LQlzcGluX3VubG9jaygmdm0tPnN0YXR1c19sb2NrKTsKPiAtCj4gICAJcmV0dXJuIGJvX3ZhOwo+
ICAgfQo+Cj4gQEAgLTIzNzMsNiArMjM3OSw3IEBAIGludCBhbWRncHVfdm1faW5pdChzdHJ1Y3Qg
YW1kZ3B1X2RldmljZSAqYWRldiwgc3RydWN0IGFtZGdwdV92bSAqdm0sCj4gICAJCSAgIGludCB2
bV9jb250ZXh0LCB1bnNpZ25lZCBpbnQgcGFzaWQpCj4gICB7Cj4gICAJc3RydWN0IGFtZGdwdV9i
b19wYXJhbSBicDsKPiArCXN0cnVjdCBhbWRncHVfYm8gKnJvb3Q7Cj4gICAJY29uc3QgdW5zaWdu
ZWQgYWxpZ24gPSBtaW4oQU1ER1BVX1ZNX1BUQl9BTElHTl9TSVpFLAo+ICAgCQlBTURHUFVfVk1f
UFRFX0NPVU5UKGFkZXYpICogOCk7Cj4gICAJdW5zaWduZWQgcmluZ19pbnN0YW5jZTsKPiBAQCAt
MjQzNCwyMyArMjQ0MSwyMSBAQCBpbnQgYW1kZ3B1X3ZtX2luaXQoc3RydWN0IGFtZGdwdV9kZXZp
Y2UgKmFkZXYsIHN0cnVjdCBhbWRncHVfdm0gKnZtLAo+ICAgCWJwLmZsYWdzID0gZmxhZ3M7Cj4g
ICAJYnAudHlwZSA9IHR0bV9ib190eXBlX2tlcm5lbDsKPiAgIAlicC5yZXN2ID0gTlVMTDsKPiAt
CXIgPSBhbWRncHVfYm9fY3JlYXRlKGFkZXYsICZicCwgJnZtLT5yb290LmJhc2UuYm8pOwo+ICsJ
ciA9IGFtZGdwdV9ib19jcmVhdGUoYWRldiwgJmJwLCAmcm9vdCk7Cj4gICAJaWYgKHIpCj4gICAJ
CWdvdG8gZXJyb3JfZnJlZV9zY2hlZF9lbnRpdHk7Cj4KPiAtCXIgPSBhbWRncHVfYm9fcmVzZXJ2
ZSh2bS0+cm9vdC5iYXNlLmJvLCB0cnVlKTsKPiArCXIgPSBhbWRncHVfYm9fcmVzZXJ2ZShyb290
LCB0cnVlKTsKPiAgIAlpZiAocikKPiAgIAkJZ290byBlcnJvcl9mcmVlX3Jvb3Q7Cj4KPiAtCXIg
PSBhbWRncHVfdm1fY2xlYXJfYm8oYWRldiwgdm0sIHZtLT5yb290LmJhc2UuYm8sCj4gKwlyID0g
YW1kZ3B1X3ZtX2NsZWFyX2JvKGFkZXYsIHZtLCByb290LAo+ICAgCQkJICAgICAgIGFkZXYtPnZt
X21hbmFnZXIucm9vdF9sZXZlbCwKPiAgIAkJCSAgICAgICB2bS0+cHRlX3N1cHBvcnRfYXRzKTsK
PiAgIAlpZiAocikKPiAgIAkJZ290byBlcnJvcl91bnJlc2VydmU7Cj4KPiAtCXZtLT5yb290LmJh
c2Uudm0gPSB2bTsKPiAtCWxpc3RfYWRkX3RhaWwoJnZtLT5yb290LmJhc2UuYm9fbGlzdCwgJnZt
LT5yb290LmJhc2UuYm8tPnZhKTsKPiAtCWxpc3RfYWRkX3RhaWwoJnZtLT5yb290LmJhc2Uudm1f
c3RhdHVzLCAmdm0tPmV2aWN0ZWQpOwo+ICsJYW1kZ3B1X3ZtX2JvX2Jhc2VfaW5pdCgmdm0tPnJv
b3QuYmFzZSwgdm0sIHJvb3QpOwo+ICAgCWFtZGdwdV9ib191bnJlc2VydmUodm0tPnJvb3QuYmFz
ZS5ibyk7Cj4KPiAgIAlpZiAocGFzaWQpIHsKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZy
ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2FtZC1nZngK