From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"Chi-Hsien Lin" <chi-hsien.lin@cypress.com>,
"Wright Feng" <wright.feng@cypress.com>,
"Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com
Subject: Re: [PATCH] brcmfmac: add debugfs entry for reading firmware capabilities
Date: Mon, 14 May 2018 09:24:39 +0200 [thread overview]
Message-ID: <5AF939B7.9050202@broadcom.com> (raw)
In-Reply-To: <5729429a82d2eb034b88adb7e1738ce6@milecki.pl>
On 5/14/2018 7:11 AM, Rafał Miłecki wrote:
>>> +/**
>>> + * brcmf_cap_read() - expose firmware capabilities to debugfs.
>>
>> Please stick to naming convention brcmf_<module>_foo(), ie.
>> brcmf_feat_cap_read().
>
> Will do, thanks! I missed that naming convention because of
> brcmf_debugfs_fws_stats_read() / brcmf_debugfs_sdio_count_read() which
> slightly confused me. I see your point now!
Yeah. Sorry for the confusion. There is always room to improve.
Gr. AvS
next prev parent reply other threads:[~2018-05-14 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 10:15 [PATCH] brcmfmac: add debugfs entry for reading firmware capabilities Rafał Miłecki
2018-05-13 18:59 ` Arend van Spriel
2018-05-14 5:11 ` Rafał Miłecki
2018-05-14 7:24 ` Arend van Spriel [this message]
2018-05-14 6:48 ` [PATCH V2] " Rafał Miłecki
2018-05-23 8:01 ` [V2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AF939B7.9050202@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafal@milecki.pl \
--cc=wright.feng@cypress.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.