All of lore.kernel.org
 help / color / mirror / Atom feed
From: xuwei5@hisilicon.com (Wei Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] arm64: defconfig: hisilicon config updates for v4.18
Date: Fri, 18 May 2018 11:48:48 +0100	[thread overview]
Message-ID: <5AFEAF90.2030405@hisilicon.com> (raw)
In-Reply-To: <20180515230014.GS29062@mai>

Hi Daniel,

On 2018/5/16 0:00, Daniel Lezcano wrote:
> On Tue, May 15, 2018 at 01:37:55PM -0700, Olof Johansson wrote:
>> On Tue, May 15, 2018 at 10:28:11AM +0200, Daniel Lezcano wrote:
>>> On Mon, May 14, 2018 at 01:14:45PM -0700, Olof Johansson wrote:
>>>> Hi Wei,
>>>>
>>>> On Fri, May 11, 2018 at 03:31:38PM +0100, Wei Xu wrote:
>>>>> Hi Arnd, Hi Olof,
>>>>>
>>>>> Please help to pull the following changes.
>>>>>
>>>>> About the CLOCK_STUB and the MAILBOX consolidate patch,
>>>>> Jassi and Stephen have acked it.
>>>>> Could you let me know how to handle this kind case
>>>>> if it is not OK to be in this pull?
>>>>
>>>> I don't think there's any need to group the Kconfig changes with the defconfig
>>>> updates here, is there?
>>>
>>> I don't have the patches history, but likely this patch should come together with:
>>>
>>> https://patchwork.kernel.org/patch/10399799/
>>> https://patchwork.kernel.org/patch/10399801/
>>>
>>> Otherwise the compilation options won't be consistent with what is enabled in
>>> the DT.
>>
>> As long as neither side regresses due to the changes, there should be no
>> problem. Just because a DT node is added in the tree there's no need to
>> configure the driver. Or am I missing some aspect of it here?
> 
> Actually, the DT node being added do not introduce regressions.
> 
> However it is expected by adding the clock stub and the mailbox to have the
> cpufreq working which is not necessarily the case because the config may be
> inconsistent, so the cpufreq may be working on some config if the user had the
> options for the clock and the mailbox enabled but these options can disappear
> and not come back because of this Kconfig inconsistencies.
> 
>>From my point of view, by adding those DT nodes, it makes sense to give a
> consolidated Kconfig coming together and ensuring the drivers are enabled when
> the node is parsed.
> 
> On the other side, the patch is simple enough to be split and submitted in
> separated trees, hoping the maintainer Wu Xei and the branch users keep in mind
> if the board does not boot or has inconsistent behavior they will have to
> double check the options are enabled for the clock stub and the mailbox.
> 
> I don't have a strong opinion on this actually, whatever the decision is, I
> will be fine with resubmitting the patch to the different trees, or keep it as
> is and merge it through the hisi tree.

Thanks to make it clear!
In this case, I will drop this patch in the pull firstly.

Best Regards,
Wei

> 
>   -- Daniel
> 

      reply	other threads:[~2018-05-18 10:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11 14:31 [GIT PULL] arm64: defconfig: hisilicon config updates for v4.18 Wei Xu
2018-05-14 20:14 ` Olof Johansson
2018-05-15  8:28   ` Daniel Lezcano
2018-05-15 20:37     ` Olof Johansson
2018-05-15 23:00       ` Daniel Lezcano
2018-05-18 10:48         ` Wei Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AFEAF90.2030405@hisilicon.com \
    --to=xuwei5@hisilicon.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.