From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC, ghes: Make platform-based whitelisting x86-only From: Zhengqiang Message-Id: <5B0293B5.5060406@huawei.com> Date: Mon, 21 May 2018 17:39:01 +0800 To: Borislav Petkov , James Morse Cc: Tyler Baicar , mchehab@kernel.org, toshi.kani@hpe.com, linux-edac@vger.kernel.org, linuxarm@huawei.com, "linux-arm-kernel@lists.infradead.org" List-ID: VGhhbmtzLCBpdCB3b3JrcyBmb3IgbWUuCgpPbiAyMDE4LzUvMTggMTk6MjAsIEJvcmlzbGF2IFBl dGtvdiB3cm90ZToKPiBGcm9tOiBCb3Jpc2xhdiBQZXRrb3YgPGJwQHN1c2UuZGU+Cj4gCj4gQVJN IG1hY2hpbmVzIGFsbCBoYXZlIERNSSB0YWJsZXMgc28gaWYgdGhleSByZXF1ZXN0IGh3IGVycm9y IHJlcG9ydGluZwo+IHRocm91Z2ggR0hFUywgdGhlbiB0aGUgZHJpdmVyIHNob3VsZCBiZSBhYmxl IHRvIGRldGVjdCBESU1NcyBhbmQgcmVwb3J0Cj4gZXJyb3JzIHN1Y2Nlc3NmdWxseSAoZmFtb3Vz IGxhc3Qgd29yZHMgOikpLgo+IAo+IE1ha2UgdGhlIHBsYXRmb3JtLWJhc2VkIGxpc3QgeDg2LXNw ZWNpZmljIHNvIHRoYXQgZ2hlc19lZGFjIGNhbiBsb2FkIG9uCj4gQVJNLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IEJvcmlzbGF2IFBldGtvdiA8YnBAc3VzZS5kZT4KPiBSZXZpZXdlZC1ieTogSmFtZXMg TW9yc2UgPGphbWVzLm1vcnNlQGFybS5jb20+Cj4gVGVzdGVkLWJ5OiBKYW1lcyBNb3JzZSA8amFt ZXMubW9yc2VAYXJtLmNvbT4KPiBDYzogUWlhbmcgWmhlbmcgPHpoZW5ncWlhbmcxMEBodWF3ZWku Y29tPgo+IExpbms6IGh0dHBzOi8vbGttbC5rZXJuZWwub3JnL3IvMTUyNjAzOTU0My0xODA5OTYt MS1naXQtc2VuZC1lbWFpbC16aGVuZ3FpYW5nMTBAaHVhd2VpLmNvbQoKVGVzdGVkLWJ5OiBRaWFu ZyBaaGVuZyA8emhlbmdxaWFuZzEwQGh1YXdlaS5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2VkYWMv Z2hlc19lZGFjLmMgfCAxNCArKysrKysrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2VkYWMv Z2hlc19lZGFjLmMgYi9kcml2ZXJzL2VkYWMvZ2hlc19lZGFjLmMKPiBpbmRleCA4NjNmYmYzZGIy OWYuLjQ3M2FlZWM0YjFkYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2VkYWMvZ2hlc19lZGFjLmMK PiArKysgYi9kcml2ZXJzL2VkYWMvZ2hlc19lZGFjLmMKPiBAQCAtNDQwLDEyICs0NDAsMTYgQEAg aW50IGdoZXNfZWRhY19yZWdpc3RlcihzdHJ1Y3QgZ2hlcyAqZ2hlcywgc3RydWN0IGRldmljZSAq ZGV2KQo+ICAJc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpOwo+ICAJc3RydWN0IGVkYWNfbWNfbGF5 ZXIgbGF5ZXJzWzFdOwo+ICAJc3RydWN0IGdoZXNfZWRhY19kaW1tX2ZpbGwgZGltbV9maWxsOwo+ IC0JaW50IGlkeDsKPiArCWludCBpZHggPSAtMTsKPiAgCj4gLQkvKiBDaGVjayBpZiBzYWZlIHRv IGVuYWJsZSBvbiB0aGlzIHN5c3RlbSAqLwo+IC0JaWR4ID0gYWNwaV9tYXRjaF9wbGF0Zm9ybV9s aXN0KHBsYXRfbGlzdCk7Cj4gLQlpZiAoIWZvcmNlX2xvYWQgJiYgaWR4IDwgMCkKPiAtCQlyZXR1 cm4gLUVOT0RFVjsKPiArCWlmIChJU19FTkFCTEVEKENPTkZJR19YODYpKSB7Cj4gKwkJLyogQ2hl Y2sgaWYgc2FmZSB0byBlbmFibGUgb24gdGhpcyBzeXN0ZW0gKi8KPiArCQlpZHggPSBhY3BpX21h dGNoX3BsYXRmb3JtX2xpc3QocGxhdF9saXN0KTsKPiArCQlpZiAoIWZvcmNlX2xvYWQgJiYgaWR4 IDwgMCkKPiArCQkJcmV0dXJuIC1FTk9ERVY7Cj4gKwl9IGVsc2Ugewo+ICsJCWlkeCA9IDA7Cj4g Kwl9Cj4gIAo+ICAJLyoKPiAgCSAqIFdlIGhhdmUgb25seSBvbmUgbG9naWNhbCBtZW1vcnkgY29u dHJvbGxlciB0byB3aGljaCBhbGwgRElNTXMgYmVsb25nLgo+Ci0tLQpUbyB1bnN1YnNjcmliZSBm cm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtZWRhYyIgaW4K dGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBt YWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5o dG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhengqiang10@huawei.com (Zhengqiang) Date: Mon, 21 May 2018 17:39:01 +0800 Subject: [PATCH] EDAC, ghes: Make platform-based whitelisting x86-only In-Reply-To: <20180518112028.GD17285@pd.tnic> References: <1526039543-180996-1-git-send-email-zhengqiang10@huawei.com> <20180511121901.GA12705@pd.tnic> <5AF90C70.408@huawei.com> <20180514094709.GC23049@pd.tnic> <20180514164720.GH23049@pd.tnic> <20180516182958.GB17092@pd.tnic> <8602b133-e0fa-57e2-5159-9d34a1ded85f@arm.com> <20180518111132.GC17285@pd.tnic> <20180518112028.GD17285@pd.tnic> Message-ID: <5B0293B5.5060406@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thanks, it works for me. On 2018/5/18 19:20, Borislav Petkov wrote: > From: Borislav Petkov > > ARM machines all have DMI tables so if they request hw error reporting > through GHES, then the driver should be able to detect DIMMs and report > errors successfully (famous last words :)). > > Make the platform-based list x86-specific so that ghes_edac can load on > ARM. > > Signed-off-by: Borislav Petkov > Reviewed-by: James Morse > Tested-by: James Morse > Cc: Qiang Zheng > Link: https://lkml.kernel.org/r/1526039543-180996-1-git-send-email-zhengqiang10 at huawei.com Tested-by: Qiang Zheng > --- > drivers/edac/ghes_edac.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c > index 863fbf3db29f..473aeec4b1da 100644 > --- a/drivers/edac/ghes_edac.c > +++ b/drivers/edac/ghes_edac.c > @@ -440,12 +440,16 @@ int ghes_edac_register(struct ghes *ghes, struct device *dev) > struct mem_ctl_info *mci; > struct edac_mc_layer layers[1]; > struct ghes_edac_dimm_fill dimm_fill; > - int idx; > + int idx = -1; > > - /* Check if safe to enable on this system */ > - idx = acpi_match_platform_list(plat_list); > - if (!force_load && idx < 0) > - return -ENODEV; > + if (IS_ENABLED(CONFIG_X86)) { > + /* Check if safe to enable on this system */ > + idx = acpi_match_platform_list(plat_list); > + if (!force_load && idx < 0) > + return -ENODEV; > + } else { > + idx = 0; > + } > > /* > * We have only one logical memory controller to which all DIMMs belong. >