All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	Andrew Zaborowski <andrew.zaborowski@intel.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Reject disconnect commands except from conn_owner
Date: Tue, 22 May 2018 12:30:51 +0200	[thread overview]
Message-ID: <5B03F15B.90904@broadcom.com> (raw)
In-Reply-To: <1526977281.6787.8.camel@sipsolutions.net>

On 5/22/2018 10:21 AM, Johannes Berg wrote:
> On Tue, 2018-05-22 at 09:53 +0200, Arend van Spriel wrote:
>> On 5/22/2018 2:46 AM, Andrew Zaborowski wrote:
>>> Reject NL80211_CMD_DISCONNECT, NL80211_CMD_DISASSOCIATE,
>>> NL80211_CMD_DEAUTHENTICATE and NL80211_CMD_ASSOCIATE commands
>>> from clients other than the connection owner set in the connect,
>>> authenticate or associate commands, if it was set.
>>>
>>> The main point of this check is to prevent chaos when two processes
>>> try to use nl80211 at the same time, it's not a security measure.
>>> The same thing should possibly be done for JOIN_IBSS/LEAVE_IBSS and
>>> START_AP/STOP_AP.
>>
>> Isn't this V2? What has changed since last time?
>
> It was RFC before I guess.

Ah, yes. That's it.

Thanks,
Arend

  reply	other threads:[~2018-05-22 10:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22  0:46 [PATCH] nl80211: Reject disconnect commands except from conn_owner Andrew Zaborowski
2018-05-22  7:53 ` Arend van Spriel
2018-05-22  8:21   ` Johannes Berg
2018-05-22 10:30     ` Arend van Spriel [this message]
2018-05-22 10:33   ` Andrew Zaborowski
2018-05-22 10:39     ` Arend van Spriel
  -- strict thread matches above, loose matches on Subject: below --
2018-04-28  1:47 Andrew Zaborowski
2018-04-28 13:07 ` Kalle Valo
2018-04-29 18:30   ` Andrew Zaborowski
2018-05-07 19:19     ` Johannes Berg
2018-05-08 12:18       ` Arend van Spriel
2018-05-08 12:19         ` Johannes Berg
2018-05-08 12:34           ` Arend van Spriel
     [not found]             ` <A996D5EE-1279-4DEC-832F-FC4D5FD7FC61@gmail.com>
2018-05-22 10:39               ` Arend van Spriel
2018-05-22 14:45                 ` Denis Kenzior
2018-05-08 20:03           ` Andrew Zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B03F15B.90904@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=andrew.zaborowski@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.