From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>, Ganapathi Bhat <gbhat@marvell.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Xinming Hu <huxm@marvell.com>
Subject: Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
Date: Wed, 23 May 2018 10:11:52 +0200 [thread overview]
Message-ID: <5B052248.5020805@broadcom.com> (raw)
In-Reply-To: <87po1mu7s2.fsf@purkki.adurom.net>
On 5/23/2018 9:54 AM, Kalle Valo wrote:
> Ganapathi Bhat <gbhat@marvell.com> writes:
>
>> In V2:
>>
>> return ret;
>> }
>> +EXPORT_SYMBOL_GPL(mwifiex_send_cmd);
>>
>> Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for
>> the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me
>> know if we can send a follow up.
>
> So what's the plan? Can I apply this patch or should I drop it?
Sorry. Had to reply that earlier. When adding the export I figured it
might not be desirable. If Ganapathi can fix it with a follow up patch
that would ok, right? Than you can apply it, I would say.
Regards,
Arend
next prev parent reply other threads:[~2018-05-23 8:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 12:11 [PATCH V2 0/6] brcmfmac: coredump functionality and fixes Arend van Spriel
2018-05-16 12:11 ` [PATCH V2 1/6] brcmfmac: move ALLFFMAC variable in flowring module Arend van Spriel
2018-05-16 13:36 ` Kalle Valo
2018-05-23 15:54 ` [V2,1/6] " Kalle Valo
2018-05-16 12:11 ` [PATCH V2 2/6] brcmfmac: add support for sysfs initiated coredump Arend van Spriel
2018-05-16 12:12 ` [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump Arend van Spriel
2018-05-16 13:50 ` Kalle Valo
2018-05-16 18:52 ` Arend van Spriel
2018-05-21 8:19 ` [EXT] " Ganapathi Bhat
2018-05-23 7:54 ` Kalle Valo
2018-05-23 8:11 ` Arend van Spriel [this message]
2018-05-23 8:17 ` Kalle Valo
2018-05-23 11:24 ` Ganapathi Bhat
2018-05-23 15:56 ` Kalle Valo
2018-05-16 12:12 ` [PATCH V2 4/6] brcmfmac: validate user provided data for memdump before copying Arend van Spriel
2018-05-16 12:12 ` [PATCH V2 5/6] brcmfmac: trigger memory dump upon firmware halt signal Arend van Spriel
2018-05-16 12:12 ` [PATCH V2 6/6] brcmfmac: trigger memory dump on SDIO firmware halt message Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B052248.5020805@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=amitkarwar@gmail.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.