From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: [RFC PATCH] target: add emulate_pr backstore attr to toggle PR support
Date: Thu, 21 Jun 2018 20:04:15 +0000 [thread overview]
Message-ID: <5B2C04BF.5020603@redhat.com> (raw)
In-Reply-To: <20180601000532.11058-1-ddiss@suse.de>
On 06/21/2018 10:26 AM, David Disseldorp wrote:
> On Mon, 4 Jun 2018 12:13:22 -0500, Mike Christie wrote:
>
>>> AFAICT, targetcli (via rtslib-fb) only makes use of the
>>> res_aptpl_metadata path. I'm not aware of any other consumers, so happy
>>> to go with whatever the community preference is here.
>>>
>>
>> I just seems odd to have a file use 2 different formats for no reason
>> except there were 2 different people coding it.
>
> It's already a bit inconsistent, in that res_holder_show() returns human
> readable strings and res_type_show() opts for enum type strings. I've
> changed both to use "SPC_RESERVATIONS_DISABLED" for the disabled case
> for now.
>
I was only asking that we at least have the same format within a file,
so we do not have messes like the backend info file.
prev parent reply other threads:[~2018-06-21 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 0:05 [RFC PATCH] target: add emulate_pr backstore attr to toggle PR support David Disseldorp
2018-06-01 13:20 ` Bryant G. Ly
2018-06-01 16:22 ` Mike Christie
2018-06-03 12:57 ` David Disseldorp
2018-06-04 17:13 ` Mike Christie
2018-06-21 15:03 ` David Disseldorp
2018-06-21 15:26 ` David Disseldorp
2018-06-21 20:04 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B2C04BF.5020603@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.