From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Xu Subject: Re: [PATCH 1/3] arm: Convert arm boot_lock to raw Date: Mon, 16 Jul 2018 16:30:36 +0100 Message-ID: <5B4CBA1C.3060408@hisilicon.com> References: <20180711110037.12928-1-bigeasy@linutronix.de> <20180711110037.12928-2-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180711110037.12928-2-bigeasy@linutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sebastian Andrzej Siewior , linux-arm-kernel@lists.infradead.org Cc: Barry Song , linux-samsung-soc@vger.kernel.org, Tony Lindgren , Frank Rowand , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Russell King , Krzysztof Kozlowski , Patrice Chotard , Maxime Ripard , David Brown , Chen-Yu Tsai , Kukjin Kim , Viresh Kumar , Andy Gross , tglx@linutronix.de, linux-omap@vger.kernel.org, Shiraz Hashim , =?UTF-8?Q?Andreas_F=c3=a4rber?= List-Id: linux-arm-msm@vger.kernel.org Ck9uIDIwMTgvNy8xMSAxMjowMCwgU2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lvciB3cm90ZToKPiBG cm9tOiBGcmFuayBSb3dhbmQgPGZyYW5rLnJvd2FuZEBhbS5zb255LmNvbT4KPiAKPiBUaGUgYXJt IGJvb3RfbG9jayBpcyB1c2VkIGJ5IHRoZSBzZWNvbmRhcnkgcHJvY2Vzc29yIHN0YXJ0dXAgY29k ZS4gIFRoZSBsb2NraW5nCj4gdGFzayBpcyB0aGUgaWRsZSB0aHJlYWQsIHdoaWNoIGhhcyBpZGxl LT5zY2hlZF9jbGFzcyA9PSAmaWRsZV9zY2hlZF9jbGFzcy4KPiBpZGxlX3NjaGVkX2NsYXNzLT5l bnF1ZXVlX3Rhc2sgPT0gTlVMTCwgc28gaWYgdGhlIGlkbGUgdGFzayBibG9ja3Mgb24gdGhlCj4g bG9jaywgdGhlIGF0dGVtcHQgdG8gd2FrZSBpdCB3aGVuIHRoZSBsb2NrIGJlY29tZXMgYXZhaWxh YmxlIHdpbGwgZmFpbDoKPiAKPiB0cnlfdG9fd2FrZV91cCgpCj4gICAgLi4uCj4gICAgICAgYWN0 aXZhdGVfdGFzaygpCj4gICAgICAgICAgZW5xdWV1ZV90YXNrKCkKPiAgICAgICAgICAgICBwLT5z Y2hlZF9jbGFzcy0+ZW5xdWV1ZV90YXNrKHJxLCBwLCBmbGFncykKPiAKPiBGaXggYnkgY29udmVy dGluZyBib290X2xvY2sgdG8gYSByYXcgc3BpbiBsb2NrLgo+IAo+IENjOiAiQW5kcmVhcyBGw6Ry YmVyIiA8YWZhZXJiZXJAc3VzZS5kZT4KPiBDYzogS3VramluIEtpbSA8a2dlbmVAa2VybmVsLm9y Zz4KPiBDYzogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6a0BrZXJuZWwub3JnPgo+IENjOiBXZWkg WHUgPHh1d2VpNUBoaXNpbGljb24uY29tPgo+IENjOiBUb255IExpbmRncmVuIDx0b255QGF0b21p ZGUuY29tPgo+IENjOiBCYXJyeSBTb25nIDxiYW9odWFAa2VybmVsLm9yZz4KPiBDYzogQW5keSBH cm9zcyA8YW5keS5ncm9zc0BsaW5hcm8ub3JnPgo+IENjOiBEYXZpZCBCcm93biA8ZGF2aWQuYnJv d25AbGluYXJvLm9yZz4KPiBDYzogVmlyZXNoIEt1bWFyIDx2aXJlc2hrQGtlcm5lbC5vcmc+Cj4g Q2M6IFNoaXJheiBIYXNoaW0gPHNoaXJhei5saW51eC5rZXJuZWxAZ21haWwuY29tPgo+IENjOiBQ YXRyaWNlIENob3RhcmQgPHBhdHJpY2UuY2hvdGFyZEBzdC5jb20+Cj4gQ2M6IE1heGltZSBSaXBh cmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+Cj4gQ2M6IENoZW4tWXUgVHNhaSA8d2Vuc0Bj c2llLm9yZz4KPiBDYzogbGludXgtc2Ftc3VuZy1zb2NAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxp bnV4LW9tYXBAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbnV4LWFybS1tc21Admdlci5rZXJuZWwu b3JnCj4gQ2M6IGxpbnV4LXNvY0B2Z2VyLmtlcm5lbC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBGcmFu ayBSb3dhbmQgPGZyYW5rLnJvd2FuZEBhbS5zb255LmNvbT4KPiBMaW5rOiBodHRwOi8vbGttbC5r ZXJuZWwub3JnL3IvNEU3N0I5NTIuMzAxMDYwNkBhbS5zb255LmNvbQo+IFNpZ25lZC1vZmYtYnk6 IFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPgo+IFRlc3RlZC1ieTogVG9ueSBM aW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4KPiBBY2tlZC1ieTogS3J6eXN6dG9mIEtvemxvd3Nr aSA8a3J6a0BrZXJuZWwub3JnPgo+IFRlc3RlZC1ieTogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6 a0BrZXJuZWwub3JnPiBbRXh5bm9zNTQyMiBMaW5hcm8gUE0tUUFdCj4gU2lnbmVkLW9mZi1ieTog U2ViYXN0aWFuIEFuZHJ6ZWogU2lld2lvciA8YmlnZWFzeUBsaW51dHJvbml4LmRlPgo+IC0tLQo+ ICBhcmNoL2FybS9tYWNoLWFjdGlvbnMvcGxhdHNtcC5jICAgfCAgNiArKystLS0KPiAgYXJjaC9h cm0vbWFjaC1leHlub3MvcGxhdHNtcC5jICAgIHwgMTIgKysrKysrLS0tLS0tCj4gIGFyY2gvYXJt L21hY2gtaGlzaS9wbGF0bWNwbS5jICAgICB8IDIyICsrKysrKysrKysrLS0tLS0tLS0tLS0KClRo YW5rcyEKQWNrZWQtYnk6IFdlaSBYdSA8eHV3ZWk1QGhpc2lsaWNvbi5jb20+IChmb3IgbWFjaC1o aXNpKQoKQmVzdCBSZWdhcmRzLApXZWkKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: xuwei5@hisilicon.com (Wei Xu) Date: Mon, 16 Jul 2018 16:30:36 +0100 Subject: [PATCH 1/3] arm: Convert arm boot_lock to raw In-Reply-To: <20180711110037.12928-2-bigeasy@linutronix.de> References: <20180711110037.12928-1-bigeasy@linutronix.de> <20180711110037.12928-2-bigeasy@linutronix.de> Message-ID: <5B4CBA1C.3060408@hisilicon.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018/7/11 12:00, Sebastian Andrzej Siewior wrote: > From: Frank Rowand > > The arm boot_lock is used by the secondary processor startup code. The locking > task is the idle thread, which has idle->sched_class == &idle_sched_class. > idle_sched_class->enqueue_task == NULL, so if the idle task blocks on the > lock, the attempt to wake it when the lock becomes available will fail: > > try_to_wake_up() > ... > activate_task() > enqueue_task() > p->sched_class->enqueue_task(rq, p, flags) > > Fix by converting boot_lock to a raw spin lock. > > Cc: "Andreas F?rber" > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Wei Xu > Cc: Tony Lindgren > Cc: Barry Song > Cc: Andy Gross > Cc: David Brown > Cc: Viresh Kumar > Cc: Shiraz Hashim > Cc: Patrice Chotard > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: linux-samsung-soc at vger.kernel.org > Cc: linux-omap at vger.kernel.org > Cc: linux-arm-msm at vger.kernel.org > Cc: linux-soc at vger.kernel.org > Signed-off-by: Frank Rowand > Link: http://lkml.kernel.org/r/4E77B952.3010606 at am.sony.com > Signed-off-by: Thomas Gleixner > Tested-by: Tony Lindgren > Acked-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski [Exynos5422 Linaro PM-QA] > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/arm/mach-actions/platsmp.c | 6 +++--- > arch/arm/mach-exynos/platsmp.c | 12 ++++++------ > arch/arm/mach-hisi/platmcpm.c | 22 +++++++++++----------- Thanks! Acked-by: Wei Xu (for mach-hisi) Best Regards, Wei