From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkDJn-0005JV-WF for ath10k@lists.infradead.org; Mon, 30 Jul 2018 18:54:57 +0000 Received: by mail-ed1-x541.google.com with SMTP id k15-v6so4574009edr.3 for ; Mon, 30 Jul 2018 11:54:45 -0700 (PDT) Subject: Re: [PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit References: <20180730153933.3771-1-sven.eckelmann@openmesh.com> From: Arend van Spriel Message-ID: <5B5F5EF2.2050100@broadcom.com> Date: Mon, 30 Jul 2018 20:54:42 +0200 MIME-Version: 1.0 In-Reply-To: <20180730153933.3771-1-sven.eckelmann@openmesh.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sven Eckelmann , ath10k@lists.infradead.org Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-wireless@vger.kernel.org KyBSYWZhxYIKCk9uIDcvMzAvMjAxOCA1OjM5IFBNLCBTdmVuIEVja2VsbWFubiB3cm90ZToKPiBU cmktYmFuZCBkZXZpY2VzICgxeCAyLjRHSHogKyAyeCA1R0h6KSBvZnRlbiBpbmNvcnBvcmF0ZSBz cGVjaWFsIGZpbHRlcnMgaW4KPiB0aGUgUlggYW5kIFRYIHBhdGguIFRoZXNlIGZpbHRlcmVkIGNo YW5uZWwgY2FuIGluIHRoZW9yeSBzdGlsbCBiZSB1c2VkIGJ5Cj4gdGhlIGhhcmR3YXJlIGJ1dCB0 aGUgc2lnbmFsIHN0cmVuZ3RoIGlzIHJlZHVjZWQgc28gbXVjaCB0aGF0IGl0IG1ha2VzIG5vCj4g c2Vuc2UuCj4KPiBUaGVyZSBpcyBhbHJlYWR5IGEgRFQgcHJvcGVydHkgdG8gbGltaXQgdGhlIGF2 YWlsYWJsZSBjaGFubmVscyBidXQgYXRoMTBrCj4gaGFzIHRvIG1hbnVhbGx5IGNhbGwgdGhpcyBm dW5jdGlvbmFsaXR5IHRvIGxpbWl0IHRoZSBjdXJycmVudGx5IHNldCB3aXBoeQo+IGNoYW5uZWxz IGZ1cnRoZXIuCgpXb25kZXJpbmcgd2hldGhlciB3ZSBjYW4gY2FsbCBpdCBpbiB3aXBoeV9yZWdp c3RlcigpIGxpa2UgYmVsb3cuIE5vdCAKc3VyZSB3aHkgd2UgZGlkIG5vdCBleHBsb3JlIHRoYXQg d2l0aCB0aGUgaW50cm9kdWN0aW9uIG9mIGl0IGJ5IFJhZmHFgi4gCk1heWJlIGhlIHJlbWVtYmVy cy4gSSBkaWQgbm90IGZpbmQgc29tZXRoaW5nIGluIHRoYXQgZGlyZWN0aW9uIGluIApwYXRjaHdv cmssIGJ1dCBtYXkgaGF2ZSBtaXNzZWQgaXQuIEkga25vdyBtdDc2IGRyb3BzIHRoZSBiYW5kIHJl ZmVyZW5jZSAKaWYgaXQgZW5kcyB1cCB3aXRoIGFsbCBjaGFubmVscyBkaXNhYmxlZC4gTWF5YmUg dGhhdCB3YXMgdGhlIHJlYXNvbi4KClJlZ2FyZHMsCkFyZW5kCi0tLQpkaWZmIC0tZ2l0IGEvbmV0 L3dpcmVsZXNzL2NvcmUuYyBiL25ldC93aXJlbGVzcy9jb3JlLmMKaW5kZXggYTg4NTUxZi4uMmUw MGNiMSAxMDA2NDQKLS0tIGEvbmV0L3dpcmVsZXNzL2NvcmUuYworKysgYi9uZXQvd2lyZWxlc3Mv Y29yZS5jCkBAIC03NDIsNiArNzQyLDggQEAgaW50IHdpcGh5X3JlZ2lzdGVyKHN0cnVjdCB3aXBo eSAqd2lwaHkpCglpZiAocmVzKQoJCXJldHVybiByZXM7CgorCXdpcGh5X3JlYWRfb2ZfZnJlcV9s aW1pdHMod2lwaHkpOworCgkvKiBzYW5pdHkgY2hlY2sgc3VwcG9ydGVkIGJhbmRzL2NoYW5uZWxz ICovCglmb3IgKGJhbmQgPSAwOyBiYW5kIDwgTlVNX05MODAyMTFfQkFORFM7IGJhbmQrKykgewoJ CXUxNiB0eXBlcyA9IDA7CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-f65.google.com ([209.85.208.65]:46402 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729542AbeG3UbG (ORCPT ); Mon, 30 Jul 2018 16:31:06 -0400 Received: by mail-ed1-f65.google.com with SMTP id o8-v6so4547983edt.13 for ; Mon, 30 Jul 2018 11:54:45 -0700 (PDT) Subject: Re: [PATCH] ath10k: Limit available channels via DT ieee80211-freq-limit To: Sven Eckelmann , ath10k@lists.infradead.org References: <20180730153933.3771-1-sven.eckelmann@openmesh.com> Cc: linux-wireless@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= From: Arend van Spriel Message-ID: <5B5F5EF2.2050100@broadcom.com> (sfid-20180730_205448_682669_D0EF1E86) Date: Mon, 30 Jul 2018 20:54:42 +0200 MIME-Version: 1.0 In-Reply-To: <20180730153933.3771-1-sven.eckelmann@openmesh.com> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: + Rafał On 7/30/2018 5:39 PM, Sven Eckelmann wrote: > Tri-band devices (1x 2.4GHz + 2x 5GHz) often incorporate special filters in > the RX and TX path. These filtered channel can in theory still be used by > the hardware but the signal strength is reduced so much that it makes no > sense. > > There is already a DT property to limit the available channels but ath10k > has to manually call this functionality to limit the currrently set wiphy > channels further. Wondering whether we can call it in wiphy_register() like below. Not sure why we did not explore that with the introduction of it by Rafał. Maybe he remembers. I did not find something in that direction in patchwork, but may have missed it. I know mt76 drops the band reference if it ends up with all channels disabled. Maybe that was the reason. Regards, Arend --- diff --git a/net/wireless/core.c b/net/wireless/core.c index a88551f..2e00cb1 100644 --- a/net/wireless/core.c +++ b/net/wireless/core.c @@ -742,6 +742,8 @@ int wiphy_register(struct wiphy *wiphy) if (res) return res; + wiphy_read_of_freq_limits(wiphy); + /* sanity check supported bands/channels */ for (band = 0; band < NUM_NL80211_BANDS; band++) { u16 types = 0;