From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: BUG in slab_free after iSCSI login timeout
Date: Mon, 13 Aug 2018 19:48:03 +0000 [thread overview]
Message-ID: <5B71E073.5000105@redhat.com> (raw)
In-Reply-To: <20180811093655.42922d8e@gmail.com>
On 08/11/2018 10:51 PM, Vincent Pelletier wrote:
> On Sun, 12 Aug 2018 02:55:31 +0000, Vincent Pelletier
> <plr.vincent@gmail.com> wrote:
>> Aug 12 04:44:53 boke kernel: [ 64.737069] BUG: KASAN: use-after-free in iscsi_target_login_sess_out.cold.11+0x58/0x123 [iscsi_target_mod]
>> Aug 12 04:44:53 boke kernel: [ 64.771148] BUG: KASAN: double-free or invalid-free in iscsi_target_login_sess_out.cold.11+0x103/0x123 [iscsi_target_mod]
>
> If I'm reading the code correctly, the double-free would be
> iscsi_login_init_conn and iscsi_target_login_sess_out both calling
> kfree(conn->conn_ops), with the latter called by
> __iscsi_target_login_thread precisely when the former fails (returns
> NULL after freeing).
>
I think I fixed that with this patch:
https://www.spinics.net/lists/target-devel/msg17018.html
It fixes a mix of problems double free of the ops, session and reference
after free.
next prev parent reply other threads:[~2018-08-13 19:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 9:36 BUG in slab_free after iSCSI login timeout Vincent Pelletier
2018-08-11 22:50 ` Bart Van Assche
2018-08-12 2:55 ` Vincent Pelletier
2018-08-12 3:51 ` Vincent Pelletier
2018-08-12 4:01 ` Vincent Pelletier
2018-08-13 19:48 ` Mike Christie [this message]
2018-08-13 21:42 ` Mike Christie
2018-08-13 22:54 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B71E073.5000105@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.