From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH libdrm 2/2] amdgpu: Use char* pointers in amdgpu_find_bo_by_cpu_mapping Date: Wed, 15 Aug 2018 09:07:02 +0800 Message-ID: <5B737CB6.5010207@amd.com> References: <20180814095848.10981-1-michel@daenzer.net> <20180814095848.10981-2-michel@daenzer.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180814095848.10981-2-michel-otUistvHUpPR7s880joybQ@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMDgvMTQvMjAxOCAwNTo1OCBQTSwgTWljaGVsIETDpG56ZXIgd3JvdGU6Cj4gRnJvbTogTWlj aGVsIETDpG56ZXIgPG1pY2hlbC5kYWVuemVyQGFtZC5jb20+Cj4KPiBBcml0aG1ldGljIHVzaW5n IHZvaWQqIHBvaW50ZXJzIGlzbid0IGRlZmluZWQgYnkgdGhlIEMgc3RhbmRhcmQsIG9ubHkgYXMK PiBhIEdDQyBleHRlbnNpb24uIEF2b2lkcyBjb21waWxlciB3YXJuaW5nczoKPgo+IC4uLy4uL2Ft ZGdwdS9hbWRncHVfYm8uYzogSW4gZnVuY3Rpb24g4oCYYW1kZ3B1X2ZpbmRfYm9fYnlfY3B1X21h cHBpbmfigJk6Cj4gLi4vLi4vYW1kZ3B1L2FtZGdwdV9iby5jOjU1NDo0ODogd2FybmluZzogcG9p bnRlciBvZiB0eXBlIOKAmHZvaWQgKuKAmSB1c2VkIGluIGFyaXRobWV0aWMgWy1XcG9pbnRlci1h cml0aF0KPiAgICAgaWYgKGNwdSA+PSBiby0+Y3B1X3B0ciAmJiBjcHUgPCAoYm8tPmNwdV9wdHIg KyBiby0+YWxsb2Nfc2l6ZSkpCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF4KPiAuLi8uLi9hbWRncHUvYW1kZ3B1X2JvLmM6NTYxOjIzOiB3YXJuaW5n OiBwb2ludGVyIG9mIHR5cGUg4oCYdm9pZCAq4oCZIHVzZWQgaW4gc3VidHJhY3Rpb24gWy1XcG9p bnRlci1hcml0aF0KPiAgICAgKm9mZnNldF9pbl9ibyA9IGNwdSAtIGJvLT5jcHVfcHRyOwo+ICAg ICAgICAgICAgICAgICAgICAgICAgIF4KPgo+IEZpeGVzOiA0ZDQ1NDQyNGUxZjIgKCJhbWRncHU6 IGFkZCBhIGZ1bmN0aW9uIHRvIGZpbmQgYm8gYnkgY3B1IG1hcHBpbmcKPiAgICAgICAgICAgICAg ICAgICAgICAgKHYyKSIpCj4gU2lnbmVkLW9mZi1ieTogTWljaGVsIETDpG56ZXIgPG1pY2hlbC5k YWVuemVyQGFtZC5jb20+Cj4gLS0tCj4gICBhbWRncHUvYW1kZ3B1LmggICAgfCAyICstCj4gICBh bWRncHUvYW1kZ3B1X2JvLmMgfCA3ICsrKystLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2FtZGdwdS9hbWRncHUu aCBiL2FtZGdwdS9hbWRncHUuaAo+IGluZGV4IGE4YzM1M2M2Li5mMmJkZWI5NSAxMDA2NDQKPiAt LS0gYS9hbWRncHUvYW1kZ3B1LmgKPiArKysgYi9hbWRncHUvYW1kZ3B1LmgKPiBAQCAtNjk1LDcg KzY5NSw3IEBAIGludCBhbWRncHVfY3JlYXRlX2JvX2Zyb21fdXNlcl9tZW0oYW1kZ3B1X2Rldmlj ZV9oYW5kbGUgZGV2LAo+ICAgICoKPiAgICovCj4gICBpbnQgYW1kZ3B1X2ZpbmRfYm9fYnlfY3B1 X21hcHBpbmcoYW1kZ3B1X2RldmljZV9oYW5kbGUgZGV2LAo+IC0JCQkJICB2b2lkICpjcHUsCj4g KwkJCQkgIGNoYXIgKmNwdSwKClNoYWxsIHdlIGNhc3QgdGhlIGNwdSBwb2ludGVyIHdoZW4gZG8g YXJpdGhtZXRpYyBhbmQga2VlcCB0aGUgYXJndW1lbnRzIGFzIG90aGVyIGNwdSBwb250ZXI/Cgpl LmcuCkBAIC01NjUsMTQgKzU2NSwxNSBAQCBpbnQgYW1kZ3B1X2ZpbmRfYm9fYnlfY3B1X21hcHBp bmcoYW1kZ3B1X2RldmljZV9oYW5kbGUgZGV2LAogICAgICAgICAgICAgICAgIGJvID0gaGFuZGxl X3RhYmxlX2xvb2t1cCgmZGV2LT5ib19oYW5kbGVzLCBpKTsKICAgICAgICAgICAgICAgICBpZiAo IWJvIHx8ICFiby0+Y3B1X3B0ciB8fCBzaXplID4gYm8tPmFsbG9jX3NpemUpCiAgICAgICAgICAg ICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgICAgICAgIGlmIChjcHUgPj0gYm8tPmNw dV9wdHIgJiYgY3B1IDwgKGJvLT5jcHVfcHRyICsgYm8tPmFsbG9jX3NpemUpKQorICAgICAgICAg ICAgICAgaWYgKGNwdSA+PSBiby0+Y3B1X3B0ciAmJgorICAgICAgICAgICAgICAgICAgKHVpbnQ2 NF90KWNwdSA8ICgodWludDY0X3QpYm8tPmNwdV9wdHIgKyBiby0+YWxsb2Nfc2l6ZSkpCiAgICAg ICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQoKICAgICAgICAgaWYgKGkgPCBk ZXYtPmJvX2hhbmRsZXMubWF4X2tleSkgewogICAgICAgICAgICAgICAgIGF0b21pY19pbmMoJmJv LT5yZWZjb3VudCk7CiAgICAgICAgICAgICAgICAgKmJ1Zl9oYW5kbGUgPSBibzsKLSAgICAgICAg ICAgICAgICpvZmZzZXRfaW5fYm8gPSBjcHUgLSBiby0+Y3B1X3B0cjsKKyAgICAgICAgICAgICAg ICpvZmZzZXRfaW5fYm8gPSAodWludDY0X3QpY3B1IC0gKHVpbnQ2NF90KWJvLT5jcHVfcHRyOwog ICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICpidWZfaGFuZGxlID0gTlVMTDsKICAg ICAgICAgICAgICAgICAqb2Zmc2V0X2luX2JvID0gMDsKClJlZ2FyZHMsCkplcnJ5Cgo+ICAgCQkJ CSAgdWludDY0X3Qgc2l6ZSwKPiAgIAkJCQkgIGFtZGdwdV9ib19oYW5kbGUgKmJ1Zl9oYW5kbGUs Cj4gICAJCQkJICB1aW50NjRfdCAqb2Zmc2V0X2luX2JvKTsKPiBkaWZmIC0tZ2l0IGEvYW1kZ3B1 L2FtZGdwdV9iby5jIGIvYW1kZ3B1L2FtZGdwdV9iby5jCj4gaW5kZXggODZkMWMxNDMuLmVmNzVm MWQwIDEwMDY0NAo+IC0tLSBhL2FtZGdwdS9hbWRncHVfYm8uYwo+ICsrKyBiL2FtZGdwdS9hbWRn cHVfYm8uYwo+IEBAIC01MzAsNyArNTMwLDcgQEAgaW50IGFtZGdwdV9ib193YWl0X2Zvcl9pZGxl KGFtZGdwdV9ib19oYW5kbGUgYm8sCj4gICB9Cj4KPiAgIGludCBhbWRncHVfZmluZF9ib19ieV9j cHVfbWFwcGluZyhhbWRncHVfZGV2aWNlX2hhbmRsZSBkZXYsCj4gLQkJCQkgIHZvaWQgKmNwdSwK PiArCQkJCSAgY2hhciAqY3B1LAo+ICAgCQkJCSAgdWludDY0X3Qgc2l6ZSwKPiAgIAkJCQkgIGFt ZGdwdV9ib19oYW5kbGUgKmJ1Zl9oYW5kbGUsCj4gICAJCQkJICB1aW50NjRfdCAqb2Zmc2V0X2lu X2JvKQo+IEBAIC01NTEsMTQgKzU1MSwxNSBAQCBpbnQgYW1kZ3B1X2ZpbmRfYm9fYnlfY3B1X21h cHBpbmcoYW1kZ3B1X2RldmljZV9oYW5kbGUgZGV2LAo+ICAgCQlibyA9IGhhbmRsZV90YWJsZV9s b29rdXAoJmRldi0+Ym9faGFuZGxlcywgaSk7Cj4gICAJCWlmICghYm8gfHwgIWJvLT5jcHVfcHRy IHx8IHNpemUgPiBiby0+YWxsb2Nfc2l6ZSkKPiAgIAkJCWNvbnRpbnVlOwo+IC0JCWlmIChjcHUg Pj0gYm8tPmNwdV9wdHIgJiYgY3B1IDwgKGJvLT5jcHVfcHRyICsgYm8tPmFsbG9jX3NpemUpKQo+ ICsJCWlmIChjcHUgPj0gKGNoYXIqKWJvLT5jcHVfcHRyICYmCj4gKwkJICAgIGNwdSA8ICgoY2hh ciopYm8tPmNwdV9wdHIgKyBiby0+YWxsb2Nfc2l6ZSkpCj4gICAJCQlicmVhazsKPiAgIAl9Cj4K PiAgIAlpZiAoaSA8IGRldi0+Ym9faGFuZGxlcy5tYXhfa2V5KSB7Cj4gICAJCWF0b21pY19pbmMo JmJvLT5yZWZjb3VudCk7Cj4gICAJCSpidWZfaGFuZGxlID0gYm87Cj4gLQkJKm9mZnNldF9pbl9i byA9IGNwdSAtIGJvLT5jcHVfcHRyOwo+ICsJCSpvZmZzZXRfaW5fYm8gPSBjcHUgLSAoY2hhciop Ym8tPmNwdV9wdHI7Cj4gICAJfSBlbHNlIHsKPiAgIAkJKmJ1Zl9oYW5kbGUgPSBOVUxMOwo+ICAg CQkqb2Zmc2V0X2luX2JvID0gMDsKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ft ZC1nZngK