From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Jia-Shyr Chuang <saint.chuang@cypress.com>
Subject: Re: [PATCH] Add CYW89342 mini-PCIe device
Date: Wed, 15 Aug 2018 11:14:59 +0200 [thread overview]
Message-ID: <5B73EF13.9000207@broadcom.com> (raw)
In-Reply-To: <1534323982-49462-1-git-send-email-chi-hsien.lin@cypress.com>
On 8/15/2018 11:06 AM, Chi-Hsien Lin wrote:
> From: Jia-Shyr Chuang <saint.chuang@cypress.com>
>
> CYW89342 is a 2x2 MIMO, 802.11a/b/g/n/ac, SDIO 3.0 and PCIe 3.0 for
> WLAN. It is a member of 4355/4359 family.
So the device support SDIO, but this patch only adds the PCIe variant.
The subject mentions that already, but mentioning SDIO in the commit
message may confuse people. I would just drop the host interface
references, ie. SDIO and PCIe from the commit message.
Regards,
Arend
> Signed-off-by: Jia-Shyr Chuang <saint.chuang@cypress.com>
> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 +
> 1 file changed, 1 insertion(+)
next prev parent reply other threads:[~2018-08-15 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 9:06 [PATCH] Add CYW89342 mini-PCIe device Chi-Hsien Lin
2018-08-15 9:14 ` Arend van Spriel [this message]
2018-08-15 9:16 ` Arend van Spriel
2018-08-15 9:29 ` Chi-Hsien Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B73EF13.9000207@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=saint.chuang@cypress.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.