From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Date: Wed, 15 Aug 2018 15:59:33 +0000 Subject: Re: iscsi target: Set conn->sess to NULL when iscsi_login_set_conn_values fails Message-Id: <5B744DE5.4060405@redhat.com> List-Id: References: <009ea1a88311492e651c38ae946f785961a7e1a7.1534328354.git.plr.vincent@gmail.com> In-Reply-To: <009ea1a88311492e651c38ae946f785961a7e1a7.1534328354.git.plr.vincent@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1258" Content-Transfer-Encoding: base64 To: target-devel@vger.kernel.org T24gMDgvMTUvMjAxOCAwNToxOSBBTSwgVmluY2VudCBQZWxsZXRpZXIgd3JvdGU6Cj4gRml4ZXMg YSB1c2UtYWZ0ZXItZnJlZSByZXBvcnRlZCBieSBLQVNBTiB3aGVuIGxhdGVyCj4gaXNjc2lfdGFy Z2V0X2xvZ2luX3Nlc3Nfb3V0IGdldHMgY2FsbGVkIGFuZCBpdCB0cmllcyB0byBhY2Nlc3MKPiBj b25uLT5zZXNzLT5zZV9zZXNzOgo+IAo+IERpc2FibGluZyBsb2NrIGRlYnVnZ2luZyBkdWUgdG8g a2VybmVsIHRhaW50Cj4gaVNDU0kgTG9naW4gdGltZW91dCBvbiBOZXR3b3JrIFBvcnRhbCBbOjpd OjMyNjAKPiBpU0NTSSBMb2dpbiBuZWdvdGlhdGlvbiBmYWlsZWQuCj4gPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Cj4gQlVHOiBLQVNBTjogdXNlLWFmdGVyLWZyZWUgaW4gaXNjc2lf dGFyZ2V0X2xvZ2luX3Nlc3Nfb3V0LmNvbGQuMTIrMHg1OC8weGZmIFtpc2NzaV90YXJnZXRfbW9k XQo+IFJlYWQgb2Ygc2l6ZSA4IGF0IGFkZHIgZmZmZjg4MDEwOWQwNzBjOCBieSB0YXNrIGlzY3Np X25wLzk4MAo+IAo+IENQVTogMSBQSUQ6IDk4MCBDb21tOiBpc2NzaV9ucCBUYWludGVkOiBHICAg ICAgICAgICBPICAgICAgNC4xNy44a2FzYW4uc2Vzcy5jb25ub3BzKyAjNAo+IEhhcmR3YXJlIG5h bWU6IFRvIGJlIGZpbGxlZCBieSBPLkUuTS4gVG8gYmUgZmlsbGVkIGJ5IE8uRS5NLi9BcHRpbyBD UkIsIEJJT1MgNS42LjUgMDUvMTkvMjAxNAo+IENhbGwgVHJhY2U6Cj4gIGR1bXBfc3RhY2srMHg3 MS8weGFjCj4gIHByaW50X2FkZHJlc3NfZGVzY3JpcHRpb24rMHg2NS8weDIyZQo+ICA/IGlzY3Np X3RhcmdldF9sb2dpbl9zZXNzX291dC5jb2xkLjEyKzB4NTgvMHhmZiBbaXNjc2lfdGFyZ2V0X21v ZF0KPiAga2FzYW5fcmVwb3J0LmNvbGQuNisweDI0MS8weDJmZAo+ICBpc2NzaV90YXJnZXRfbG9n aW5fc2Vzc19vdXQuY29sZC4xMisweDU4LzB4ZmYgW2lzY3NpX3RhcmdldF9tb2RdCj4gIGlzY3Np X3RhcmdldF9sb2dpbl90aHJlYWQrMHgxMDg2LzB4MTcxMCBbaXNjc2lfdGFyZ2V0X21vZF0KPiAg PyBfX3NjaGVkX3RleHRfc3RhcnQrMHg4LzB4OAo+ICA/IGlzY3NpX3RhcmdldF9sb2dpbl9zZXNz X291dCsweDI1MC8weDI1MCBbaXNjc2lfdGFyZ2V0X21vZF0KPiAgPyBfX2t0aHJlYWRfcGFya21l KzB4Y2MvMHgxMDAKPiAgPyBwYXJzZV9hcmdzLmNvbGQuMTQrMHhkMy8weGQzCj4gID8gaXNjc2lf dGFyZ2V0X2xvZ2luX3Nlc3Nfb3V0KzB4MjUwLzB4MjUwIFtpc2NzaV90YXJnZXRfbW9kXQo+ICBr dGhyZWFkKzB4MWEwLzB4MWMwCj4gID8ga3RocmVhZF9iaW5kKzB4MzAvMHgzMAo+ICByZXRfZnJv bV9mb3JrKzB4MzUvMHg0MAo+IAo+IEFsbG9jYXRlZCBieSB0YXNrIDk4MDoKPiAga2FzYW5fa21h bGxvYysweGJmLzB4ZTAKPiAga21lbV9jYWNoZV9hbGxvY190cmFjZSsweDExMi8weDIxMAo+ICBp c2NzaV90YXJnZXRfbG9naW5fdGhyZWFkKzB4ODE2LzB4MTcxMCBbaXNjc2lfdGFyZ2V0X21vZF0K PiAga3RocmVhZCsweDFhMC8weDFjMAo+ICByZXRfZnJvbV9mb3JrKzB4MzUvMHg0MAo+IAo+IEZy ZWVkIGJ5IHRhc2sgOTgwOgo+ICBfX2thc2FuX3NsYWJfZnJlZSsweDEyNS8weDE3MAo+ICBrZnJl ZSsweDkwLzB4MWQwCj4gIGlzY3NpX3RhcmdldF9sb2dpbl90aHJlYWQrMHgxNTc3LzB4MTcxMCBb aXNjc2lfdGFyZ2V0X21vZF0KPiAga3RocmVhZCsweDFhMC8weDFjMAo+ICByZXRfZnJvbV9mb3Jr KzB4MzUvMHg0MAo+IAo+IFRoZSBidWdneSBhZGRyZXNzIGJlbG9uZ3MgdG8gdGhlIG9iamVjdCBh dCBmZmZmODgwMTA5ZDA2ZjAwCj4gIHdoaWNoIGJlbG9uZ3MgdG8gdGhlIGNhY2hlIGttYWxsb2Mt NTEyIG9mIHNpemUgNTEyCj4gVGhlIGJ1Z2d5IGFkZHJlc3MgaXMgbG9jYXRlZCA0NTYgYnl0ZXMg aW5zaWRlIG9mCj4gIDUxMi1ieXRlIHJlZ2lvbiBbZmZmZjg4MDEwOWQwNmYwMCwgZmZmZjg4MDEw OWQwNzEwMCkKPiBUaGUgYnVnZ3kgYWRkcmVzcyBiZWxvbmdzIHRvIHRoZSBwYWdlOgo+IHBhZ2U6 ZmZmZmVhMDAwNDI3NDE4MCBjb3VudDoxIG1hcGNvdW50OjAgbWFwcGluZzowMDAwMDAwMDAwMDAw MDAwIGluZGV4OjB4MCBjb21wb3VuZF9tYXBjb3VudDogMAo+IGZsYWdzOiAweDE3ZmZmYzAwMDAw ODEwMChzbGFifGhlYWQpCj4gcmF3OiAwMTdmZmZjMDAwMDA4MTAwIDAwMDAwMDAwMDAwMDAwMDAg MDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMTAwMGMwMDBjCj4gcmF3OiBkZWFkMDAwMDAwMDAwMTAw IGRlYWQwMDAwMDAwMDAyMDAgZmZmZjg4MDExYjAwMmUwMCAwMDAwMDAwMDAwMDAwMDAwCj4gcGFn ZSBkdW1wZWQgYmVjYXVzZToga2FzYW46IGJhZCBhY2Nlc3MgZGV0ZWN0ZWQKPiAKPiBNZW1vcnkg c3RhdGUgYXJvdW5kIHRoZSBidWdneSBhZGRyZXNzOgo+ICBmZmZmODgwMTA5ZDA2ZjgwOiBmYiBm YiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYgo+ICBmZmZmODgwMTA5 ZDA3MDAwOiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYgo+ PiBmZmZmODgwMTA5ZDA3MDgwOiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBmYiBm YiBmYiBmYiBmYgo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBeCj4gIGZmZmY4ODAxMDlkMDcxMDA6IGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZjIGZj IGZjIGZjIGZjIGZjIGZjCj4gIGZmZmY4ODAxMDlkMDcxODA6IDAwIDAwIDAwIDAwIDAwIDAwIDAw IDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwCj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Cj4gCj4gU2lnbmVkLW9mZi1ieTogVmluY2VudCBQZWxsZXRpZXIgPHBsci52aW5jZW50 QGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy90YXJnZXQvaXNjc2kvaXNjc2lfdGFyZ2V0X2xv Z2luLmMgfCA5ICsrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA1 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3RhcmdldC9pc2NzaS9pc2Nz aV90YXJnZXRfbG9naW4uYyBiL2RyaXZlcnMvdGFyZ2V0L2lzY3NpL2lzY3NpX3RhcmdldF9sb2dp bi5jCj4gaW5kZXggZGY4MWIyZjdjYWQ5Li5jOTVmNDI2MWEwODkgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy90YXJnZXQvaXNjc2kvaXNjc2lfdGFyZ2V0X2xvZ2luLmMKPiArKysgYi9kcml2ZXJzL3Rh cmdldC9pc2NzaS9pc2NzaV90YXJnZXRfbG9naW4uYwo+IEBAIC0yOTYsMTAgKzI5Niw4IEBAIHN0 YXRpYyBpbnQgaXNjc2lfbG9naW5femVyb190c2loX3MxKAo+ICAJfQo+ICAKPiAgCXJldCA9IGlz Y3NpX2xvZ2luX3NldF9jb25uX3ZhbHVlcyhzZXNzLCBjb25uLCBwZHUtPmNpZCk7Cj4gLQlpZiAo dW5saWtlbHkocmV0KSkgewo+IC0JCWtmcmVlKHNlc3MpOwo+IC0JCXJldHVybiByZXQ7Cj4gLQl9 Cj4gKwlpZiAodW5saWtlbHkocmV0KSkKPiArCQlnb3RvIGZyZWVfc2VzczsKPiAgCXNlc3MtPmlu aXRfdGFza190YWcJPSBwZHUtPml0dDsKPiAgCW1lbWNweSgmc2Vzcy0+aXNpZCwgcGR1LT5pc2lk LCA2KTsKPiAgCXNlc3MtPmV4cF9jbWRfc24JPSBiZTMyX3RvX2NwdShwZHUtPmNtZHNuKTsKPiBA QCAtMzMzLDYgKzMzMSw3IEBAIHN0YXRpYyBpbnQgaXNjc2lfbG9naW5femVyb190c2loX3MxKAo+ ICAJCXByX2VycigiaWRyX2FsbG9jKCkgZm9yIHNlc3NfaWRyIGZhaWxlZFxuIik7Cj4gIAkJaXNj c2l0X3R4X2xvZ2luX3JzcChjb25uLCBJU0NTSV9TVEFUVVNfQ0xTX1RBUkdFVF9FUlIsCj4gIAkJ CQlJU0NTSV9MT0dJTl9TVEFUVVNfTk9fUkVTT1VSQ0VTKTsKPiArCQlyZXQgPSAtRU5PTUVNOwo+ ICAJCWdvdG8gZnJlZV9zZXNzOwo+ICAJfQo+ICAKPiBAQCAtMzcwLDcgKzM2OSw3IEBAIHN0YXRp YyBpbnQgaXNjc2lfbG9naW5femVyb190c2loX3MxKAo+ICBmcmVlX3Nlc3M6Cj4gIAlrZnJlZShz ZXNzKTsKPiAgCWNvbm4tPnNlc3MgPSBOVUxMOwo+IC0JcmV0dXJuIC1FTk9NRU07Cj4gKwlyZXR1 cm4gcmV0Owo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGlzY3NpX2xvZ2luX3plcm9fdHNpaF9zMigK PiAKClJldmlld2VkLWJ5OiBNaWtlIENocmlzdGllIDxtY2hyaXN0aUByZWRoYXQuY29tPgoKTWFy dGluLCB0aGlzIHdhcyBtYWRlIG92ZXIgdGhhdCBwYXRjaCB0aGF0IHdhcyBnb2luZyB0aHJvdWdo IE1hdGhldydzCnRyZWUuIEl0IGlzIGluIG5leHQgaGVyZQoKaHR0cHM6Ly9naXQua2VybmVsLm9y Zy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvbmV4dC9saW51eC1uZXh0LmdpdC9jb21taXQvZHJp dmVycy90YXJnZXQvaXNjc2k/aWStODYzNTNjYmRkYmI2ZjFjOTUwNzJlYWQ3NDRkNTQ3YTlhYzgy MTEK