From: Mike Christie <mchristi@redhat.com>
To: target-devel@vger.kernel.org
Subject: Re: iscsi target: Let initiator decide whether it wants to authenticate target
Date: Thu, 16 Aug 2018 05:00:35 +0000 [thread overview]
Message-ID: <5B7504F3.1000903@redhat.com> (raw)
In-Reply-To: <97479a0ccf17d8ad7a8ba7a0f7e8190da6ddc72e.1534334933.git.plr.vincent@gmail.com>
On 08/15/2018 07:08 AM, Vincent Pelletier wrote:
> Do not fail authentication after target is happy with initiator's
> credentials, when target is configured to authenticate itself to an
> initiator but current initiator did not provide required values.
> Also, downgrade "Could not find CHAP_I." to a debug level message, as it
> will happen normally in such case.
>
I just worry some users have set this and expect the extra layer of
checks. I can see how it is more convenient though. I think this is
something I really am not sure about because I have not worked on the
code for a long time. It is better if Nick were around.
I saw some targets/initiators allow you to configure this type of thing
as optional where in that mode it works like in your patch. What about that?
I guess you can wait for other reviewers or maybe some distro packagers
to chime in too.
next prev parent reply other threads:[~2018-08-16 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 12:08 iscsi target: Let initiator decide whether it wants to authenticate target Vincent Pelletier
2018-08-16 5:00 ` Mike Christie [this message]
2018-08-16 12:11 ` Vincent Pelletier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B7504F3.1000903@redhat.com \
--to=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.