From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-block-owner@vger.kernel.org>
Received: from szxga06-in.huawei.com ([45.249.212.32]:50370 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1725891AbeHRJXw (ORCPT <rfc822;linux-block@vger.kernel.org>);
        Sat, 18 Aug 2018 05:23:52 -0400
Message-ID: <5B77B9EB.9000700@huawei.com>
Date: Sat, 18 Aug 2018 14:17:15 +0800
From: zhong jiang <zhongjiang@huawei.com>
MIME-Version: 1.0
To: <axboe@kernel.dk>
CC: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Use NULL to compare with pointer-typed value rather
 than 0
References: <1534512473-39710-1-git-send-email-zhongjiang@huawei.com>
In-Reply-To: <1534512473-39710-1-git-send-email-zhongjiang@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
Sender: linux-block-owner@vger.kernel.org
List-Id: linux-block@vger.kernel.org

On 2018/8/17 21:27, zhong jiang wrote:
> We should use NULL to compare with pointer-typed value rather than
> 0. The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/block/ataflop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
> index dfb2c26..cca93e3 100644
> --- a/drivers/block/ataflop.c
> +++ b/drivers/block/ataflop.c
> @@ -1355,7 +1355,7 @@ static int floppy_revalidate(struct gendisk *disk)
>  
>  	if (test_bit(drive, &changed_floppies) ||
>  	    test_bit(drive, &fake_change) ||
> -	    p->disktype == 0) {
> +	    p->disktype == NULL) {
>  		if (UD.flags & FTD_MSG)
>  			printk(KERN_ERR "floppy: clear format %p!\n", UDT);
>  		BufferDrive = -1;
 Maybe if  (!p->disktype) is better,  So will change it in v2.

Thanks,
zhong jiang