From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Jerry (Junwei)" Subject: Re: [PATCH 10/11] drm/amdgpu: add helper for VM PD/PT allocation parameters Date: Thu, 23 Aug 2018 11:19:09 +0800 Message-ID: <5B7E27AD.4040407@amd.com> References: <20180822150517.2330-1-christian.koenig@amd.com> <20180822150517.2330-10-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180822150517.2330-10-christian.koenig-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gMDgvMjIvMjAxOCAxMTowNSBQTSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBBZGQgYSBo ZWxwZXIgZnVuY3Rpb24gdG8gZmlndXJlIHRoZW0gb3V0IG9ubHkgb25jZS4KPgo+IFNpZ25lZC1v ZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KUmV2aWV3 ZWQtYnk6IEp1bndlaSBaaGFuZyA8SmVycnkuWmhhbmdAYW1kLmNvbT4KCj4gLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyB8IDYxICsrKysrKysrKysrKy0tLS0t LS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRp b25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3ZtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+IGluZGV4IDg3 ZTNkNDRiMGEzZi4uOTI4ZmRhZTBkYWI0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV92bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1X3ZtLmMKPiBAQCAtNDQ2LDYgKzQ0NiwzMSBAQCBzdGF0aWMgaW50IGFtZGdwdV92bV9j bGVhcl9ibyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgIAlyZXR1cm4gcjsKPiAgIH0K Pgo+ICsvKioKPiArICogYW1kZ3B1X3ZtX2JvX3BhcmFtIC0gZmlsbCBpbiBwYXJhbWV0ZXJzIGZv ciBQRC9QVCBhbGxvY2F0aW9uCj4gKyAqCj4gKyAqIEBhZGV2OiBhbWRncHVfZGV2aWNlIHBvaW50 ZXIKPiArICogQHZtOiByZXF1ZXN0aW5nIHZtCj4gKyAqIEBicDogcmVzdWx0aW5nIEJPIGFsbG9j YXRpb24gcGFyYW1ldGVycwo+ICsgKi8KPiArc3RhdGljIHZvaWQgYW1kZ3B1X3ZtX2JvX3BhcmFt KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCBzdHJ1Y3QgYW1kZ3B1X3ZtICp2bSwKPiArCQkJ ICAgICAgIGludCBsZXZlbCwgc3RydWN0IGFtZGdwdV9ib19wYXJhbSAqYnApCj4gK3sKPiArCW1l bXNldCgmYnAsIDAsIHNpemVvZihicCkpOwo+ICsKPiArCWJwLT5zaXplID0gYW1kZ3B1X3ZtX2Jv X3NpemUoYWRldiwgbGV2ZWwpOwo+ICsJYnAtPmJ5dGVfYWxpZ24gPSBBTURHUFVfR1BVX1BBR0Vf U0laRTsKPiArCWJwLT5kb21haW4gPSBBTURHUFVfR0VNX0RPTUFJTl9WUkFNOwo+ICsJYnAtPmZs YWdzID0gQU1ER1BVX0dFTV9DUkVBVEVfVlJBTV9DT05USUdVT1VTOwo+ICsJaWYgKHZtLT51c2Vf Y3B1X2Zvcl91cGRhdGUpCj4gKwkJYnAtPmZsYWdzIHw9IEFNREdQVV9HRU1fQ1JFQVRFX0NQVV9B Q0NFU1NfUkVRVUlSRUQ7Cj4gKwllbHNlCj4gKwkJYnAtPmZsYWdzIHw9IEFNREdQVV9HRU1fQ1JF QVRFX1NIQURPVzsKPiArCWJwLT50eXBlID0gdHRtX2JvX3R5cGVfa2VybmVsOwo+ICsJaWYgKHZt LT5yb290LmJhc2UuYm8pCj4gKwkJYnAtPnJlc3YgPSB2bS0+cm9vdC5iYXNlLmJvLT50Ym8ucmVz djsKPiArfQo+ICsKPiAgIC8qKgo+ICAgICogYW1kZ3B1X3ZtX2FsbG9jX2xldmVscyAtIGFsbG9j YXRlIHRoZSBQRC9QVCBsZXZlbHMKPiAgICAqCj4gQEAgLTQ2OSw4ICs0OTQsOCBAQCBzdGF0aWMg aW50IGFtZGdwdV92bV9hbGxvY19sZXZlbHMoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4g ICAJCQkJICB1bnNpZ25lZCBsZXZlbCwgYm9vbCBhdHMpCj4gICB7Cj4gICAJdW5zaWduZWQgc2hp ZnQgPSBhbWRncHVfdm1fbGV2ZWxfc2hpZnQoYWRldiwgbGV2ZWwpOwo+ICsJc3RydWN0IGFtZGdw dV9ib19wYXJhbSBicDsKPiAgIAl1bnNpZ25lZCBwdF9pZHgsIGZyb20sIHRvOwo+IC0JdTY0IGZs YWdzOwo+ICAgCWludCByOwo+Cj4gICAJaWYgKCFwYXJlbnQtPmVudHJpZXMpIHsKPiBAQCAtNDk0 LDI5ICs1MTksMTQgQEAgc3RhdGljIGludCBhbWRncHVfdm1fYWxsb2NfbGV2ZWxzKHN0cnVjdCBh bWRncHVfZGV2aWNlICphZGV2LAo+ICAgCXNhZGRyID0gc2FkZHIgJiAoKDEgPDwgc2hpZnQpIC0g MSk7Cj4gICAJZWFkZHIgPSBlYWRkciAmICgoMSA8PCBzaGlmdCkgLSAxKTsKPgo+IC0JZmxhZ3Mg PSBBTURHUFVfR0VNX0NSRUFURV9WUkFNX0NPTlRJR1VPVVM7Cj4gLQlpZiAodm0tPnVzZV9jcHVf Zm9yX3VwZGF0ZSkKPiAtCQlmbGFncyB8PSBBTURHUFVfR0VNX0NSRUFURV9DUFVfQUNDRVNTX1JF UVVJUkVEOwo+IC0JZWxzZQo+IC0JCWZsYWdzIHw9IChBTURHUFVfR0VNX0NSRUFURV9OT19DUFVf QUNDRVNTIHwKPiAtCQkJCUFNREdQVV9HRU1fQ1JFQVRFX1NIQURPVyk7Cj4gKwlhbWRncHVfdm1f Ym9fcGFyYW0oYWRldiwgdm0sIGxldmVsLCAmYnApOwo+Cj4gICAJLyogd2FsayBvdmVyIHRoZSBh ZGRyZXNzIHNwYWNlIGFuZCBhbGxvY2F0ZSB0aGUgcGFnZSB0YWJsZXMgKi8KPiAgIAlmb3IgKHB0 X2lkeCA9IGZyb207IHB0X2lkeCA8PSB0bzsgKytwdF9pZHgpIHsKPiAtCQlzdHJ1Y3QgcmVzZXJ2 YXRpb25fb2JqZWN0ICpyZXN2ID0gdm0tPnJvb3QuYmFzZS5iby0+dGJvLnJlc3Y7Cj4gICAJCXN0 cnVjdCBhbWRncHVfdm1fcHQgKmVudHJ5ID0gJnBhcmVudC0+ZW50cmllc1twdF9pZHhdOwo+ICAg CQlzdHJ1Y3QgYW1kZ3B1X2JvICpwdDsKPgo+ICAgCQlpZiAoIWVudHJ5LT5iYXNlLmJvKSB7Cj4g LQkJCXN0cnVjdCBhbWRncHVfYm9fcGFyYW0gYnA7Cj4gLQo+IC0JCQltZW1zZXQoJmJwLCAwLCBz aXplb2YoYnApKTsKPiAtCQkJYnAuc2l6ZSA9IGFtZGdwdV92bV9ib19zaXplKGFkZXYsIGxldmVs KTsKPiAtCQkJYnAuYnl0ZV9hbGlnbiA9IEFNREdQVV9HUFVfUEFHRV9TSVpFOwo+IC0JCQlicC5k b21haW4gPSBBTURHUFVfR0VNX0RPTUFJTl9WUkFNOwo+IC0JCQlicC5mbGFncyA9IGZsYWdzOwo+ IC0JCQlicC50eXBlID0gdHRtX2JvX3R5cGVfa2VybmVsOwo+IC0JCQlicC5yZXN2ID0gcmVzdjsK PiAgIAkJCXIgPSBhbWRncHVfYm9fY3JlYXRlKGFkZXYsICZicCwgJnB0KTsKPiAgIAkJCWlmIChy KQo+ICAgCQkJCXJldHVybiByOwo+IEBAIC0yNTY0LDggKzI1NzQsNiBAQCBpbnQgYW1kZ3B1X3Zt X2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHN0cnVjdCBhbWRncHVfdm0gKnZtLAo+ ICAgewo+ICAgCXN0cnVjdCBhbWRncHVfYm9fcGFyYW0gYnA7Cj4gICAJc3RydWN0IGFtZGdwdV9i byAqcm9vdDsKPiAtCXVuc2lnbmVkIGxvbmcgc2l6ZTsKPiAtCXVpbnQ2NF90IGZsYWdzOwo+ICAg CWludCByLCBpOwo+Cj4gICAJdm0tPnZhID0gUkJfUk9PVF9DQUNIRUQ7Cj4gQEAgLTI2MDIsMjAg KzI2MTAsNyBAQCBpbnQgYW1kZ3B1X3ZtX2luaXQoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYs IHN0cnVjdCBhbWRncHVfdm0gKnZtLAo+ICAgCQkgICJDUFUgdXBkYXRlIG9mIFZNIHJlY29tbWVu ZGVkIG9ubHkgZm9yIGxhcmdlIEJBUiBzeXN0ZW1cbiIpOwo+ICAgCXZtLT5sYXN0X3VwZGF0ZSA9 IE5VTEw7Cj4KPiAtCWZsYWdzID0gQU1ER1BVX0dFTV9DUkVBVEVfVlJBTV9DT05USUdVT1VTOwo+ IC0JaWYgKHZtLT51c2VfY3B1X2Zvcl91cGRhdGUpCj4gLQkJZmxhZ3MgfD0gQU1ER1BVX0dFTV9D UkVBVEVfQ1BVX0FDQ0VTU19SRVFVSVJFRDsKPiAtCWVsc2UKPiAtCQlmbGFncyB8PSBBTURHUFVf R0VNX0NSRUFURV9TSEFET1c7Cj4gLQo+IC0Jc2l6ZSA9IGFtZGdwdV92bV9ib19zaXplKGFkZXYs IGFkZXYtPnZtX21hbmFnZXIucm9vdF9sZXZlbCk7Cj4gLQltZW1zZXQoJmJwLCAwLCBzaXplb2Yo YnApKTsKPiAtCWJwLnNpemUgPSBzaXplOwo+IC0JYnAuYnl0ZV9hbGlnbiA9IEFNREdQVV9HUFVf UEFHRV9TSVpFOwo+IC0JYnAuZG9tYWluID0gQU1ER1BVX0dFTV9ET01BSU5fVlJBTTsKPiAtCWJw LmZsYWdzID0gZmxhZ3M7Cj4gLQlicC50eXBlID0gdHRtX2JvX3R5cGVfa2VybmVsOwo+IC0JYnAu cmVzdiA9IE5VTEw7Cj4gKwlhbWRncHVfdm1fYm9fcGFyYW0oYWRldiwgdm0sIGFkZXYtPnZtX21h bmFnZXIucm9vdF9sZXZlbCwgJmJwKTsKPiAgIAlyID0gYW1kZ3B1X2JvX2NyZWF0ZShhZGV2LCAm YnAsICZyb290KTsKPiAgIAlpZiAocikKPiAgIAkJZ290byBlcnJvcl9mcmVlX3NjaGVkX2VudGl0 eTsKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQt Z2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK