From: "Zhang, Jerry (Junwei)" <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
To: Qiang Yu <Qiang.Yu-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: "Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
"Hui Deng" <hui.deng-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function.
Date: Mon, 3 Sep 2018 15:18:14 +0800 [thread overview]
Message-ID: <5B8CE036.8050102@amd.com> (raw)
In-Reply-To: <1535957709-26008-1-git-send-email-Qiang.Yu-5C7GfCeVMHo@public.gmane.org>
On 09/03/2018 02:55 PM, Qiang Yu wrote:
> For Pro OGL be able to work with upstream libdrm.
>
> Signed-off-by: Qiang Yu <Qiang.Yu@amd.com>
> Reviewed-by: Christian König <christian.koenig@amd.com>
I'm fine with that, not sure if mesa is going to use that as well.
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
Regards,
Jerry
> ---
> amdgpu/amdgpu-symbol-check | 1 +
> amdgpu/amdgpu.h | 15 ++++++++++++++-
> amdgpu/amdgpu_bo.c | 6 ++++++
> 3 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-check
> index b5e4fe6..487610e 100755
> --- a/amdgpu/amdgpu-symbol-check
> +++ b/amdgpu/amdgpu-symbol-check
> @@ -15,6 +15,7 @@ amdgpu_bo_cpu_map
> amdgpu_bo_cpu_unmap
> amdgpu_bo_export
> amdgpu_bo_free
> +amdgpu_bo_inc_ref
> amdgpu_bo_import
> amdgpu_bo_list_create
> amdgpu_bo_list_destroy
> diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h
> index a8c353c..e1f93f8 100644
> --- a/amdgpu/amdgpu.h
> +++ b/amdgpu/amdgpu.h
> @@ -721,7 +721,20 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
> int amdgpu_bo_free(amdgpu_bo_handle buf_handle);
>
> /**
> - * Request CPU access to GPU accessible memory
> + * Increase the reference count of a buffer object
> + *
> + * \param bo - \c [in] Buffer object handle to increase the reference count
> + *
> + * \return 0 on success\n
> + * <0 - Negative POSIX Error code
> + *
> + * \sa amdgpu_bo_alloc(), amdgpu_bo_free()
> + *
> +*/
> +int amdgpu_bo_inc_ref(amdgpu_bo_handle bo);
> +
> +/**
> + * Request CPU access to GPU accessable memory
> *
> * \param buf_handle - \c [in] Buffer handle
> * \param cpu - \c [out] CPU address to be used for access
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index a2fc525..dceab01 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -438,6 +438,12 @@ int amdgpu_bo_free(amdgpu_bo_handle buf_handle)
> return 0;
> }
>
> +int amdgpu_bo_inc_ref(amdgpu_bo_handle bo)
> +{
> + atomic_inc(&bo->refcount);
> + return 0;
> +}
> +
> int amdgpu_bo_cpu_map(amdgpu_bo_handle bo, void **cpu)
> {
> union drm_amdgpu_gem_mmap args;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2018-09-03 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 6:55 [PATCH libdrm] amdgpu: add amdgpu_bo_inc_ref() function Qiang Yu
[not found] ` <1535957709-26008-1-git-send-email-Qiang.Yu-5C7GfCeVMHo@public.gmane.org>
2018-09-03 7:18 ` Zhang, Jerry (Junwei) [this message]
[not found] ` <5B8CE036.8050102-5C7GfCeVMHo@public.gmane.org>
2018-09-03 8:03 ` Yu, Qiang
[not found] ` <BY2PR12MB0243586F3EAAD25B3A2308AC8F0C0-K//h7OWB4q7MW+x49lsN/QdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-09-03 8:57 ` Christian König
[not found] ` <a62cdc40-80b4-6d51-b504-794fcc4a68c0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-03 8:58 ` Yu, Qiang
2018-09-03 9:46 ` Michel Dänzer
[not found] ` <ff7f2575-7c8b-3083-d10a-7445bbaa6f14-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-09-03 9:52 ` Yu, Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B8CE036.8050102@amd.com \
--to=jerry.zhang-5c7gfcevmho@public.gmane.org \
--cc=Qiang.Yu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=hui.deng-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.