From: zhong jiang <zhongjiang@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <edumazet@google.com>, <kuznet@ms2.inr.ac.ru>,
<yoshfuji@linux-ipv6.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ipv4: Use BUG_ON directly instead of a if condition followed by BUG
Date: Wed, 12 Sep 2018 21:25:18 +0800 [thread overview]
Message-ID: <5B9913BE.1040807@huawei.com> (raw)
In-Reply-To: <20180911.235417.1481257495387934935.davem@davemloft.net>
On 2018/9/12 14:54, David Miller wrote:
> From: zhong jiang <zhongjiang@huawei.com>
> Date: Mon, 10 Sep 2018 22:38:02 +0800
>
>> The if condition can be removed if we use BUG_ON directly.
>> The issule is detected with the help of Coccinelle.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> You keep asking if this is worthy to do.
>
> I think the most worthy thing to do is actually build test your
> patches.
I am sorry for that. :-[
Thanks,
zhong jiang
prev parent reply other threads:[~2018-09-12 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 14:38 [PATCH] net: ipv4: Use BUG_ON directly instead of a if condition followed by BUG zhong jiang
2018-09-10 15:39 ` Jiri Benc
2018-09-11 1:12 ` zhong jiang
2018-09-10 20:23 ` kbuild test robot
2018-09-10 21:20 ` kbuild test robot
2018-09-11 8:51 ` Sergei Shtylyov
2018-09-11 8:59 ` zhong jiang
2018-09-11 9:11 ` Sergei Shtylyov
2018-09-11 9:19 ` zhong jiang
2018-09-11 9:33 ` Sergei Shtylyov
2018-09-12 6:54 ` David Miller
2018-09-12 13:25 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B9913BE.1040807@huawei.com \
--to=zhongjiang@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.