All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Fix a GCC compiled warning.
Date: Sat, 15 Sep 2018 09:18:19 +0800	[thread overview]
Message-ID: <5B9C5DDB.7060809@huawei.com> (raw)
In-Reply-To: <CANiq72ndUkKyZ1gxgv9kv_Niq0sb7RwLj4QGrKNa2bg_jmd45A@mail.gmail.com>

On 2018/9/15 0:43, Miguel Ojeda wrote:
> Hi Zhong,
>
> On Fri, Sep 14, 2018 at 4:49 PM, zhong jiang <zhongjiang@huawei.com> wrote:
>> Fix the following compile warning:
>>
>> kernel/sched/core.c: In function ‘update_rq_clock_task’:
>> kernel/sched/core.c:139:6: warning: unused variable ‘steal’ [-Wunused-variable]
>>   s64 steal = 0, irq_delta = 0;
>>
> Dou (and I, without having noticed Dou's) also sent another patch for this, see:
>
>   https://lore.kernel.org/patchwork/patch/973402/
>   https://lore.kernel.org/patchwork/patch/983794/
Thank you for spoting this. I miss them.

Sincerely,
zhong jiang
> Cheers,
> Miguel
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  kernel/sched/core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
>> index 7577ce4..1003c1d 100644
>> --- a/kernel/sched/core.c
>> +++ b/kernel/sched/core.c
>> @@ -136,7 +136,7 @@ static void update_rq_clock_task(struct rq *rq, s64 delta)
>>   * to sched_rt_avg_update. But I don't trust it...
>>   */
>>  #if defined(CONFIG_IRQ_TIME_ACCOUNTING) || defined(CONFIG_PARAVIRT_TIME_ACCOUNTING)
>> -       s64 steal = 0, irq_delta = 0;
>> +       s64 __maybe_unused steal = 0, irq_delta = 0;
>>  #endif
>>  #ifdef CONFIG_IRQ_TIME_ACCOUNTING
>>         irq_delta = irq_time_read(cpu_of(rq)) - rq->prev_irq_time;
>> --
>> 1.7.12.4
>>
>



      reply	other threads:[~2018-09-15  1:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14 14:49 [PATCH] sched: Fix a GCC compiled warning zhong jiang
2018-09-14 16:43 ` Miguel Ojeda
2018-09-15  1:18   ` zhong jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B9C5DDB.7060809@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.