All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: <kvalo@codeaurora.org>, <davem@davemloft.net>,
	<libertas-dev@lists.infradead.org>,
	<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libertas: remove set but not used variable 'int_type'
Date: Tue, 23 Oct 2018 22:28:10 +0800	[thread overview]
Message-ID: <5BCF2FFA.3060109@huawei.com> (raw)
In-Reply-To: <25ed3d0b71eb34e121f2d7a8d936665d7720270f.camel@v3.sk>

On 2018/10/23 22:23, Lubomir Rintel wrote:
> On Tue, 2018-10-23 at 11:32 +0800, zhong jiang wrote:
>> int_type is not used after setting its value. It is safe to remove
>> the unused variable.
> Hi. I believe your colleague has sent an equivalent patch a few days
> ago in <1539569795-176889-1-git-send-email-yuehaibing@huawei.com>:
>
> https://lore.kernel.org/linux-wireless/1539569795-176889-1-git-send-email-yuehaibing@huawei.com/
I miss that. Thanks, please ignore the patch.

Sincerely,
zhong jiang
> Cheers,
> Lubo
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  drivers/net/wireless/marvell/libertas/if_spi.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/marvell/libertas/if_spi.c
>> b/drivers/net/wireless/marvell/libertas/if_spi.c
>> index 504d6e0..7c3224b 100644
>> --- a/drivers/net/wireless/marvell/libertas/if_spi.c
>> +++ b/drivers/net/wireless/marvell/libertas/if_spi.c
>> @@ -796,15 +796,13 @@ static void if_spi_h2c(struct if_spi_card
>> *card,
>>  {
>>  	struct lbs_private *priv = card->priv;
>>  	int err = 0;
>> -	u16 int_type, port_reg;
>> +	u16 port_reg;
>>  
>>  	switch (type) {
>>  	case MVMS_DAT:
>> -		int_type = IF_SPI_CIC_TX_DOWNLOAD_OVER;
>>  		port_reg = IF_SPI_DATA_RDWRPORT_REG;
>>  		break;
>>  	case MVMS_CMD:
>> -		int_type = IF_SPI_CIC_CMD_DOWNLOAD_OVER;
>>  		port_reg = IF_SPI_CMD_RDWRPORT_REG;
>>  		break;
>>  	default:
>
> .
>



  reply	other threads:[~2018-10-23 14:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  3:32 [PATCH] libertas: remove set but not used variable 'int_type' zhong jiang
2018-10-23 14:23 ` Lubomir Rintel
2018-10-23 14:28   ` zhong jiang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-15  2:16 YueHaibing
2018-10-15  2:16 ` YueHaibing
2018-10-15  2:16 ` YueHaibing
2018-10-23 14:25 ` Lubomir Rintel
2018-10-23 14:25   ` Lubomir Rintel
2018-10-23 14:25   ` Lubomir Rintel
2018-11-06 16:52 ` Kalle Valo
2018-11-06 16:52   ` Kalle Valo
2018-11-06 16:52   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BCF2FFA.3060109@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kvalo@codeaurora.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.