All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] zram/zram03.c: Fix obsolete zram status files
Date: Tue, 6 Nov 2018 09:43:43 +0800	[thread overview]
Message-ID: <5BE0F1CF.5060001@cn.fujitsu.com> (raw)
In-Reply-To: <20181106000327.GA4619@dell5510>

On 2018/11/06 8:03, Petr Vorel wrote:
> Hi Xiao,
>
>> Since kernel commit c87d1655c295, separate zram status files("compr_data_size",
>> "num_reads" etc.) which can be accessed via one of zram<id>/stat or
>> zram<id>/io_stat or zram<id>/mm_stat were removed.
>> This commit broke zram03, as below:
>> ----------------------------------------------------------------------
>> safe_file_ops.c:144: Failed to open FILE '/sys/block/zram0/compr_data_size'
>> for reading at zram03.c:181: errno=ENOENT(2): No such file or directory
>> ----------------------------------------------------------------------
>> Also, zero pages in zram<id>/mm_stat was extended to same element pages
>> since kernel commit 8e19d540d107.
>> We try to get requested zram status by zram<id>/stat and zram<id>/mm_stat
>> if separate zram status files don't exist.
>> URL for detailed zram status:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/blockdev/zram.txt
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/block/stat.txt
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>> ---
> Thanks for your patch, merged!
> I'm sorry to keep you waiting for review so long.
Hi Petr,

It doesn't matter, thanks for your review and push. :-)

Best Regards,
Xiao Yang
>
> Kind regards,
> Petr
>
>
>




      reply	other threads:[~2018-11-06  1:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  8:56 [LTP] [PATCH] zram/zram03.c: Fix obsolete zram status files Xiao Yang
2018-09-03  2:17 ` Xiao Yang
2018-09-13  7:39 ` Xiao Yang
2018-11-06  0:03 ` Petr Vorel
2018-11-06  1:43   ` Xiao Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BE0F1CF.5060001@cn.fujitsu.com \
    --to=yangx.jy@cn.fujitsu.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.